From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FE8D3F823C for ; Fri, 17 Jul 2026 12:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784292249; cv=none; b=MWwoA04L/8qyYuaROLGArPX47vxfRI+W7a6tZMuSjWFrEw1iHX9k4qgjdmChPUnc6tcppQ67xPNtnlEcFMQjRdLS1QXKQFgr6/tNpwWoGnEWgCjWKp8/nXtcpvNRizPGnS1n7SKnLiQxs3N8LXgdThoEH/f9mHDIom25txCy0/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784292249; c=relaxed/simple; bh=huPV0bvapPbYMH10KQbV3TuHqNMdtv5h9UfrCwHorpk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fNtM4Zww6hPT0UBQ4iMp7Ja1nz+EKPfxNKwEsQ5lCYIGb4E5LrMiT8srh2w+mShDwDJtbZukKMHuygqyphxUxKNaIKtZfML9mGjM6Or9+GPHFsSSntAaY7KVyV0F+KNP/UpZAUp4g2+HbyaI2gM0w1buOlsYlczI0OxkyfSjW/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RVvJ1cB1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IqyJ3WYw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RVvJ1cB1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IqyJ3WYw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784292247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FJHxU0nZsS0jGtG1L8drSuZrAPuT2Fil33pvaZreEIU=; b=RVvJ1cB1X7yQJZzBmvNDmG/0XvhPh43PRXj+3KHEJAND2XBRblwq6WzsbOtwpDymKNwQqB zdGz0tTVnCJa5WtLrPd/K3RZfc/jw1epxtwMOx2Rowc1iZHfVINOvyREqrKgkThXpJHS59 b+rnO+deE9jRhCMfXwmWqirTLZv8HGA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-_FRH9VuJOse3R1pfnZB2gw-1; Fri, 17 Jul 2026 08:44:05 -0400 X-MC-Unique: _FRH9VuJOse3R1pfnZB2gw-1 X-Mimecast-MFC-AGG-ID: _FRH9VuJOse3R1pfnZB2gw_1784292245 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47bbe3b9705so6881172f8f.0 for ; Fri, 17 Jul 2026 05:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784292244; x=1784897044; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FJHxU0nZsS0jGtG1L8drSuZrAPuT2Fil33pvaZreEIU=; b=IqyJ3WYwr1FN0ZUPZPB3RivJccOze8iPCgiBvzIOPo+XV3s2VDu5ActMRAMI7yW2y+ sw0yXdyyvehC6DPA1Eei+2pmXDpAtptXxqp+mqHqdWlhksY8BsFaMtrlq5X0UC7owJYj H+QNGEh+BFmvLBVpBl/Ohi4eFQKKh/Je11QnP6ldPafWkdgJjlV31EeuoiHeco1rcHhW plReRUufHlRRBEBl6mBijgiuEofUs2JcCqRDyR0qroD4a44RHwP2smd9a+8CUyILsf9N ZHPqJeMbjzXfr82t3bqR9P2kIm0rShgtG/FyKE8m3Ax4/wPvS7Z0vDGDxol5wAOGIiAF aZLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784292244; x=1784897044; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FJHxU0nZsS0jGtG1L8drSuZrAPuT2Fil33pvaZreEIU=; b=QOynCKoS0gA4LhFW4AZpnZLLHFrrL679+GNsyAkJ4W0vBcPVwZIGb948jDeWbPerrD maiN4YH2SvFcbrp+ekvEVuKRiu2Q8DjfgnoqPH1ND79rldg600pPRhJMhs5ZV7juL1AK IQ9iqPn9/BT2fvwASvxFnkkRfTmskyJhXwzPTpmZt1hmTloxkZolpgOWfShKmsewrJxJ qG9lWOp557eeTZcUODCu9KJ4Ii51hTmyepwkr1+0BkHmvohxj+yZuM0R2ymh1zrZDGIx 7Eqvf8xL6PTNe3KDRi8s5kJ+OTeKs8hnJpmbjxc8M6DX+ZB8QpDK9dGr/8MOZ2fJogya Hj6g== X-Forwarded-Encrypted: i=1; AHgh+Rp908AFGwreWNxgAIDwMXJJUbWMU2dnctY3VJjtf07S2a6pE3M1wWJhRA6bw+wuKn1rlf3jvH3rcwJTnAs=@vger.kernel.org X-Gm-Message-State: AOJu0YxOX45ptO/SuoxUs4gmBUhjLHNXMahKORSCnzQIE+prHInJj7F1 0nrNWrZ29xd8TDs28X9pFg4ADs9PKTrwW4vWims1AqYb1ngcAu9XDpMMDuQTagFHWmH38gpt5aL 12oKDiJPpR6q7/lTAUzn4LrQ3aD792hQlioQJW6Yh4NNwDH1SYOIMYllbOnDDuhjNjA== X-Gm-Gg: AfdE7cm9/7sgRewVMWdQfIhxXTMuBPanCP1kiWMDaeR2PbBmc1Lwv0XU9kcp8TDJ12S Il6PrpymRo52advcoVbl8cdxWPRmM2Lii62F8XAjO9FCyNOjuzlD00hryYbpQDWgYLxpL5QRfSt IyuMycELmpgxioUmaob2ptZw0Mh6yN1HCKbjKYSIfUDy9I7li7Nua/ns3kv7iipO4+DuW3NGZCR 90mHZkcmN3o84eWsQF7fFibSr4AwSAhwVrdQFpNbUyiy0Xud0GvDXnS5fUfVZJeKOLOAnmrXx39 e8W/Vn4iBm+Wh8f4kGzfzr17u/X7txFLhTjSI/prDMgx37MVOwfvxXIS+S5wS0y34hKM8Jyqr1+ PJnaLZwJT+mSR9knDUn+oFJF244uTaZ6jwL7bbYLIgn8is4gNfWvCWltvzra2o6mCqPHdAc6bhT XP/Q== X-Received: by 2002:a05:6000:25e2:b0:47f:4e46:e9e8 with SMTP id ffacd0b85a97d-47f622fccb7mr3285874f8f.6.1784292244616; Fri, 17 Jul 2026 05:44:04 -0700 (PDT) X-Received: by 2002:a05:6000:25e2:b0:47f:4e46:e9e8 with SMTP id ffacd0b85a97d-47f622fccb7mr3285839f8f.6.1784292244150; Fri, 17 Jul 2026 05:44:04 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63ee926dsm3233222f8f.35.2026.07.17.05.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 05:44:03 -0700 (PDT) Message-ID: <382033a5-77a6-4505-ac50-58120308507b@redhat.com> Date: Fri, 17 Jul 2026 14:44:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: dpaa: fix mode setting To: Sean Anderson , Michael Walle , Madalin Bucur , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260710143430.2276141-1-mwalle@kernel.org> <2c8f63f5-f04a-4abc-9508-4c47a80da543@redhat.com> <26cb3349-5344-48c0-b0b7-37133b4e0662@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/17/26 2:05 PM, Sean Anderson wrote: > On 7/17/26 07:11, Paolo Abeni wrote: >> On 7/17/26 12:13 PM, Michael Walle wrote: >>> I've seen that, but.. that was the actual change between v1 and v2 >>> as suggested by Sean. It does not depend on the actual link speed, >>> but the maximum link speed. So it is not relevant if the link >>> negotiates to a slower speed or not. At least that now matches the >>> behavior prior to the phylink conversion. If that was working - >>> that I can't tell you. >> >> I'm sorry, following all cross revision discussion is a bit hard here. >> >> I don't understand if the 'link never established' is specific of your >> board, or it a constant with this driver. Could you please clarify? > > I think we should set byte/nibble mode in link_up as well as mac_config. That > should fix the problem where the link never comes up (possibly broken since > the phylink conversion). I think it's unlikely that this config is supposed > to match the phy interface speed and not the link speed, but you never know... FTR, the above does not answer my question ;) Still I think (mostly guess) bringing the mode initialization in both link_up and mac_config should be safer (that is, I agree with the above plan). /P