From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A573C13E5 for ; Tue, 15 Sep 2026 02:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789440576; cv=none; b=se4BLlZ462IWhxBGxAb3EXv+N8Z/cc1eGVAxmBe1qvPKObo4R9RninJM0fBSwV2GQMY0F3R6f0CzSkCV5ZXoXlLw2cfMVxLqdrMCjxxuUewbcIaiZyhCS/kF6AmUPgj5miuEUHyRDSayICFx96VWpzYhmUOXJE5tB7Qu72sdHZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789440576; c=relaxed/simple; bh=EqMM7tTheAmiO2pL0AejZmpC4UNuhUpme9BMfGc+edc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L0p+HNbaQcp8JJFkDU0OwwhWPOS0vsVlWUdfhZ+0/xgW+yg7nNeg8/hX/W/5ux6iFWSnAiz5EY/SDASP6lbOzqLwrqBo0rYAvpPck1UYgr75/lYmizh0AZAG/Lqb1EOh9qRMZHGD7T11TJOGmTkGbRFC4Xa1pQLkrBEFDYwb9hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fl7YelN8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UC/9EXzB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fl7YelN8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UC/9EXzB" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F2nXb82298498 for ; Tue, 15 Sep 2026 02:49:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N5L/sut4FAKbjGdymDCKaX2hkXlq96ynrY1kfZ9pBAY=; b=Fl7YelN818eUZTu1 0Kzflq90g7OCnKCWBJgKVz0EOsFkpXAHATYPPJoWI0f7W8CmKsdS6gTpcz9DneIg H5zVO+yu/8JQmTB5p/6nzQrXcv5DvdTTl8tw9+QDpWvIsCzXKVrNHWwCrn/8n7h6 eMUyFXWcU76o/b0O901lhOAqp3q7HdV6UYg0Ep8hRicHAyG9X84o9JV/zV7ejPYq Q/pYa13wA5453I2eMTN8Q/zL19Ma0jiriEc4REQk1P7H6EwZvPNbbTuCS1QfBH+v QP5jZ3UVK7yPcf2WxRPk+Nl/WYlVEFHBO5RvFq3hVhXC+t4QBuU3MNj3xiH+uko1 ZVFF/Q== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gpgvtk44p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 15 Sep 2026 02:49:33 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-39de4a68f7cso2677543a91.1 for ; Mon, 14 Sep 2026 19:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789440572; x=1790045372; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N5L/sut4FAKbjGdymDCKaX2hkXlq96ynrY1kfZ9pBAY=; b=UC/9EXzB7OQurkGx41vfxjzyG1iMbYtTedI65UbEBpWI92AFNte6ofPIO+ZF0cE5Wk 7uPwOUpjgjN6kPhn8hX2S9IYSqQ4zE/xI+uAVCj3XPwXnXD2sMJT8MLf9ryDzbBI6k5W LhR1/iBzyuyOi6JYJnDYaeO7SYNAziw8EVnD97/qqL+MOpWr85OI6PGmw4PwnNUgvooF 7L8kT6WrnkkZPwWYHPBbf2BAxw0f8yo4n7qSeC58h4zY0kYHlUEM4bjBJ/o0LJaanldH Z1SYx3FszRrIZtF59lJYgjKjhOjI8HN8n5B2wgbbAloXrYoAgC6bFRYPky00azbkmzO7 0m/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789440572; x=1790045372; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=N5L/sut4FAKbjGdymDCKaX2hkXlq96ynrY1kfZ9pBAY=; b=sHaHcdgqgg2l7YW6CdZDchLWxkk+kEJ0DLp8fGzlrd2MCe3OlAtgpNmExPdEV7AUQV lPWcoeRDyKXreCAlpP2q4Hj8vPJTYh3Zg32IzLzsXYv5ueRIUAKd9H664FvOc7rpGYao jGZ44rPe/tdarpAeub3eycPJmtVc9RJeIJdume/YBc2RfR9W+vqG8AHNUyxD/531tiJd QmwpulPqy2jXGd58mKe2XHH1YCNwcah3bqAC0brr9h/Zy00c97ssDsuP06EcIxyNi1br zFGFoeuTLR7odDPp4o658kXvdxQ/u1WRZYPJtyqQ6yefKnWyHFPzBr4iW1uG+/0ZtPVu 7slA== X-Forwarded-Encrypted: i=1; AKwUvBwG6hy0OCapvqjxrxiEEPwcNHvO8pRN+XnvLZ4AwOjRaipnCYRz/8nWL0V7llR7tNLQ927YVs0Qr66mY0s=@vger.kernel.org X-Gm-Message-State: AFuF++nXHxeYAwXH6+8ljmPJxbPsQzh1huIbWzgNyGDPTB+HqWnis0kM oebCJQkEcfTG6BI8s8SeTjzxiL35eioERfpZSvFrK3uaYzFioy3cqq2HOXNPw7jPMFKXw+ZGSOY 9vq0557sCpgoWpIEfFJ1aJ7Wo1A6LJrPBo1qaPiv/4A4prNa/t7KwUITXne9sAQ9sQ6E= X-Gm-Gg: AYBFou3inxeIrq1PtVUwtLTeVoOnEzYHqCRuxwtarfj5YHRUkjDIlboTkKQzGuXcOjU 1nAoa9IGcx/UfgJ2TfUCKf1ydyLmMx0Y+S450VDV+iI2U2KJ/sSHJiqf7o7jewnmQah1hi3L0oQ AWRBS5LhTJZF/JV07osresltZyb1Z9mqUZXAsIy/eWb8WPS8mvZ3ihPjZBAyoHPWduxgddDpPV/ UqWQR/035TN+rflNEO/twu7btAzls40AmBXMrPSs3oXmMrP+yUZAbs/sfsKQHKePebJbpqy9LtE Iz0Sx7iplOV9R3eeqKiksQOU7RjXeARYY4LulgU75HBgdKsVKjG3H0qgI6qdymVqfEfP+q05DfO ohcYjT5XPgu36FvhPBoTeVblnQiNhiFMF8SS9StGO+ATGR/8O/SB/d2a3KTXiSQ4= X-Received: by 2002:a17:90b:1c83:b0:39e:27e:21b3 with SMTP id 98e67ed59e1d1-39e027e229fmr2340011a91.9.1789440572263; Mon, 14 Sep 2026 19:49:32 -0700 (PDT) X-Received: by 2002:a17:90b:1c83:b0:39e:27e:21b3 with SMTP id 98e67ed59e1d1-39e027e229fmr2339934a91.9.1789440571725; Mon, 14 Sep 2026 19:49:31 -0700 (PDT) Received: from [10.133.33.86] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39dfda39eb4sm2127854a91.8.2026.09.14.19.49.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 19:49:31 -0700 (PDT) Message-ID: <38215e79-34b6-4731-9853-d7f529861162@oss.qualcomm.com> Date: Tue, 15 Sep 2026 10:49:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 03/10] dt-bindings: arm: Add MPAM MSC binding To: Andre Przywara , James Morse , Rob Herring , Shanker Donthineni , Ben Horgan , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Reinette Chatre , Fenghua Yu , Jonathan Cameron , Bjorn Andersson , Konrad Dybcio , Gavin Shan Cc: Drew Fustini , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Shaopeng Tan , trilok.soni@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, ganapatrao.kulkarni@oss.qualcomm.com, Srivathsa L Rao , Huang Yiwei , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org References: <20260914-mpam-resctrl-dt-knp-support-v2-0-bf6645bb2f65@oss.qualcomm.com> <20260914-mpam-resctrl-dt-knp-support-v2-3-bf6645bb2f65@oss.qualcomm.com> <07d32b4c-1f00-45e5-b318-0f28bbb46f33@arm.com> Content-Language: en-US From: Yin Li In-Reply-To: <07d32b4c-1f00-45e5-b318-0f28bbb46f33@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=c/0+0h9l c=1 sm=1 tr=0 ts=6aa8b23d cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=gEfo2CItAAAA:8 a=7CQSdrXTAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=uI_jzqnufFvfmlbxwmcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=sptkURWiP4Gy88Gu7hUp:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDAzNiBTYWx0ZWRfX7IyGNwkgM9yk pRYOmkEkota3mk3AFk40BS5bpKI9F66KSMn0/1thkQPjqIZjMREbBhaRsMuRxSU1zX0L8hWWjN2 D5vbJi7qu/C1c0pQ+ayAFT336xAFrjPcGnfA3JnHu5IVUfg1ejgSVCmOUOsz401FPl8ojpJ0eIb 8E96/wyQ0zaDf3dbbXxoqM57XwPZbYkOTmppSCl+k5chsUlYQ5rU0FSfSavO9kjeZZTw4Lk22z7 kZ4zZurpebmQJiK04ygkpzAZTHpmPXyquGU9901DYkuuCJ7FsmHvv2SEAALpE8Kny0Sf7+5Q61W uoAEYnF/d5vzWp6jD97ntqB9B1CbMK0Uo5CWeGsttyh8OgWxmjZ0EMlDsPrfo+zDmQR0TZLdM63 dVsWFXLsGq/8DJZBT/fxcr/feGLxXPs3aGy1MSmdfD8nQCI7MRp2NGrBWD5oqwWeicyUE+m9UW/ 0vUi3cjRUgJ8e+zeXCA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDAzNiBTYWx0ZWRfX2UppgnYbAfhH GPedUsd/d5AkRVzfRCKq6E4zCDG+/NO7Ysf7DCniDd8eISH2lQV/g8yE2Ez5E2fllx4PazHEdh9 Dmv5M2imO5Td/MkcyMIzLN5w9Jcffu4= X-Proofpoint-ORIG-GUID: q5c-ORCZqlo8K-dSjG98GeLhZPxglmlP X-Proofpoint-GUID: q5c-ORCZqlo8K-dSjG98GeLhZPxglmlP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_01,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150036 On 9/14/2026 10:50 PM, Andre Przywara wrote: > Hi, > > On 9/14/26 16:41, Andre Przywara wrote: >> Hi, >> >> On 9/14/26 11:37, Yin Li wrote: >>> From: Rob Herring >>> >>> The binding is designed around the assumption that an MSC will be a >>> sub-block of something else such as a memory controller, cache >>> controller, >>> or IOMMU. However, it's certainly possible a design does not have that >>> association or has a mixture of both, so the binding illustrates how >>> we can >>> support that with RIS child nodes. >>> >>> A key part of MPAM is we need to know about all of the MSCs in the >>> system >>> before it can be enabled. This drives the need for the genericish >>> 'arm,mpam-msc' compatible. Though we can't assume an MSC is accessible >>> until a h/w specific driver potentially enables the h/w. >>> >>> Cc: James Morse >>> Signed-off-by: Rob Herring >>> Signed-off-by: James Morse >>> Signed-off-by: Yin Li >>> --- >>>   .../devicetree/bindings/arm/arm,mpam-msc.yaml      | 199 ++++++++++ >>> + ++++++++++ >>>   1 file changed, 199 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml >>> b/Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml >>> new file mode 100644 >>> index 000000000000..53a6fdbbf05f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml >>> @@ -0,0 +1,199 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/arm/arm,mpam-msc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Arm Memory System Resource Partitioning and Monitoring (MPAM) >>> + >>> +description: | >>> +  The Arm MPAM specification can be found here: >>> + >>> +  https://developer.arm.com/documentation/ddi0598/latest >>> + >>> +maintainers: >>> +  - Rob Herring >>> + >>> +properties: >>> +  compatible: >>> +    items: >>> +      - const: arm,mpam-msc                   # Further details are >>> discoverable >>> +      - const: arm,mpam-memory-controller-msc >> >> But that doesn't match the examples below, does it? Don't we want to >> allow just "arm,mpam-msc", but also the memory controller string, with >> "arm,mpam-msc" as a fallback? >> I guess the pattern should then look similar to interrupt-names below? > > Just seeing that you fix this and other things up in patch 08/10 later. > I think it's confusing to have this split now for a v2 still. I wouldn't > be aware of previous review of this original patch, so it doesn't really > matter. Please squash them. > > So I think you should merge 07/10 and 08/10 into their original patches, > otherwise reviewers might just get confused. > > But you might wait for a bit with a repost, to see if there are more > generic comments on DT support. > Hi Andre, Good catch on the compatible issue in 03/10: you're right, "items" requires both strings to be present, whereas we want to allow standalone "arm,mpam-msc" or the two-item combination. This is fixed in 08/10 using "oneOf"; the iommu example with the TODO is also fixed there. On squashing: sorry for the confusion and agreed on both points. Since this is still an RFC and the original authors haven't commented yet, I've kept the fixes as separate patches to make it easier for them to review. I'll squash them in the next version. Thanks for your quick review! Yin > Cheers, > Andre > > -- Thx and BRs, Yin