From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754713AbcIVE1I (ORCPT ); Thu, 22 Sep 2016 00:27:08 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:43539 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334AbcIVE1F (ORCPT ); Thu, 22 Sep 2016 00:27:05 -0400 X-AuditID: cbfee68d-f790c6d000004a75-fe-57e35d9721fd Subject: Re: [PATCH v2 4/4] mmc: dw_mmc: use macro to define ring buffer size To: Shawn Lin References: <1472789679-15121-1-git-send-email-shawn.lin@rock-chips.com> <1472789679-15121-4-git-send-email-shawn.lin@rock-chips.com> Cc: Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , Heiko Stuebner , linux-rockchip@lists.infradead.org From: Jaehoon Chung Message-id: <382333f8-5bd3-f61e-2802-16a36db5c75f@samsung.com> Date: Thu, 22 Sep 2016 13:27:03 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1472789679-15121-4-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsWyRsSkQHd67ONwg+vbDSzOLjvIZvH/0WtW i8u75rBZHPnfz2jx6cF/Zos7T9azWhxfG+7A7jG74SKLx51re9g8Ni+p9/g7az+Lx/Zr85g9 Pm+SC2CL4rJJSc3JLEst0rdL4Mro/LqcteC0WMW7V5+YGxifCHYxcnJICJhI/H10nA3CFpO4 cG89kM3FISSwglFiw5V+Vpiiax3TWCASSxklrs9vZQRJCAk8YJT4844DxBYW8JU4P3kpO4gt IqAhcePsdTaImtuMEi+fC4M0MwtcYpR4/O8+C0iCTUBHYvu340wgNq+AncTVfd1ADewcLAKq EvfLQKKiAmESJ8+dY4eoEJT4MfkeWCengKfEp2dfgKo5gEbqSdy/qAUSZhaQl9i85i0zyCYJ gXvsEvOetoOdwCIgIPFt8iEWkHoJAVmJTQeYId6SlDi44gbLBEaxWUg2zEKYOgvJ1AWMzKsY RVMLkguKk9KLDPWKE3OLS/PS9ZLzczcxAuPu9L9nvTsYbx+wPsQowMGoxMOr8f1RuBBrYllx Ze4hRlOgIyYyS4km5wOjO68k3tDYzMjC1MTU2Mjc0kxJnFdR6mewkEB6YklqdmpqQWpRfFFp TmrxIUYmDk6pBkb5LyIpakVp90UP83qe5Jpzt461I7Lc/eT1WaXSv/5/2WDzVVRHMO/6ykIt /ccm8pWPjp/8fWQJ+xUdJg3nx9systQe7X06K5XF/eKj/WfXnjW/7mnrYLG6X//a1d0Hom3Z NvrtiRPZ4dPYI/1b6I3Kvm1Rf84LH1UP2lH7KvW2zpMJB3YEB1oqsRRnJBpqMRcVJwIAqKbs MLYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsVy+t9jAd3psY/DDbZd1LI4u+wgm8X/R69Z LS7vmsNmceR/P6PFpwf/mS3uPFnPanF8bbgDu8fshossHneu7WHz2Lyk3uPvrP0sHtuvzWP2 +LxJLoAtqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNct MwfoFCWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYQ1jRufX5awFp8Uq3r36 xNzA+ESwi5GTQ0LAROJaxzQWCFtM4sK99WxdjFwcQgJLGSWuz29lBEkICTxglPjzjgPEFhbw lTg/eSk7iC0ioCFx4+x1Noia24wSL58LgzQzC1xilHj87z7YVDYBHYnt344zgdi8AnYSV/d1 AzWwc7AIqErcLwOJigqESZw8d44dokJQ4sfke2CdnAKeEp+efQGq5gAaqSdx/6IWSJhZQF5i 85q3zBMYBWYh6ZiFUDULSdUCRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMGx/Uxq B+PBXe6HGAU4GJV4eDW+PwoXYk0sK67MPcQowcGsJMI7OfpxuBBvSmJlVWpRfnxRaU5q8SFG U6AnJjJLiSbnA9NOXkm8obGJmZGlkbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUa GBcdmKLsaviN8RyvUt2xMrm8s1x3dkwz4DrM6sk68anXTf/fqvvvdGfxP+Z+wMoQqVRQMfvx gbe/Lsd8Pu4gKm126Oqk/NvKNa/s6k2UNM2+Rz6Y/kJyyYUbk6bnFiyJnnVoy9cFP1qKS6xc qpNuzD26Me3A2Q9XePj6xTzeCpdFrBdzsm2o3a/EUpyRaKjFXFScCAD0TA8qAwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2016 01:14 PM, Shawn Lin wrote: > It's very prone to make mistake as we might forget > to replace all PAGE_SIZEs with new values if we try > to modify the ring buffer size for whatever reasons. > Let's use a macro to define it. Applied on my tree. Thanks! Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > --- > > Changes in v2: None > > drivers/mmc/host/dw_mmc.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 833b6ad..6e5926b 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -61,6 +61,8 @@ > SDMMC_IDMAC_INT_FBE | SDMMC_IDMAC_INT_RI | \ > SDMMC_IDMAC_INT_TI) > > +#define DESC_RING_BUF_SZ PAGE_SIZE > + > struct idmac_desc_64addr { > u32 des0; /* Control Descriptor */ > > @@ -474,7 +476,8 @@ static int dw_mci_idmac_init(struct dw_mci *host) > if (host->dma_64bit_address == 1) { > struct idmac_desc_64addr *p; > /* Number of descriptors in the ring buffer */ > - host->ring_size = PAGE_SIZE / sizeof(struct idmac_desc_64addr); > + host->ring_size = > + DESC_RING_BUF_SZ / sizeof(struct idmac_desc_64addr); > > /* Forward link the descriptor list */ > for (i = 0, p = host->sg_cpu; i < host->ring_size - 1; > @@ -500,7 +503,8 @@ static int dw_mci_idmac_init(struct dw_mci *host) > } else { > struct idmac_desc *p; > /* Number of descriptors in the ring buffer */ > - host->ring_size = PAGE_SIZE / sizeof(struct idmac_desc); > + host->ring_size = > + DESC_RING_BUF_SZ / sizeof(struct idmac_desc); > > /* Forward link the descriptor list */ > for (i = 0, p = host->sg_cpu; > @@ -609,7 +613,7 @@ static inline int dw_mci_prepare_desc64(struct dw_mci *host, > err_own_bit: > /* restore the descriptor chain as it's polluted */ > dev_dbg(host->dev, "desciptor is still owned by IDMAC.\n"); > - memset(host->sg_cpu, 0, PAGE_SIZE); > + memset(host->sg_cpu, 0, DESC_RING_BUF_SZ); > dw_mci_idmac_init(host); > return -EINVAL; > } > @@ -685,7 +689,7 @@ static inline int dw_mci_prepare_desc32(struct dw_mci *host, > err_own_bit: > /* restore the descriptor chain as it's polluted */ > dev_dbg(host->dev, "desciptor is still owned by IDMAC.\n"); > - memset(host->sg_cpu, 0, PAGE_SIZE); > + memset(host->sg_cpu, 0, DESC_RING_BUF_SZ); > dw_mci_idmac_init(host); > return -EINVAL; > } > @@ -2750,7 +2754,8 @@ static void dw_mci_init_dma(struct dw_mci *host) > } > > /* Alloc memory for sg translation */ > - host->sg_cpu = dmam_alloc_coherent(host->dev, PAGE_SIZE, > + host->sg_cpu = dmam_alloc_coherent(host->dev, > + DESC_RING_BUF_SZ, > &host->sg_dma, GFP_KERNEL); > if (!host->sg_cpu) { > dev_err(host->dev, >