mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yi Jiangshan" <13667453960@163.com>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	"Jiangshan Yi" <yijiangshan@kylinos.cn>,
	k2ci <kernel-bot@kylinos.cn>
Subject: Re:Re: [PATCH] staging: rtl8723bs: fix spelling typo in comment
Date: Mon, 10 Oct 2022 11:07:31 +0800 (CST)	[thread overview]
Message-ID: <382427df.1d30.183bfdca4b0.Coremail.13667453960@163.com> (raw)
In-Reply-To: <Y0MROo7YMrVoYyZ8@kroah.com>


At 2022-10-10 02:21:46, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
>> From: Jiangshan Yi <yijiangshan@kylinos.cn>
>
>Then why is this being sent from a 163.com address?
>

>What is wrong with using your real mail server?


There is a problem with the company's mailbox, and sometimes I can't receive emails. So I temporarily use my personal mailbox to send patches, so that I can receive feedback from the community in a timely manner.


>> @@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
>>  	return res;
>>  }
>>  
>> -/* dont call R/W in this function, beucase SDIO interrupt have claim host */
>> +/* don't call R/W in this function, because SDIO interrupt have claim host */
>
>That is not a spelling fix, but rather a "punctuation" fix if you want
>to be picky :)


The patch does s/beucase/because/  and  s/dont/don't/.
Follow Documentation/process/coding-style.rst,something write like this:
---------------------------------------
Kernel developers like to be seen as literate. Do mind the spelling
of kernel messages to make a good impression. Do not use incorrect
contractions like ``dont``; use ``do not`` or ``don't`` instead. Make the
messages concise, clear, and unambiguous.
---------------------------------------
So does the comment.


>>  /* or deadlock will happen and cause special-systemserver-died in android */
>>  u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
>>  {
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> index 06e727ce9cc2..71800917d132 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> @@ -277,7 +277,7 @@ bool		bPseudoTest)
>>  	return bResult;
>>  }
>>  
>> -/*  11/16/2008 MH Write one byte to reald Efuse. */
>> +/*  11/16/2008 MH Write one byte to real Efuse. */
>
>The date should just be removed entirely, right?


You're right.


thanks,


Jiangshan Yi

  reply	other threads:[~2022-10-10  3:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09  6:56 Jiangshan Yi
2022-10-09 18:21 ` Greg KH
2022-10-10  3:07   ` Yi Jiangshan [this message]
2022-10-10  6:23     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=382427df.1d30.183bfdca4b0.Coremail.13667453960@163.com \
    --to=13667453960@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-bot@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=yijiangshan@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®