From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230E3C433E2 for ; Sat, 12 Sep 2020 18:43:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0F1E2184D for ; Sat, 12 Sep 2020 18:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725885AbgILSn4 (ORCPT ); Sat, 12 Sep 2020 14:43:56 -0400 Received: from smtprelay0026.hostedemail.com ([216.40.44.26]:47874 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725838AbgILSnw (ORCPT ); Sat, 12 Sep 2020 14:43:52 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 5B52F1803F9A8; Sat, 12 Sep 2020 18:43:51 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: shock79_1b09319270f9 X-Filterd-Recvd-Size: 1573 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Sat, 12 Sep 2020 18:43:50 +0000 (UTC) Message-ID: <38299e7c135de26dc7cf3fbe25d6a74e4632bbd9.camel@perches.com> Subject: Re: [PATCH 1/5] staging: rtl8723bs: refactor cckrates{only}_included From: Joe Perches To: Michael Straube , gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 12 Sep 2020 11:43:49 -0700 In-Reply-To: References: <20200912084520.8383-1-straube.linux@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-09-12 at 11:22 -0700, Joe Perches wrote: > On Sat, 2020-09-12 at 10:45 +0200, Michael Straube wrote: > > Refactor cckrates_included() and cckratesonly_included() to simplify > > the code and improve readability. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c [] > bool cckratesonly_included(unsigned char *rate, int ratelen) > { [] > if (i <= 0) if (ratelen <= 0) of course... > return false; > > for (i = 0; i < ratelen; i++) { > if (!is_cckrate(rate[i]) > return false; > } > > return true; > } > >