From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5EF21EB2E for ; Sun, 5 Jan 2025 01:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736040232; cv=none; b=DWw0U1Ky4WSJk+rxsKDBTNSIMJdAzSqU1C8FRplknrrUu1qCdQymQytK8uyfbnE33jViHfwCxhmqLw48KoqDz10sS2gDKK5Due3XUfkIU6Qlxshi5+PJJQSitNGTw8eG3poqABry0BXyNAqgn7JRDWF2NPS/Jh1NZ8Tf68t6qAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736040232; c=relaxed/simple; bh=NgbM1kgICYJkniHR12jyNN34V8S31mdefZWKKrJmgP4=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=prt99gfG+rqgS82izuqKMZPrErKQCcaxpMLYPj0gBm62uGP4KJnBoLyvquHdlqSg6qT2smFWBAPAoSi2hrbZr6yJUNKIHx3kp3TaIMWjlwb4CT9A496dsQOroIPNpa/1NsQqf8SnTNpZFCxTK8ws7oPxOpDmNKP1O5lcFUBK/zI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=Q54T68i+; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="Q54T68i+" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-467a3f1e667so78273981cf.0 for ; Sat, 04 Jan 2025 17:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1736040229; x=1736645029; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=TxMgtgH324ptRSfJuMXT0SPkpytX5VIj9J4ESLVqwIA=; b=Q54T68i+BR9hERYTkJkXV7Ddt1XGGNI40LfbijMVzimIIUNDEfKZlLd2j9pekVUBJ+ pHUtY/yzjfXGLBD8OkFSk+/kcNzBYN3IjUix8lIZxKYEAzF2mxCGSOY6NH8Uvh34Ihvl YKjKguf74UkXJ1rNOMcF42Utpmx67WDJYEoQIRbtmarJbU+1zmCShIsVqKzKaj82u/D6 QCw7VmWi2yuZ9RmrlaT65VKTJk6huztgHkAXZrbZmfl1Scj8ozO2SaRrL9Wzpms3GrhB Oc0zpjdqQUMlEZz02PtAMlaGUnrsldMXMzr3dyS1wRuE+cA7Ukn+bqNL3JrahGRPVKoI 6KsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736040229; x=1736645029; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TxMgtgH324ptRSfJuMXT0SPkpytX5VIj9J4ESLVqwIA=; b=DAd0pv4/LVSQdGaE8KfmP8Rcxm60XZQ1w4NHjdhfEjbGK9dW8rU6wbypWY6FdkmBbm M8bs4iyJVfquFkVeUBDzDwtyNdjqiIcqW7heFBMRNJqTz9q9sXV62Ykn5uQy7rCMohLL XjzecfijWaE/wZVdH2QR2QR82iM+GyVLQhMI39jbrbGjh2mpkuYauncT/wxObr0G1mZN fNva2ri1oL3l50Sit3rhHOE2fKPIvvRKLqCDe++xXK7bmZREKrazKgB7uLYNTrZUn2zU jDE/uBciI2Blyw1k2P7hh0v6jbHswvFPwzyCCjeHQjf0UnWoF7dITqFlEsJg3+iUUZXS 5tpA== X-Forwarded-Encrypted: i=1; AJvYcCX+WXAFHZBMT2p1QJHtwaMUVDGIAE8e1QfTmiBy9stPxmr8RfmRSxqXkqQfEwV2q15r2xzB23V0g3INiiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7vhwu1PQ1+Zqz4Zjpu3RMjU6kR/YZaBPI8PKh1X5ISw527NIk Q7sOCsPDh28+46apBZZkcVf1eKOjUMdKL4x9Y7p38VWAtZNwr2WDbU8n0d9Dzg== X-Gm-Gg: ASbGncs5IXaJiimZ2Ws5hsKlQod/NA6Dy+ezocHqKUUS+fjUChd6xkClgo4fXBRyfBB 34CNVarwWI8ugdaXLNxpaTRyono+uJ7k0IGsMjw0nC4ausofYaG4p+2QPfh1gm0lQJjD8wstbmw XbedeEZ2xEetXO+nTO8ci5fOTkLwWG4uNGfgTVvRBYm8h2j9hpbo5YpZE1GJyLIiah3GY0XTYv1 cUG+kAoF3xjyxRhVNFOPOoh0LRqmo6I+/8mLy6ADMH/uoSGCag= X-Google-Smtp-Source: AGHT+IFdk+ZliRwQLXV7AXBiqpq1OufmuvXYdjN7bKWLAEyGOOimSW/Kxj7uTQosuVb0lCFRfFQeJQ== X-Received: by 2002:ac8:5dce:0:b0:466:8819:6fa5 with SMTP id d75a77b69052e-46a4a8ccab3mr868889231cf.15.1736040229571; Sat, 04 Jan 2025 17:23:49 -0800 (PST) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a6f8d1609sm127874061cf.64.2025.01.04.17.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 17:23:49 -0800 (PST) Date: Sat, 04 Jan 2025 20:23:48 -0500 Message-ID: <382de732ebaa88fe89e2c36b9216df57@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20250104_1133/pstg-lib:20250104_1133/pstg-pwork:20250104_1133 From: Paul Moore To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Eric Paris , =?UTF-8?q?G=C3=BCnther=20Noack?= , "Serge E . Hallyn" Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Ben Scarlato , Casey Schaufler , Charles Zaffery , Francis Laniel , James Morris , Jann Horn , Jeff Xu , Jorge Lucangeli Obes , Kees Cook , Konstantin Meskhidze , Matt Bobrowski , Mikhail Ivanov , Phil Sutter , Praveen K Paladugu , Robert Salvet , Shervin Oloumi , Song Liu , Tahera Fahimi , audit@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v3 2/23] lsm: Add audit_log_lsm_data() helper References: <20241122143353.59367-3-mic@digikod.net> In-Reply-To: <20241122143353.59367-3-mic@digikod.net> On Nov 22, 2024 =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= wrote: > > Extract code from dump_common_audit_data() into the audit_log_lsm_data() > helper. This helps reuse common LSM audit data while not abusing > AUDIT_AVC records because of the common_lsm_audit() helper. > > Cc: Casey Schaufler > Cc: James Morris > Cc: Paul Moore > Cc: Serge E. Hallyn > Signed-off-by: Mickaël Salaün > Link: https://lore.kernel.org/r/20241122143353.59367-3-mic@digikod.net > --- > Changes since v1: > - Fix commit message (spotted by Paul). > - Constify dump_common_audit_data()'s and audit_log_lsm_data()'s "a" > argument. > - Fix build without CONFIG_NET: see previous patch. > --- > include/linux/lsm_audit.h | 8 ++++++++ > security/lsm_audit.c | 27 ++++++++++++++++++--------- > 2 files changed, 26 insertions(+), 9 deletions(-) Acked-by: Paul Moore -- paul-moore.com