From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DEEBC001E0 for ; Fri, 28 Jul 2023 04:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbjG1EJU (ORCPT ); Fri, 28 Jul 2023 00:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233167AbjG1EJJ (ORCPT ); Fri, 28 Jul 2023 00:09:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259861BD5; Thu, 27 Jul 2023 21:09:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6B8E61FB5; Fri, 28 Jul 2023 04:09:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CE1DC433C7; Fri, 28 Jul 2023 04:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690517348; bh=uw0Xjt7/KMv5o/4UdrtIWciAkDGApwQ+7UzCn1CqA5g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p3Is/j119bril0PDN0qA5OJEw2nmlR2e+RcyQzjSfZz917JGE3cDUmeF3FHX10L/k rYD4MYnNeeXGNhnc0NM8Owv1582AZb9EH/dEINcR6bj6NIX4lT6CVrYXUfdmlYsPgR wG28HMtn7SzjrCq/X4SLXzPK1UbhRYIagygvJKbZ3Zto2kmFUoqaxJXA33ybhYpcW0 CfSUXLsOADa1AzFrfbHJIkaEFC1pbsQPwTm6AVwHC2mO6Fd2jkzTrcwYrLWzRoNEEL VQLVtRGSaYW4n9rBt4UYyTgIXy5KvPRTd/Xp92/2y6QlI2iZ8OHzqTVfn6DcUu48dv Abb6SykABXp/g== Message-ID: <3836423e-8f0f-1278-38e5-d35fbd7298e4@kernel.org> Date: Fri, 28 Jul 2023 13:09:06 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: Scsi_bus_resume+0x0/0x90 returns -5 when resuming from s3 sleep Content-Language: en-US To: TW , Thorsten Leemhuis Cc: regressions@lists.linux.dev, Mario Limonciello , Bart Van Assche , LKML , stable@vger.kernel.org References: <0e272abe-292d-d58f-cf80-55868e793abc@gmail.com> <6b66dd9a-8bd5-2882-9168-8e6e0848c454@leemhuis.info> <86435987-734e-c6c1-a857-1ba80da709fe@gmail.com> <48bc1736-5e4e-3a9b-3715-60509c333bb1@kernel.org> <40365501-283a-408b-3514-48c29db36861@kernel.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/23 11:49, TW wrote: > Comparing to the 5.15 kernel which had almost no delay. They are HDDs > though, it was working flawlessly earlier but didn't want to top post > again. Tried a systemd suspend instead of from the Xfce4 logout menu and > everything works as intended. So I'd say that it's fixed now. I think that asynchronous scsi suspend/resume using the PM infrastructure, introduced in 5.16, is creating this additional delay. The reason is that now, ata and scsi drivers do their resume operations from within the PM resume process, resulting in some delays to reach "PM: suspend exit". I am looking into improving this, but it may take some more time. I will post officially the patch you tried and CC you. A "tested-by" tag from you would be appreciated. Thanks. > > On 7/27/23 20:33, Damien Le Moal wrote: >> "Slow coming back" -> Compared to which version of the kernel ? Do you >> have numbers ? If the devices are HDDs, resume will wait for these to >> spin up. That takes a while (about 10s normally). -- Damien Le Moal Western Digital Research