From: Arnd Bergmann <arnd@arndb.de>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: grant.likely@linaro.org, fengguang.wu@intel.com,
kbuild-all@01.org, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] m32r: Add missing big-endian I/O accessors
Date: Thu, 27 Nov 2014 22:48:56 +0100 [thread overview]
Message-ID: <3837177.boLNi8fnoI@wuerfel> (raw)
In-Reply-To: <1417112193-14400-2-git-send-email-cernekee@gmail.com>
On Thursday 27 November 2014 10:16:33 Kevin Cernekee wrote:
> m32r doesn't use GENERIC_IOMAP, and it doesn't currently implement e.g.
> ioread32be() on its own. Add definitions to <asm/io.h> to fix build
> failures in common drivers that use these functions.
>
> drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_out':
> >> drivers/tty/serial/8250/8250_core.c:434:2: error: implicit declaration of function 'iowrite32be' [-Werror=implicit-function-declaration]
> iowrite32be(value, p->membase + offset);
> ^
> drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_in':
> >> drivers/tty/serial/8250/8250_core.c:440:2: error: implicit declaration of function 'ioread32be' [-Werror=implicit-function-declaration]
> return ioread32be(p->membase + offset);
> ^
> cc1: some warnings being treated as errors
>
> Compile-tested only.
>
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
>
Both patches
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2014-11-27 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 18:16 [PATCH V2 1/2] m32r: Fix ioread8 definition Kevin Cernekee
2014-11-27 18:16 ` [PATCH V2 2/2] m32r: Add missing big-endian I/O accessors Kevin Cernekee
2014-11-27 21:48 ` Arnd Bergmann [this message]
2014-11-27 22:20 ` Fengguang Wu
2014-11-27 23:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3837177.boLNi8fnoI@wuerfel \
--to=arnd@arndb.de \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fengguang.wu@intel.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®