mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] xen/netback: cleanup init and deinit code
Date: Mon, 21 Oct 2019 07:30:17 +0200	[thread overview]
Message-ID: <383da9a4-862f-f199-76d6-124711095de4@suse.com> (raw)
In-Reply-To: <20191021052747.31543-1-jgross@suse.com>

On 21.10.19 07:27, Juergen Gross wrote:
> Do some cleanup of the netback init and deinit code:
> 
> - add an omnipotent queue deinit function usable from
>    xenvif_disconnect_data() and the error path of xenvif_connect_data()
> - only install the irq handlers after initializing all relevant items
>    (especially the kthreads related to the queue)
> - there is no need to use get_task_struct() after creating a kthread
>    and using put_task_struct() again after having stopped it.
> - use kthread_run() instead of kthread_create() to spare the call of
>    wake_up_process().
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Sorry, forgot to add the "Reviewed-by:" of Paul. Will resend.


Juergen

  reply	other threads:[~2019-10-21  5:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21  5:27 Juergen Gross
2019-10-21  5:30 ` Jürgen Groß [this message]
2019-10-21  5:30 Juergen Gross
2019-10-22 18:35 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=383da9a4-862f-f199-76d6-124711095de4@suse.com \
    --to=jgross@suse.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@xen.org \
    --cc=wei.liu@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®