From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760787AbbJ3T7u (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 15:59:50 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:52072 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1760665AbbJ3T7a (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 15:59:30 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Stuart Yoder <stuart.yoder@freescale.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Jose Rivera <German.Rivera@freescale.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sharma Bhupesh <bhupesh.sharma@freescale.com>,
        Li Leo <LeoLi@freescale.com>
Subject: Re: [PATCH v2] arm64: dts: Added syscon-reboot node for FSL's LS2085A SoC
Date: Fri, 30 Oct 2015 20:59:19 +0100
Message-ID: <3842856.zmPu9RX8Gg@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CY1PR0301MB07483E9D229314891961B6AD872F0@CY1PR0301MB0748.namprd03.prod.outlook.com>
References: <1446066584-3738-1-git-send-email-German.Rivera@freescale.com> <3919319.0f6zV1T7g0@wuerfel> <CY1PR0301MB07483E9D229314891961B6AD872F0@CY1PR0301MB0748.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:5fJjWZxAlpl8NMV08EOGk3Gou0hT8rRd8HvvzDcc7zYRnDYX/8C
 4xxvhqii/5uHxlBBb3L7fXGDatj6kVnil1tCv39II6U6qltfNtwMGeShv74ojqxzva0mUy6
 lAifakrp8hW9+1lqnBDuXHQTy1dI2Ym6eO/5RncL/g0IsVR3eu2qgJQ+G0RnJdosdqEhpdi
 KRppNPL51/01e3OGDjQUg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:i0qTBT4vf4k=:v5LfYeA71/Ps2sYt4/zBKA
 fWSwCXYULo4oRNI+CYbpvAKHh7J6oBQh4ELeSjENWPrqL1W95gwndyxeclWvveGQVDKSZV9q5
 ZgqCiYbMRkBwYkZK/mU4Mh+5o5js1k0IPPe9u/UQhm1u6kA6kgyFRnE8n8UJSeim+uZX9nLCq
 dtdxD4X6g8BlhdggO4n8EdpvkPpOEVMJ04pN2o2yxeVKsbK2AJwiPhIHqs4D8Ysy3aChQ8FiQ
 C7QT6PIVnbojD0eVzrb4cJ0G9EueAd3uPr0MMRzg/rg95QaIIzdlr+TG71iKtruu5RGwdpcWu
 NDgOVQ9/DkXa/uabgsbBmBl6vVuMOXGZPoA4xONmO1i93PAWxlY69DjkV530otxH3mKmnKiUC
 nVJIwpE+xQOz0c3cauuElo7UPSQ1DRBBFwqi4ktT7jEXI6DIao9B33akM4Ngl/fSHnN7MLqW5
 eVYtIHM0hStCCQIPtLPqGPpsrCbp8Z9D9sJ+8DLv2b0Zcz5jjKlpPBydg5EimcrqqNX5qtGee
 XqbKBdTHrv5S8Og+oK/TUoaity+2xB0cWZ0X79+Y6+cS9mCGbYwOTPDwxyiWWVroG9NH67Ldq
 Zth02Lemg1xbJgxo1ZLo+V/q9ujdbfs1qY8cTWkShcqlecNvl5kxOzdQf1aX1xisrHEhyihYr
 AogjKEk0a8GxPmfKjRMJCp/91UbVFtzdI3Oy7Kuh1hZC9uRVNc5AqEy6KzSXHwQNGoNViOFto
 Ao9SMaolS4IN0Ly4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 30 October 2015 16:34:26 Stuart Yoder wrote:
> My suggestion is to perhaps make that more explicit in the proposed
> device tree node, by making the reg size "4" and naming it
> as per the register name
> 
>        rstcr: rstcr@1E60000 {
>                compatible = "syscon";
>                reg = <0x0 0x1E60000 0x0 0x4>;
>        };
> 
> The intent is really just to expose a single reset register
> and use syscon-reboot until PSCI is available.

I would rather see a more specific compatible string here that describes
the actual name, e.g.

	compatible = "fsl,ls2085a-rstcr", "syscon";

this way we have the option of making it a real driver later on by matching
on the specific string, but using the fallback syscon string otherwise.

BTW, please change the address to lowercase letters in both the node name and
the reg property. I would also change the name to 'syscon' instead of 'rstcr',
making that

	rstcr: syscon@1e60000 {
		...
	};

	Arnd