From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 627A1C4CEC9 for ; Wed, 18 Sep 2019 18:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3691021920 for ; Wed, 18 Sep 2019 18:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387449AbfIRSFM (ORCPT ); Wed, 18 Sep 2019 14:05:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:59253 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfIRSFM (ORCPT ); Wed, 18 Sep 2019 14:05:12 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 11:05:11 -0700 X-IronPort-AV: E=Sophos;i="5.64,521,1559545200"; d="scan'208";a="338407459" Received: from ahduyck-desk1.jf.intel.com ([10.7.198.76]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 11:05:10 -0700 Message-ID: <38429bdb416bdb33f3c7f740f903380af3129a36.camel@linux.intel.com> Subject: Re: [PATCH v10 5/6] virtio-balloon: Pull page poisoning config out of free page hinting From: Alexander Duyck To: "Michael S. Tsirkin" , Alexander Duyck Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, david@redhat.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org, vbabka@suse.cz, akpm@linux-foundation.org, mgorman@techsingularity.net, linux-arm-kernel@lists.infradead.org, osalvador@suse.de, yang.zhang.wz@gmail.com, pagupta@redhat.com, konrad.wilk@oracle.com, nitesh@redhat.com, riel@surriel.com, lcapitulino@redhat.com, wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com Date: Wed, 18 Sep 2019 11:05:10 -0700 In-Reply-To: <20190918135833-mutt-send-email-mst@kernel.org> References: <20190918175109.23474.67039.stgit@localhost.localdomain> <20190918175305.23474.34783.stgit@localhost.localdomain> <20190918135833-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-09-18 at 13:58 -0400, Michael S. Tsirkin wrote: > On Wed, Sep 18, 2019 at 10:53:05AM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Currently the page poisoning setting wasn't being enabled unless free page > > hinting was enabled. However we will need the page poisoning tracking logic > > as well for unused page reporting. As such pull it out and make it a > > separate bit of config in the probe function. > > > > In addition we can actually wrap the code in a check for NO_SANITY. If we > > don't care what is actually in the page we can just default to 0 and leave > > it there. > > > > Reviewed-by: David Hildenbrand > > Signed-off-by: Alexander Duyck > > I think this one can go in directly. Do you want me to merge it now? That sounds good to me. Do you know if you can also pull in QEMU 1/3 into QEMU as well since the feature wasn't pulled into QEMU originally? https://lore.kernel.org/lkml/20190918175342.23606.12400.stgit@localhost.localdomain/ Thanks. - Alex