From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbdKINMy (ORCPT ); Thu, 9 Nov 2017 08:12:54 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:27309 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227AbdKINMv (ORCPT ); Thu, 9 Nov 2017 08:12:51 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171109131249epoutp0333e786784135f9f680a4be7e43ed66fc~1bRDxCY2C0369303693epoutp03j X-AuditID: b6c32a36-325ff70000001039-51-5a045450bf6a From: Bartlomiej Zolnierkiewicz To: Christophe JAILLET Cc: tj@kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/8] video: fbdev: au1200fb: Fix error handling path of 'au1200fb_drv_probe()' Date: Thu, 09 Nov 2017 14:12:46 +0100 Message-id: <3843760.j1Dl9T2ZgC@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWy7bCmrm5ACEuUwd9DFhZbD85ltbjy9T2b xdZb0hYn+j6wWlzeNYfN4tfyo4wObB6bVnWyedzvPs7k8XmTnMfnu+tZA1iiuGxSUnMyy1KL 9O0SuDKaVncwFhwVqpg8+zZbA+N9vi5GTg4JAROJl3/6WLoYuTiEBHYwSiz+38sMkhAS+M4o seZ1MUzRlBPLWSHiuxklVq21g2j4yiixY2EfE0iCTcBKYmL7KkYQW0TATGJu321mkCJmgUmM Ekc7j7KBJIQFUiRWfp8BtoFFQFXi5cEnYA28ApoSh1ecBtsgKuAlsWVfO9hQTgFHiQdLTrBC 1AhK/Jh8jwXEZhaQl9i3fyorhK0jcfbYOkaQZRICG9gkPj5ewQ5xtovEhLN9bBC2sMSr41uA 4hxAtrTEpaO2EOHpjBLbf0tA9G4G+mz3BKhea4nDxy9CLeCTePe1hxWil1eio00IosRDYvOu g1DjHSXuH2+GhtwURomm34wTGGVnITl7FpKzZyE5ewEj8ypGsdSC4tz01GLDAiO94sTc4tK8 dL3k/NxNjOBkoGW2g3HROZ9DjAIcjEo8vC9WMUcJsSaWFVfmHmKU4GBWEuEVeQsU4k1JrKxK LcqPLyrNSS0+xCjNwaIkziu6/lqEkEB6YklqdmpqQWoRTJaJg1OqgfEEL7OMUcO3Ip5HV19U /C79YMUVaTjJSKT3wt32VgUJ6Z0/1611fcl7RynK/o3D21i9f2uXMPB6Ojde3z9L79A7iQNz grLn1PqtDFx7qM+qYuE/3dC/O1cFe33/u97+EY+c0Mu68xV17LOb5z1LO8vGf6By4yXTrbda jjqXKofuCd/DE8q/I1mJpTgj0VCLuag4EQBP7DqaAgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t9jAd2AEJYog43zJS22HpzLanHl63s2 i623pC1O9H1gtbi8aw6bxa/lRxkd2Dw2repk87jffZzJ4/MmOY/Pd9ezBrBEcdmkpOZklqUW 6dslcGU0re5gLDgqVDF59m22Bsb7fF2MnBwSAiYSU04sZwWxhQR2MkrsfyvTxcgFZH9llHi1 YC8bSIJNwEpiYvsqRhBbRMBMYm7fbWaQImaBSYwSn352MIEkhAVSJFZ+n8EMYrMIqEq8PPgE rIFXQFPi8IrTYBtEBbwktuxrB6vnFHCUeLDkBCvEtmmMEstvrGeDaBCU+DH5HguIzSwgL7Fv /1RWCFtLYv3O40wTGPlnISmbhaRsFpKyBYzMqxglUwuKc9Nzi40KDPNSy/WKE3OLS/PS9ZLz czcxAkN422Gtvh2M95fEH2IU4GBU4uF1WMscJcSaWFZcmXuIUYKDWUmEV+QtUIg3JbGyKrUo P76oNCe1+BCjNAeLkjjv7bxjkUIC6YklqdmpqQWpRTBZJg5OqQZG8wNLGr+6rr25YN5aF615 Hl7SV9sKeC5LRJeuc18c631B2vFZww7zzWuuWt375FY/beUC6zMbHb/XL3BZttPqlatgrIui bHqxteOpB+vDNGzq/F2N4xnOvn5+zebk5oKL7ZuuFHcueiIkwFUxr74nNjzik3BMWv6ZbXrP D1xoOXHOdm3DTp/rSizFGYmGWsxFxYkADwLEj10CAAA= X-CMS-MailID: 20171109131248epcas1p3388d63e5ba21cac72bc65eaa3e5ce2d7 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171016190602epcas2p1c54546e982659187188f178846c54531 X-RootMTR: 20171016190602epcas2p1c54546e982659187188f178846c54531 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 16, 2017 09:04:46 PM Christophe JAILLET wrote: > This patch serie tries to fix several issues found in the error handling > code of 'au1200fb_drv_probe()'. > The 5 first patches fixes various issues (double free, missing error code, > un-released resources on error, incorrect IRQ releasing and incomplete > error handling path) > > The 3 last patches are just cleanups. > > > I've spilt the serie in 8 steps that look logical to me. They could > also be merged together if preferred. > > > These patches are provided as-is and ARE NOT even compile-tested (sorry in > advance if a patch is broken) because I don't have a cross compiler for MIPS > and won't install one. > > > This serie already goes further that the fixes I usually provide, so > please excuse me if I missed something or if it is somehow broken and/or > incomplete. > > --- > V1 previously posted is patch 3/8 of this serie > > Christophe JAILLET (8): > video: fbdev: au1200fb: Fix a potential double free > video: fbdev: au1200fb: Return an error code if a memory allocation > fails > video: fbdev: au1200fb: Release some resources if a memory allocation > fails > video: fbdev: au1200fb: Fix error handling path > video: fbdev: au1200fb: Fix error handling path > video: fbdev: au1200fb: Remove some dead code > video: fbdev: au1200fb: Propagate an error code > video: fbdev: au1200fb: Style clean up > > drivers/video/fbdev/au1200fb.c | 43 ++++++++++++++++++++++-------------------- > 1 file changed, 23 insertions(+), 20 deletions(-) Thanks, I queued all patches for 4.15. I also did some minor fixes to the patch #4 while merging it: * patch summary was changed to "video: fbdev: au1200fb: Fix incorrect IRQ freeing") to be different from the patch summary of patch #5 * patch description was changed to silence issues reported by checkpatch.pl: WARNING: 'succesful' may be misspelled - perhaps 'successful'? #4: 'au1200fb_drv_probe()' can not fail after a succesful call to ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 1630d85a8312 ("au1200fb: fix hardcoded IRQ")' #9: 1630d85a8312 ("au1200fb: fix hardcoded IRQ") Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics