From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784AbdJ3Jnz (ORCPT ); Mon, 30 Oct 2017 05:43:55 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:48154 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752540AbdJ3Jny (ORCPT ); Mon, 30 Oct 2017 05:43:54 -0400 Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: relax EIO injection for quota file To: Jaegeuk Kim CC: Chao Yu , , , References: <20171019165617.79128-1-jaegeuk@kernel.org> <20171019165617.79128-2-jaegeuk@kernel.org> <20171022165109.GA33676@jaegeuk-macbookpro.roam.corp.google.com> <369986d8-18f2-85b6-28cd-64dffea2f7a7@huawei.com> <20171030092114.GA26880@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <384897c7-111b-99cc-d99d-989fafaa6330@huawei.com> Date: Mon, 30 Oct 2017 17:43:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171030092114.GA26880@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/30 17:21, Jaegeuk Kim wrote: > On 10/28, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/10/23 0:51, Jaegeuk Kim wrote: >>> On 10/22, Chao Yu wrote: >>>> On 2017/10/20 0:56, Jaegeuk Kim wrote: >>>>> This case is not happening easily. >>>> >>>> Actually it can happen, so why not just keep it? >>> >>> Okay, so let me keep this patch for local stress tests only. >> >> May I ask which type and rate of fault injection you are using for >> test now? > > I select random value between 3000 and 5000, and 255 for type. Got it, thanks for your sharing. :) Thanks, > > Thanks, > >> >> Thanks, >> >>> >>> Thanks, >>> >>> >>>> >>>> Thanks, >>>> >>>>> >>>>> Signed-off-by: Jaegeuk Kim >>>>> --- >>>>> fs/f2fs/f2fs.h | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>>>> index e0ef31cb2cc6..6301ccca8888 100644 >>>>> --- a/fs/f2fs/f2fs.h >>>>> +++ b/fs/f2fs/f2fs.h >>>>> @@ -1544,7 +1544,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi, >>>>> return ret; >>>>> >>>>> #ifdef CONFIG_F2FS_FAULT_INJECTION >>>>> - if (time_to_inject(sbi, FAULT_BLOCK)) { >>>>> + if (!IS_NOQUOTA(inode) && time_to_inject(sbi, FAULT_BLOCK)) { >>>>> f2fs_show_injection_info(FAULT_BLOCK); >>>>> release = *count; >>>>> goto enospc; >>>>> >>> >>> . >>> > > . >