From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754905AbdERCEV (ORCPT ); Wed, 17 May 2017 22:04:21 -0400 Received: from mail.crc.id.au ([203.56.246.92]:51106 "EHLO mail.crc.id.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754109AbdERCER (ORCPT ); Wed, 17 May 2017 22:04:17 -0400 X-Greylist: delayed 538 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 May 2017 22:04:17 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 May 2017 11:55:14 +1000 From: Steven Haigh To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com Subject: Re: [PATCH 0/3] xen/blkback: several fixes of resource management In-Reply-To: <20170516062320.22008-1-jgross@suse.com> References: <20170516062320.22008-1-jgross@suse.com> Message-ID: <384b0102e3a0c612b14838154aa7fb9c@crc.id.au> User-Agent: Roundcube Webmail/1.4-git Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-16 16:23, Juergen Gross wrote: > Destroying a Xen guest domain while it was doing I/Os via xen-blkback > leaked several resources, including references of the guest's memory > pages. > > This patch series addresses those leaks by correcting usage of > reference counts and the sequence when to free which resource. > > The series applies on top of commit 2d4456c73a487abe ("block: > xen-blkback: add null check to avoid null pointer dereference") in > Jens Axboe's tree kernel/git/axboe/linux-block.git > > Juergen Gross (3): > xen/blkback: fix disconnect while I/Os in flight > xen/blkback: don't free be structure too early > xen/blkback: don't use xen_blkif_get() in xen-blkback kthread > > drivers/block/xen-blkback/blkback.c | 3 --- > drivers/block/xen-blkback/common.h | 1 + > drivers/block/xen-blkback/xenbus.c | 15 ++++++++------- > 3 files changed, 9 insertions(+), 10 deletions(-) Tested-by: Steven Haigh I've had a report that a new message is logged on destroy sometimes: vif vif-1-0 vif1.0: Guest Rx stalled This may be a different issue - however the main fix of this patch set is fully functional. -- Steven Haigh Email: netwiz@crc.id.au Web: https://www.crc.id.au Phone: (03) 9001 6090 - 0412 935 897