From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>, <jacek.anaszewski@gmail.com>,
<linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: leds: lm3642: remove warnings for bad strtol, cleanup gotos
Date: Fri, 3 Jan 2020 09:49:16 -0600 [thread overview]
Message-ID: <384b876c-2043-1a48-28fc-ac7d2a1facb0@ti.com> (raw)
In-Reply-To: <20200102214547.GA3616@amd>
Pavel
On 1/2/20 3:45 PM, Pavel Machek wrote:
> Hi!
>
> I've applied this to for-next tree. If you see something very wrong,
> let me know.
Nothing wrong with this patch but in reviewing I did notice in the
lm3642_control in the switch case that we set the opmode regardless of
regmap_update_bits passing or failing.
FWIW
Reviewed-by: Dan Murphy <dmurphy@ti.com>
Dan
prev parent reply other threads:[~2020-01-03 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 21:45 Pavel Machek
2020-01-03 15:49 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384b876c-2043-1a48-28fc-ac7d2a1facb0@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®