From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: msm: Add binding for MSM8996 DPU
Date: Sat, 30 Apr 2022 23:54:45 +0300 [thread overview]
Message-ID: <384e2336-e6a3-28d6-4572-1534d418206b@linaro.org> (raw)
In-Reply-To: <7e066b7f-943a-6a5e-7383-a05794d207dc@linaro.org>
On 30/04/2022 22:33, Dmitry Baryshkov wrote:
> On 30/04/2022 19:15, Konrad Dybcio wrote:
>> Add yaml binding for MSM8996 DPU.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>> ---
>> .../bindings/display/msm/dpu-msm8996.yaml | 221 ++++++++++++++++++
>> 1 file changed, 221 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dpu-msm8996.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/msm/dpu-msm8996.yaml
>> b/Documentation/devicetree/bindings/display/msm/dpu-msm8996.yaml
>> new file mode 100644
>> index 000000000000..10b02423224d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8996.yaml
>> @@ -0,0 +1,221 @@
>> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dpu-msm8996.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DPU dt properties for MSM8996 target
>> +
>> +maintainers:
>> + - Konrad Dybcio <konrad.dybcio@somainline.org>
>> +
>> +description: |
>> + Device tree bindings for MSM Mobile Display Subsystem (MDSS) that
>> + encapsulates sub-blocks like DPU display controller, DSI
>> interfaces, etc.
>> + Device tree bindings of MDSS and DPU are mentioned for MSM8996 target.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: qcom,msm8996-mdss
>
> With the unified MDSS driver there is no need to describe a separate
> mdss bindings. Let's skip this part for now.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + reg-names:
>> + const: mdss
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + clocks:
>> + items:
>> + - description: Display AHB clock
>> + - description: Display core clock
>> +
>> + clock-names:
>> + items:
>> + - const: iface
>> + - const: core
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + interrupt-controller: true
>> +
>> + "#address-cells": true
>> +
>> + "#size-cells": true
>> +
>> + "#interrupt-cells":
>> + const: 1
>> +
>> + iommus:
>> + items:
>> + - description: Phandle to mdp_smmu node with SID mask for
>> Hard-Fail port0
>> +
>> + ranges: true
>> +
>> +patternProperties:
>> + "^display-controller@[0-9a-f]+$":
>> + type: object
>> + description: Node containing the properties of DPU.
>> +
>> + properties:
>> + compatible:
>> + items:
>> + - const: qcom,msm8996-dpu
>
> Okay. So, this is the most interesting part. Unlike MSM8998, which is
> supported in the mdp5 driver, but was not used in the upstream DTS
> files, for the MSM8996 the MDP5 part is described, used and widely
> tested. And, unfortunately, the bindings use solely the generic
> "qcom,mdp5" compat.
>
> I would suggest the following plan:
> - Define a binding using both "qcom,msm8996-dpu" and "qcom,mdp5"
> strings. Make sure that it is fully backwards-compatible with older dts.
>
> - Update msm8996.dtsi to follow new binding.
>
> - Let's have a Kconfig flip switch selecting which driver to be used for
> 8996/8998.
Rob suggested a modparam here.
--
With best wishes
Dmitry
prev parent reply other threads:[~2022-04-30 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 16:15 Konrad Dybcio
2022-04-30 16:15 ` [PATCH 2/3] drm/msm/disp: dpu1: Add MSM8996 support Konrad Dybcio
2022-04-30 18:26 ` Dmitry Baryshkov
2022-04-30 20:41 ` Dmitry Baryshkov
2022-04-30 16:15 ` [PATCH 3/3] drm/msm/disp: dpu1: Properly sort qcm2290_dpu_caps Konrad Dybcio
2022-04-30 18:33 ` Dmitry Baryshkov
2022-04-30 19:33 ` [PATCH 1/3] dt-bindings: display: msm: Add binding for MSM8996 DPU Dmitry Baryshkov
2022-04-30 20:54 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384e2336-e6a3-28d6-4572-1534d418206b@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®