From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3A5035AC0F for ; Tue, 17 Mar 2026 09:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773738802; cv=none; b=O/TxEhL3YhNl6EiJRss2jhg6SHt4LsOjW4yndd/TUjZLv5wzOAiDtDKJstgOwh5Ic8GTYzpYEXOi8qIpFG5TPhPOw5PrF1a1OY5FMwkHYMA9LRIHOK8ZLlyKSo9Xxe6MWBmIoecSqxK+wqN38p/kwKStkRXj+Xx4+ynetbXC5qU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773738802; c=relaxed/simple; bh=49ZmSMBa3fIbsc2bRUAyFXHJMaHOr0WIFqlPhvq9Mrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lAPFD4k3w0WF+ZQuNh04ObJ67OdSc3ODFM8WVgkcx9GhBUIXN3TXtT3EmLz5d9V+KfggO9czW1wx/qr+zdCki3XOvMNEgEdD8LfSmgm52d7YSTAH6EnUGs+i8I4dEO475DelmXJlCfmzbhVcJlrOFeeEBi9+yNSTz5iIw7J1sWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fQ/FW/UU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N6tFopZu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fQ/FW/UU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N6tFopZu" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H1wqQG4022265 for ; Tue, 17 Mar 2026 09:13:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6K6SGvmy2neqF7oKqmqCg3YHYc88NEF8XYNqYOQhlac=; b=fQ/FW/UU5xsu0EbS 7t9QMiIdW4DVLUlV0QwaEQfDJQ4y4+DhqyILGSycKXBCmDDcwe4W8NbXedQRQNzF AFvMqLQlmvtatgjL5NORZjgvNAt+ctqBXJiNNBCOP60FNG2rWTsF10hP49rcthSJ SYBJdFs+6gjktlAzvLbCvK7sNP7hAiGEQoNYeN4S112xByo4aHTF+ejEnRf6/sBN 0xxiALkXyzZxr3R3Ya+5Spid2A1RR0TYq2DhoWpZLQZwES2gVwFafrZenTKPFcf4 w4NcoU7Y4PdH2GQM7Xtc1fIsAQaRQDIoagkr+vy+owmUgyKE1QA+Q8pOrvy4II8f bPCOlA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxn3fk1am-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:13:19 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd8dc8b434so445013085a.3 for ; Tue, 17 Mar 2026 02:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773738799; x=1774343599; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6K6SGvmy2neqF7oKqmqCg3YHYc88NEF8XYNqYOQhlac=; b=N6tFopZuGmtCtqLeHYHCrU1jNJqkuQUeKJODWTtUhtUHDCbiXtp281fQiSu4gIRKHB IiwoCV4XeENDm8eUEW23HT/IMdYZnhL22ZSEgYtTm3siCeZjl7gO9nWbpGuea8HDH+ki CVMfm8cEur2DrG+1y38fNgQb2yJLS+sI8gyc0/NjbMq7hPRiQvn45njvHmZSrdatXyyq +4OZQvLteOfipZ6pR3bi7r6Rw87XpnPyG3AABNnUXJAuDTNn04Wf8gxtm4MKyxuHTDSz 7SK7zibM4O5dug0z3gbVSeDj1o61UydLRWv76pLabEsjAUVMHBwYDWjXOiyav1lhnT+K B+nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773738799; x=1774343599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6K6SGvmy2neqF7oKqmqCg3YHYc88NEF8XYNqYOQhlac=; b=HQYvPz9NkG0kHBtaC/Ou2bYLS79ZQK5IzK2ZzLi5SGA5Mc2NgR/K3Hfoo7iXno7Rp2 EDLueo9Th8lXK4QBmUNmkarvx8NAGl9ZbxQBUbgDBYl26IT0Ink2xlhFkTttBxBbNtfV 5rWqiLcp5X5Fc+Ql1nQ8Lp3Yb8/C6/q7IihgNMuGDl67MKG2GU5Pnnrc1F6La1vqoNeB RbqP7IHE/KmDhgX/kaGZxZN8mdVaUGUr3B0A9WygaiPJGqqtV6aqABXcrd5zZsk4TA9+ Lx5NK0YT52WI7TfeBRZbrGP7IqIeBX2FppB008cOA2SyI3aOIHqQYtw6CMJuNj/hSOYY A28A== X-Forwarded-Encrypted: i=1; AJvYcCXZjHAvxIuEpEr0miIuq+7W9dRsCJm1hC7TWezjl3uf3G7gOB3qcyYLYTEgilFNYbo38YzhIhGbUvMe8EY=@vger.kernel.org X-Gm-Message-State: AOJu0YzRpvVYVDnfkVE5vqQgH9fvwJGdaEbYHolwA2gXHDti8NooTFRv +VoqmyHiFb3XbZ5tmDFoyqED8NDF+r132rD9RFQk1OdJWjpzLHbhNYrqVdI5Pur9pDoabXrzgqY wsL7Ks+JgiewoHzfo4RywvHLf5T6golBKdMc1Q1u0uzVUHNGKASaJ6Z3ekJCsTL9ap+o= X-Gm-Gg: ATEYQzwpx9KASaKXSU8E+t9XnqgY6+Jzw+3zYdyRgbWByYoa7yrz116hVMgs4A/A3Mt ZyKO42/qYaY4zZe0fswG/oOFsB0Tpi4PBjx+n84uYNlAhXuynEFH0I3vt7oJvZt8xEk6CsZ+zEn o+OcedqnrjZQ0McR9tp4ZssLjbT8dOVxy6omrXPrqJD2rtlCmXTb98fd6MPIaOt2UrbRXjMPM5C 7g0tiVXn8uvr2112h9bW9maPnMWuTIsRFbz5cI4CdsjH4j1i6M8q+QgnM0zmsyCNU787mOWUgo2 DiQfeImrhJ8MQRuFa4mIk6kMZJFyhQhd/s6r8mks36b/m82WyKycLZdChGMhQnobdeq6IxKRATL qeuO3diPXm2p2eynBSlQhmbPEkx2vy0UYjhXfGL9b2diD+WeEXdxkbA8j0z5605D11K8NYjZ3s3 l7rjU= X-Received: by 2002:a05:620a:bc4:b0:8cd:8751:2b19 with SMTP id af79cd13be357-8cdb5b8cb21mr1682552785a.7.1773738799299; Tue, 17 Mar 2026 02:13:19 -0700 (PDT) X-Received: by 2002:a05:620a:bc4:b0:8cd:8751:2b19 with SMTP id af79cd13be357-8cdb5b8cb21mr1682549685a.7.1773738798737; Tue, 17 Mar 2026 02:13:18 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97baaf7a51sm326081966b.40.2026.03.17.02.13.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 02:13:17 -0700 (PDT) Message-ID: <384e46f3-140c-4b88-a3c8-6cbb57ecff99@oss.qualcomm.com> Date: Tue, 17 Mar 2026 10:13:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mailbox: qcom-ipcc: amend qcom_ipcc_irq_fn() to report errors To: Gabriele Paoloni , mani@kernel.org, jassisinghbrar@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mpapini@redhat.com, dnita@qti.qualcomm.com, rballati@qti.qualcomm.com, bijothom@qti.qualcomm.com, wchadwic@redhat.com References: <20260316102618.7953-1-gpaoloni@redhat.com> <20260316102618.7953-3-gpaoloni@redhat.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260316102618.7953-3-gpaoloni@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=C5bkCAP+ c=1 sm=1 tr=0 ts=69b91b2f cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=20KFwNOVAAAA:8 a=7xeWrTpDXsmdGRf-d0wA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: YXcpWcDh78GIM_SOU79u_7S3CtyiHF_M X-Proofpoint-ORIG-GUID: YXcpWcDh78GIM_SOU79u_7S3CtyiHF_M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MCBTYWx0ZWRfX6jv1ZpB/Q7Ha j9kMjKephnWh+CxRQSuX/wSdDwedZQyDwCiVuiHqzHrCRPLtGeUTG9ncjoNytil/tO6dbLNQ3Zd Fd9/yyo8j7BLfLqRQZfgXXoxO/toBxsTvlkC7Cy0n+IgaK/ScTkfayqO1/bISVTG82CSyN/iSW9 89xW4eec8YSgz3CQaMhwopr1/FmDs4qIwBoyu1ZEVi5708bvC33BWwiOmF3ustCmI7Ruysm7ozs hsX2rj/cYujR1Ls+TcGfKlT6n5qAhLzT3p7ECAxcdvPYaUy1rCproaJpDzCqwDZNJvy7BpowoDH 76O904wJ3q6YV5Rq+I20Z+YnKNc9Pzl+gYrR2lv04yT625Q290mFNXgRIGdgl+wXL/h7C4yIMvZ h3ILlVWkzHXTb7Z+wlBT14qV4B6HUxglLEO4vcAoFXbLECp50ZVXtelNCjMFhuzaKyizYtchzSk LFB1w+49LjUQPoA9V2w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170080 On 3/16/26 11:26 AM, Gabriele Paoloni wrote: > check the virq value returned by irq_find_mapping(), also > check the return value of generic_handle_irq(); return IRQ_NONE > if either of the checks fails. > > Signed-off-by: Gabriele Paoloni > --- It certainly seems useful to inspect a function's return value, however I noticed that out of 47 in-tree callers of generic_handle_irq() within drivers/, only one other driver (intel_lpe_audio within drm/i915) checks that.. Similarly, many other drivers never check if irq_find_mapping() actually succeeded. This makes me wonder how you discovered there's an issue in the first place. Could you please add some details in the commit message? Konrad