From: Mark Brown <broonie@kernel.org>
To: Waqar Hameed <waqar.hameed@axis.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH] regmap: Add debugfs file for forcing field writes
Date: Tue, 13 Jun 2023 12:06:03 +0100 [thread overview]
Message-ID: <384ff7cd-4042-4e6e-89e6-356e9b37aee4@sirena.org.uk> (raw)
In-Reply-To: <pnd5y7rabll.fsf@axis.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Tue, Jun 13, 2023 at 12:24:28PM +0200, Waqar Hameed wrote:
> On Mon, Jun 12, 2023 at 16:00 +0100 Mark Brown <broonie@kernel.org> wrote:
>
> > If we're going to do something like this which could interfere with
> > driver operation then it should be guarded like the write support is so
> > that people using it have to modify the kernel to get the feature, or at
> > the very least taint the kernel. This is less invasive but still might
> > cause issues if someone is relying on read/modify/write behaviour.
> I understand your point. Should we introduce a new macro like
> `REGMAP_ALLOW_WRITE_DEBUGFS` (which requires direct code modification to
> enable it) to guard this or introduce a new kernel configuration?
I'd add a macro.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-06-13 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:53 Waqar Hameed
2023-06-12 15:00 ` Mark Brown
2023-06-13 10:24 ` Waqar Hameed
2023-06-13 11:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384ff7cd-4042-4e6e-89e6-356e9b37aee4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®