From: Mario Limonciello <mario.limonciello@amd.com>
To: Lizhi Hou <lizhi.hou@amd.com>,
ogabbay@kernel.org, quic_jhugo@quicinc.com,
dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, min.ma@amd.com, max.zhen@amd.com,
sonal.santan@amd.com, king.tam@amd.com
Subject: Re: [PATCH V1 2/2] accel/amdxdna: Remove DRM_AMDXDNA_HWCTX_CONFIG_NUM
Date: Tue, 17 Dec 2024 11:08:32 -0600 [thread overview]
Message-ID: <3853dfa9-82cf-4d98-8997-5ea0e68ffa40@amd.com> (raw)
In-Reply-To: <20241217165446.2607585-2-lizhi.hou@amd.com>
On 12/17/2024 10:54, Lizhi Hou wrote:
> Defining a number of enum elements in uapi header is meaningless. It will
> not be used as expected and can potentially lead to incompatible issue
> between user space application and driver.
>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
It's a great point. Making this change now before the uAPI is stable
will allow you to add new changes later.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> include/uapi/drm/amdxdna_accel.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/drm/amdxdna_accel.h b/include/uapi/drm/amdxdna_accel.h
> index 92eff83fac1f..a706ead39082 100644
> --- a/include/uapi/drm/amdxdna_accel.h
> +++ b/include/uapi/drm/amdxdna_accel.h
> @@ -122,7 +122,6 @@ enum amdxdna_drm_config_hwctx_param {
> DRM_AMDXDNA_HWCTX_CONFIG_CU,
> DRM_AMDXDNA_HWCTX_ASSIGN_DBG_BUF,
> DRM_AMDXDNA_HWCTX_REMOVE_DBG_BUF,
> - DRM_AMDXDNA_HWCTX_CONFIG_NUM
> };
>
> /**
next prev parent reply other threads:[~2024-12-17 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 16:54 [PATCH V1 1/2] accel/amdxdna: Add zero check for pad in ioctl input structures Lizhi Hou
2024-12-17 16:54 ` [PATCH V1 2/2] accel/amdxdna: Remove DRM_AMDXDNA_HWCTX_CONFIG_NUM Lizhi Hou
2024-12-17 17:08 ` Mario Limonciello [this message]
2024-12-17 18:47 ` Mario Limonciello
2024-12-17 17:11 ` [PATCH V1 1/2] accel/amdxdna: Add zero check for pad in ioctl input structures Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3853dfa9-82cf-4d98-8997-5ea0e68ffa40@amd.com \
--to=mario.limonciello@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=king.tam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=max.zhen@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®