From: Aksh Garg <a-garg7@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
<geert+renesas@glider.be>, <bjorn.andersson@oss.qualcomm.com>,
<arnd@arndb.de>, <nm@ti.com>, <ebiggers@kernel.org>,
<michal.simek@amd.com>, <luca.weiss@fairphone.com>,
<sven@kernel.org>, <prabhakar.mahadev-lad.rj@bp.renesas.com>,
<kuninori.morimoto.gx@renesas.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <s-vadapalli@ti.com>,
<danishanwar@ti.com>
Subject: Re: [PATCH] arm64: defconfig: Enable the Keystone PCIe host and endpoint driver
Date: Mon, 23 Feb 2026 17:31:14 +0530 [thread overview]
Message-ID: <385fee0b-5cc5-4fca-a109-47c47ecae6d4@ti.com> (raw)
In-Reply-To: <a7784864-5f9d-4403-ad66-841682315049@oss.qualcomm.com>
On 23/02/26 16:55, Krzysztof Kozlowski wrote:
> On 23/02/2026 12:17, Aksh Garg wrote:
>>
>>
>> On 23/02/26 16:36, Krzysztof Kozlowski wrote:
>>> On 23/02/2026 11:46, Aksh Garg wrote:
>>>> Enable the PCIe Glue driver for Host and Endpoint mode of operation of
>>>> the Designware PCIe controller in the Texas Instruments AM65 SoC.
>>>>
>>>> Signed-off-by: Aksh Garg <a-garg7@ti.com>
>>>> ---
>>>> arch/arm64/configs/defconfig | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>
>>> Why are you sending two separate patches one after another?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> As both the patches does not depend on each other, can independently be
>> reviewed, and address different SoCs with different PCIe controllers, I
>> thought it would be better to send them as two separate patches.
>
> So twice more work for us? Why this cannot be one patch?
>
The only commonality between the patches is that they both enable PCIe
drivers. However, the patch for J721E PCIe driver only enables the
controller for EP mode, as Host mode is already present. On the other
hand, the patch for Keystone PCIe driver enables both Host and EP mode
of operation. Also as I mentioned, they belong to different SoCs with
different PCIe controllers, so I chose to keep them separate.
If I squash both the patches, the subject like: "Enable PCIe drivers for
TI SoCs" would be too generic, as TI would have more SoCs in the future.
Hence, the squashed patch with this subject might mislead in future.
If you insist me squashing the patches, then would the following subject
be acceptable: "Enable J721E and Keystone PCIe drivers" for the squashed
patch?
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-02-23 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 10:46 Aksh Garg
2026-02-23 10:59 ` Siddharth Vadapalli
2026-02-23 11:06 ` Krzysztof Kozlowski
2026-02-23 11:17 ` Aksh Garg
2026-02-23 11:25 ` Krzysztof Kozlowski
2026-02-23 12:01 ` Aksh Garg [this message]
2026-03-10 10:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=385fee0b-5cc5-4fca-a109-47c47ecae6d4@ti.com \
--to=a-garg7@ti.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=danishanwar@ti.com \
--cc=ebiggers@kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=michal.simek@amd.com \
--cc=nm@ti.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s-vadapalli@ti.com \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®