From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A09EE29BD91 for ; Mon, 19 Jan 2026 07:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768806004; cv=none; b=eVwWnUxNqoLbySL4lgQWYade2mbXIsA02GUesl9FwqULJITYLSkYyauW8Y1oT2/kzmo0zcr3jQ/pGMa5UPC0xD3psAmdFBKg2FfYffynszZ326K0SCyNvpCu0l6DtWLezi441TDLTWhEDpOgyAjo/e6K050ol0XeVbpwuEC1hsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768806004; c=relaxed/simple; bh=YvzjJHnbrMAmoE/TSVnhogdp44McXfMW4MzGac5horQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cZ1gjHP9V6Dra3V+l32uyJ0CyDw8zC5+eU9pbsWpin24VaEwx0RV7EdUJipWBsLSOYkwjW8XfXw1vEBdEczQjMRwQSTyFTFGCdyOhsRm6mCOTrHJ6adlQtTy/FywA7YrwyCK4EQ/8YcbRg4NgeGDHbM+/aV9fh0DQ/uLgzS8dCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jW70hutA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jW70hutA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E107C116C6; Mon, 19 Jan 2026 07:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768806004; bh=YvzjJHnbrMAmoE/TSVnhogdp44McXfMW4MzGac5horQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jW70hutAeyrClYX7yTEihU3wZwlmrM11rZw/9AoEEboc2kkVpGJvVTMrhZKKtOcUm DUCnHEAhqf8siCiZWjP9RtDK8zyLHJlOCyw6rPhkZJpky8G2VU7h9P5LsjbPHQUguU r1pKsVhyWev7xf7QjHEr2BIvlswoYc3kwuEw9bFmP6BXCYcF4ZmrlXbDU1Ow0ppqIU ZVVXGL5w0YJT4MgQfW0IBx2t/K+XFVHGymbu2gdqdoJjdodcQS2ryEkI+JC/76jQXW RjMqeqgEYwnBgRERK2odmIWsvNb9nKHAGq2ZvFJvcICCdMcmei1dBOLDFdt5BfERUz dqZae3CNawUww== Message-ID: <3860577c-2cef-4e10-9cc1-33246d261a8b@kernel.org> Date: Mon, 19 Jan 2026 08:00:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: fsl: qe: qe_ports_ic: Consolidate chained IRQ handler install/remove To: Chen Ni , qiang.zhao@nxp.com Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260119055715.889001-1-nichen@iscas.ac.cn> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260119055715.889001-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 19/01/2026 à 06:57, Chen Ni a écrit : > [Vous ne recevez pas souvent de courriers de nichen@iscas.ac.cn. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > The driver currently sets the handler data and the chained handler in > two separate steps. This creates a theoretical race window where an > interrupt could fire after the handler is set but before the data is > assigned, leading to a NULL pointer dereference. I don't understand what you mean, how can this happen ? irq_set_handler_data() is called _before_ irq_set_chained_handler(), so how could an interrupt fire _before_ the data is assigned ? > > Replace the two calls with irq_set_chained_handler_and_data() to set > both the handler and its data atomically under the irq_desc->lock. > > Signed-off-by: Chen Ni > --- > drivers/soc/fsl/qe/qe_ports_ic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qe_ports_ic.c b/drivers/soc/fsl/qe/qe_ports_ic.c > index 61dd09fec6f6..8e2107e2cde5 100644 > --- a/drivers/soc/fsl/qe/qe_ports_ic.c > +++ b/drivers/soc/fsl/qe/qe_ports_ic.c > @@ -114,8 +114,7 @@ static int qepic_probe(struct platform_device *pdev) > if (!data->host) > return -ENODEV; > > - irq_set_handler_data(irq, data); > - irq_set_chained_handler(irq, qepic_cascade); > + irq_set_chained_handler_and_data(irq, qepic_cascade, data); > > return 0; > } > -- > 2.25.1 >