mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bryan Wu" <cooloney.lkml@gmail.com>
To: "Len Brown" <lenb@kernel.org>
Cc: linux-pm@lists.linux-foundation.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Pavel Machek" <pavel@suse.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	"Len Brown" <len.brown@intel.com>
Subject: Re: [PATCH 23/37] Suspend: Clean up Kconfig (V2)
Date: Fri, 1 Feb 2008 17:05:55 +0800	[thread overview]
Message-ID: <386072610802010105w78a6a558rbd17bd516e912f4c@mail.gmail.com> (raw)
In-Reply-To: <9a72d19a83ff28dd65eae54e210a9141ad993e88.1201840183.git.len.brown@intel.com>

On Feb 1, 2008 12:36 PM, Len Brown <lenb@kernel.org> wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
>
> This cleans up the suspend Kconfig and removes the need to
> declare centrally which architectures support suspend. All
> architectures that currently support suspend are modified
> accordingly.
>

Thanks, OK for Blackfin

Acked-by: Bryan Wu <bryan.wu@analog.com>

> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Acked-by: Russell King <rmk@arm.linux.org.uk>
> Acked-by: Paul Mackerras <paulus@samba.org>
> Acked-by: Ralf Baechle <ralf@linux-mips.org>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Pavel Machek <pavel@suse.cz>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>  arch/arm/Kconfig      |    3 +++
>  arch/blackfin/Kconfig |    4 ++++
>  arch/frv/Kconfig      |    5 +++++
>  arch/mips/Kconfig     |    4 ++++
>  arch/powerpc/Kconfig  |    4 ++++
>  arch/sh/Kconfig       |    4 ++++
>  arch/x86/Kconfig      |    4 ++++
>  kernel/power/Kconfig  |   21 +++------------------
>  8 files changed, 31 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 77201d3..a00d8b9 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1035,6 +1035,9 @@ menu "Power management options"
>
>  source "kernel/power/Kconfig"
>
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +
>  endmenu
>
>  source "net/Kconfig"
> diff --git a/arch/blackfin/Kconfig b/arch/blackfin/Kconfig
> index fc7ca86..4802eb7 100644
> --- a/arch/blackfin/Kconfig
> +++ b/arch/blackfin/Kconfig
> @@ -898,6 +898,10 @@ endmenu
>  menu "Power management options"
>  source "kernel/power/Kconfig"
>
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +       depends on !SMP
> +
>  choice
>         prompt "Select PM Wakeup Event Source"
>         default PM_WAKEUP_GPIO_BY_SIC_IWR
> diff --git a/arch/frv/Kconfig b/arch/frv/Kconfig
> index 43153e7..2e25b95 100644
> --- a/arch/frv/Kconfig
> +++ b/arch/frv/Kconfig
> @@ -357,6 +357,11 @@ source "drivers/pcmcia/Kconfig"
>  #        should probably wait a while.
>
>  menu "Power management options"
> +
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +       depends on !SMP
> +
>  source kernel/power/Kconfig
>  endmenu
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 4fad0a3..e387f3a 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2086,6 +2086,10 @@ endmenu
>
>  menu "Power management options"
>
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +       depends on !SMP
> +
>  source "kernel/power/Kconfig"
>
>  endmenu
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 68f0cf7..824140d 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -166,6 +166,10 @@ config ARCH_HIBERNATION_POSSIBLE
>         depends on (PPC64 && HIBERNATE_64) || (PPC32 && HIBERNATE_32)
>         default y
>
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +       depends on ADB_PMU || PPC_EFIKA || PPC_LITE5200
> +
>  config PPC_DCR_NATIVE
>         bool
>         default n
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 1cd9c8f..b30c4c3 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -882,6 +882,10 @@ endmenu
>  menu "Power management options (EXPERIMENTAL)"
>  depends on EXPERIMENTAL && SYS_SUPPORTS_PM
>
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +       depends on !SMP
> +
>  source kernel/power/Kconfig
>
>  endmenu
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9c511dd..340e81a 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -113,6 +113,10 @@ config ARCH_HIBERNATION_POSSIBLE
>         def_bool y
>         depends on !SMP || !X86_VOYAGER
>
> +config ARCH_SUSPEND_POSSIBLE
> +       def_bool y
> +       depends on !X86_VOYAGER
> +
>  config ZONE_DMA32
>         bool
>         default X86_64
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index fd76d54..f8153fd 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -85,7 +85,7 @@ config PM_TRACE_RTC
>  config PM_SLEEP_SMP
>         bool
>         depends on SMP
> -       depends on SUSPEND_SMP_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> +       depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
>         depends on PM_SLEEP
>         select HOTPLUG_CPU
>         default y
> @@ -95,29 +95,14 @@ config PM_SLEEP
>         depends on SUSPEND || HIBERNATION
>         default y
>
> -config SUSPEND_UP_POSSIBLE
> -       bool
> -       depends on (X86 && !X86_VOYAGER) || PPC || ARM || BLACKFIN || MIPS \
> -                  || SUPERH || FRV
> -       depends on !SMP
> -       default y
> -
> -config SUSPEND_SMP_POSSIBLE
> -       bool
> -       depends on (X86 && !X86_VOYAGER) \
> -                  || (PPC && (PPC_PSERIES || PPC_PMAC)) || ARM
> -       depends on SMP
> -       default y
> -
>  config SUSPEND
>         bool "Suspend to RAM and standby"
> -       depends on PM
> -       depends on SUSPEND_UP_POSSIBLE || SUSPEND_SMP_POSSIBLE
> +       depends on PM && ARCH_SUSPEND_POSSIBLE
>         default y
>         ---help---
>           Allow the system to enter sleep states in which main memory is
>           powered and thus its contents are preserved, such as the
> -         suspend-to-RAM state (i.e. the ACPI S3 state).
> +         suspend-to-RAM state (e.g. the ACPI S3 state).
>
>  config HIBERNATION
>         bool "Hibernation (aka 'suspend to disk')"
> --
> 1.5.4.rc5.16.gc0279
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  reply	other threads:[~2008-02-01  9:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01  4:36 suspend patches for 2.6.25-rc0 Len Brown
2008-02-01  4:36 ` [PATCH 01/37] Hibernation: Introduce SNAPSHOT_GET_IMAGE_SIZE ioctl Len Brown
2008-02-01  4:36   ` [PATCH 02/37] Hibernation: Rework platform support ioctls (rev. 2) Len Brown
2008-02-01  4:36   ` [PATCH 03/37] Hibernation: Mark SNAPSHOT_SET_SWAP_FILE ioctl as deprecated " Len Brown
2008-02-01  4:36   ` [PATCH 04/37] Hibernation: Correct definitions of some ioctls " Len Brown
2008-02-01  4:36   ` [PATCH 05/37] Hibernation: Introduce exportable suspend ioctls header " Len Brown
2008-02-01  4:36   ` [PATCH 06/37] ACPI: Fix mismerge in acpi_hibernation_finish Len Brown
2008-02-01  4:36   ` [PATCH 07/37] Hibernation: Move function prototypes to header Len Brown
2008-02-01  4:36   ` [PATCH 08/37] Hibernation: Add PM_RESTORE_PREPARE and PM_POST_RESTORE notifiers (rev. 2) Len Brown
2008-02-01  4:36   ` [PATCH 09/37] Suspend: Testing facility " Len Brown
2008-02-01  4:36   ` [PATCH 10/37] suspend: build fix responding to 2.6.25 kset change Len Brown
2008-02-01  4:36   ` [PATCH 11/37] Hibernation: New testing facility (rev. 2) Len Brown
2008-02-01  4:36   ` [PATCH 12/37] PM: Suspend/hibernation debug documentation update " Len Brown
2008-02-01  4:36   ` [PATCH 13/37] PM: Make PM_TRACE more architecture independent Len Brown
2008-02-01  4:36   ` [PATCH 14/37] PM: Convert PM notifiers to out-of-line code Len Brown
2008-02-01  4:36   ` [PATCH 15/37] Suspend: Fix compilation warning for CONFIG_SUSPEND unset Len Brown
2008-02-01  4:36   ` [PATCH 16/37] Hibernation: Move low level resume to disk.c Len Brown
2008-02-01  4:36   ` [PATCH 17/37] Suspend: Fix comment in main.c Len Brown
2008-02-01  4:36   ` [PATCH 18/37] Hibernation: Fix comment in disk.c Len Brown
2008-02-01  4:36   ` [PATCH 19/37] Hibernation: Remove unnecessary variable declaration Len Brown
2008-02-01  4:36   ` [PATCH 20/37] Suspend: Use common prefix in messages Len Brown
2008-02-01  4:36   ` [PATCH 21/37] Hibernation: Update messages Len Brown
2008-02-01  4:36   ` [PATCH 22/37] Hibernation: Clean up Kconfig (V2) Len Brown
2008-02-01  4:36   ` [PATCH 23/37] Suspend: " Len Brown
2008-02-01  9:05     ` Bryan Wu [this message]
2008-02-04 14:59     ` Pavel Machek
2008-02-01  4:36   ` [PATCH 24/37] ACPI: clear GPE earily in resume to avoid warning Len Brown
2008-02-01  4:36   ` [PATCH 25/37] suspend: fix ia64 allmodconfig build Len Brown
2008-02-01  4:36   ` [PATCH 26/37] Suspend: Introduce begin() and end() callbacks Len Brown
2008-02-01  4:36   ` [PATCH 27/37] ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK Len Brown
2008-02-01  4:36   ` [PATCH 28/37] ACPI: Separate disabling of GPEs from _PTS Len Brown
2008-02-01  4:37   ` [PATCH 29/37] ACPI suspend: Call _PTS before suspending devices Len Brown
2008-02-01  4:37   ` [PATCH 30/37] Hibernation: Introduce begin() and end() callbacks Len Brown
2008-02-01  4:37   ` [PATCH 31/37] ACPI hibernation: Call _PTS before suspending devices Len Brown
2008-02-01  4:37   ` [PATCH 32/37] ACPI: Print message before calling _PTS Len Brown
2008-02-01  4:37   ` [PATCH 33/37] Suspend: Add config option to disable the freezer if architecture wants that Len Brown
2008-02-01  4:37   ` [PATCH 34/37] Suspend: Clean up suspend_64.c Len Brown
2008-02-01  4:37   ` [PATCH 35/37] Suspend: Invoke suspend notifications after console switch Len Brown
2008-02-01  4:37   ` [PATCH 36/37] Hibernation: " Len Brown
2008-02-01  4:37   ` [PATCH 37/37] PM: Remove obsolete /sys/devices/.../power/state docs Len Brown
2008-02-01  5:48 ` [PATCH] feature-removal: Document suspend/hibernate deprecations Harvey Harrison
2008-02-01 10:54   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=386072610802010105w78a6a558rbd17bd516e912f4c@mail.gmail.com \
    --to=cooloney.lkml@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®