From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757259AbYELMMP (ORCPT ); Mon, 12 May 2008 08:12:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752114AbYELMMB (ORCPT ); Mon, 12 May 2008 08:12:01 -0400 Received: from yw-out-2324.google.com ([74.125.46.31]:10716 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbYELMMA (ORCPT ); Mon, 12 May 2008 08:12:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=bF05w8fWIDhgVhQ5qvmdve+63Sw7CIwQr5J7EEW2lMhX1H3ywGtB8owHpaZhVL5byC6Wfig+Aw2qe9ENuE+dHG8KNA5Se3VCyGwPtM9aD9rooo2w/+bjXc+A/P2uU8KUq/qBJsEGmburhP3FfFimsbMWbsA9+IupvPMnAknSlBw= Message-ID: <386072610805120511p5d1254cch26e2c8d5d0f755c7@mail.gmail.com> Date: Mon, 12 May 2008 20:11:49 +0800 From: "Bryan Wu" To: "Mike Frysinger" Subject: Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver Cc: "pHilipp Zabel" , dbrownell@users.sourceforge.net, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, "Michael Hennerich" In-Reply-To: <8bd0f97a0805120442j3875b58bwab3959fdb3de9db2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1210587437-9751-1-git-send-email-cooloney@kernel.org> <74d0deb30805120427x71b4588es9200f80252bab319@mail.gmail.com> <8bd0f97a0805120442j3875b58bwab3959fdb3de9db2@mail.gmail.com> X-Google-Sender-Auth: b6648085ab55f57f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 12, 2008 at 7:42 PM, Mike Frysinger wrote: > On Mon, May 12, 2008 at 7:27 AM, pHilipp Zabel wrote: > > On Mon, May 12, 2008 at 12:17 PM, Bryan Wu wrote: > >> From: Michael Hennerich > >> > >> It's an actual deficiency in the hardware that we can't address, > >> so it needs to be worked around in software. > >> > >> Signed-off-by: Michael Hennerich > >> Signed-off-by: Bryan Wu > >> --- > >> drivers/input/keyboard/gpio_keys.c | 15 ++++++++++++++- > >> 1 files changed, 14 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/input/keyboard/gpio_keys.c > b/drivers/input/keyboard/gpio_keys.c > >> index bbd00c3..d856eb9 100644 > >> --- a/drivers/input/keyboard/gpio_keys.c > >> +++ b/drivers/input/keyboard/gpio_keys.c > >> @@ -26,6 +26,18 @@ > >> > >> #include > >> > >> +#if defined(CONFIG_BLACKFIN) && !defined(BF548_FAMILY) > >> + > >> +/* > >> + * On some Blackfin CPUs reading edge triggered > >> + * GPIOs doesn't return the current value > >> + */ > > > > If this is a generic problem, shouldn't this be addressed inside gpio_get_value? > > it's an issue only when the GPIO is an interrupt source and the > trigger condition is set to both rising and falling. but i guess your > point is that in gpio_get_value(), we can check to see if these > conditions are met and if so, temporarily fiddle things there ? > > Michael: that sounds reasonable, what do you think ? > -mike > IMO, maybe it is feasible for fix this in generic GPIO layer, or will break other things? -Bryan