mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bryan Wu" <cooloney@kernel.org>
To: "Bryan Wu" <cooloney@kernel.org>,
	perex@perex.cz, lrg@kernel.org,
	"Cliff Cai" <cliff.cai@analog.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C
Date: Thu, 28 Aug 2008 11:46:24 +0800	[thread overview]
Message-ID: <386072610808272046u270c1302g1102bf1f0bd9b6ee@mail.gmail.com> (raw)
In-Reply-To: <20080827110143.GB10834@sirena.org.uk>

On Wed, Aug 27, 2008 at 7:01 PM, Mark Brown <broonie@sirena.org.uk> wrote:
> On Wed, Aug 27, 2008 at 05:39:27PM +0800, Bryan Wu wrote:
>
> This looks good, thanks but...
>
>> -#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
>> +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) && !defined (CONFIG_SND_SOC_WM8731_SPI)
>>       if (setup->i2c_address) {
>>               normal_i2c[0] = setup->i2c_address;
>>               codec->hw_write = (hw_write_t)i2c_master_send;
>> @@ -688,8 +745,14 @@ static int wm8731_probe(struct platform_device *pdev)
>>               if (ret != 0)
>>                       printk(KERN_ERR "can't add i2c driver");
>>       }
>> +#elif defined (CONFIG_SPI_MASTER) && defined (CONFIG_SND_SOC_WM8731_SPI)
>> +     codec->hw_write = (hw_write_t)wm8731_spi_write;
>> +     ret = spi_register_driver(&wm8731_spi_driver);
>> +     if (ret != 0)
>> +             printk(KERN_ERR "can't add spi driver");
>
> ...as for the SSM2602 it'd be good if it were possible to build a kernel
> which supports both I2C and SPI.  If you like I could do this for you -
> there's likely to be merge issues due to the update to the new I2C API
> anyway?
>

Oh, do you mean SSM2602 or WM8731? I also noticed the i2c API updates
patch from Jean and I'd like to use the new one

Thanks
-Bryan

  reply	other threads:[~2008-08-28  3:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  9:39 [PATCH 0/4] Blackfin supports for ALSA/ASOC Bryan Wu
2008-08-27  9:39 ` [PATCH 1/4] ASOC: Blackfin driver for ALSA SoC framework Bryan Wu
2008-08-27 13:48   ` Mark Brown
2008-09-03  4:09     ` Cai, Cliff
2008-09-03 10:38       ` Mark Brown
2008-09-04  3:54         ` [alsa-devel] " Cliff Cai
2008-08-27  9:39 ` [PATCH 2/4] ASOC codec: add support for SSM2602 audio codec in " Bryan Wu
2008-08-27 10:54   ` [alsa-devel] " Mark Brown
2008-08-28  5:55     ` Bryan Wu
2008-08-28 10:06       ` Mark Brown
2008-08-28 11:44         ` Jean Delvare
2008-08-27  9:39 ` [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C Bryan Wu
2008-08-27 11:01   ` [alsa-devel] " Mark Brown
2008-08-28  3:46     ` Bryan Wu [this message]
2008-08-28 10:14       ` Mark Brown
2008-08-28 12:47         ` Takashi Iwai
2008-08-28 13:01           ` Mark Brown
2008-09-01 13:52   ` Alan Horstmann
2008-09-01 14:00     ` Liam Girdwood
2008-09-01 14:02     ` Mark Brown
2008-08-27  9:39 ` [PATCH 4/4] ALSA: add dummy function to support shared mmap in nommu Blackfin arch Bryan Wu
2008-08-28 12:44   ` Takashi Iwai
2008-09-02  3:16     ` Cai, Cliff
2008-09-02  9:41       ` Takashi Iwai
2008-09-02  9:59         ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=386072610808272046u270c1302g1102bf1f0bd9b6ee@mail.gmail.com \
    --to=cooloney@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=cliff.cai@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®