From: Michal Bachraty <michal.bachraty@streamunlimited.com>
To: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"perex@perex.cz" <perex@perex.cz>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Girdwood, Liam" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ALSA: ASoC: McASP: Fix data rotation for playback. Enables 24bit audio playback
Date: Fri, 18 Jan 2013 09:43:40 +0100 [thread overview]
Message-ID: <3861763.aeE9tah8r0@ganymedes> (raw)
In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EB49910@DBDE01.ent.ti.com>
On Friday, January 18, 2013 08:22:53 Hebbar, Gururaja wrote:
> On Tue, Jan 15, 2013 at 20:11:00, Michal Bachraty wrote:
> > Signed-off-by: Michal Bachraty <michal.bachraty@streamunlimited.com>
>
> Even simple patches need a simple changelog.
> Add a brief description about what & why it is done?
>
Hi Gurujaja,
> > - u32 rotate = (32 - word_length) / 4;
This implementation is wrong, but it works only for 16, or 32 bit audio data.
(rotation for 16 or 32 bit is same as in code I present) Mcasp rotated data in
4 bits (max value 0x7)and then masks them . That data are sended to i2s bus.
For 24 bit or 20 bit or other data formats, this code rotates data badly and
you hear somethink like noise. You need to use
> > + u32 rotate = (word_length / 4) & 0x7;
to proper data rotation.
Regards,
Michal
next prev parent reply other threads:[~2013-01-18 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 14:41 Michal Bachraty
2013-01-18 8:22 ` [alsa-devel] " Hebbar, Gururaja
2013-01-18 8:43 ` Michal Bachraty [this message]
2013-01-18 8:48 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3861763.aeE9tah8r0@ganymedes \
--to=michal.bachraty@streamunlimited.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gururaja.hebbar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®