From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB5DB2F12C0 for ; Tue, 18 Nov 2025 20:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763496014; cv=none; b=iQB23vaoYBj91ybLWubJY9axUm1GoaK1F6zDsWwr1kTu4BLQjh2yyt4ZnwEZay7m1rBWUAm9Xp6zU/bs/fUDQv9yfs915HAqequVwa9ySvUXMTREm8zrhFDCnIUwt0A+IQQyLahDgmGg/9+JJ1uXzpunQTpnYhtBCHRUgVhYguE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763496014; c=relaxed/simple; bh=Ouz3sykA6NZWtw6Ox5elkRDV5HgOt7b0f0GP8Kov1EI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O7RP7F9oTYlg6Q+Yrj5V3nc3YeNf8pBqkG3AHa8B4/g/hNXPZhsNi5A3ee6cur/Se7D8sVfYlkzl+jHU5Q3kGWJ12SQKJ5cmxeIKiwW6z0viB/Hota/+AmAsPu5lGeMqwlYnfVBgn17sj6rEwm4x72AsF8AkAy3ct0ii2R7Wjy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=UTV8MhzG; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="UTV8MhzG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1763496009; bh=Ouz3sykA6NZWtw6Ox5elkRDV5HgOt7b0f0GP8Kov1EI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UTV8MhzGZCT6pEbkvadKMx88eRgkHh/BuJwjL7ViFkX8GYKo/Kklgll2xVBXkZlQF ZBDDmOe+RdQMe08+xVVPmYlsa3GF5Lw/PjdGBsKdTsYqoZJV/wQ9Zh0YMyPvEGzo7Y axSvCTEV+OYbBjghz5nybkVV2zcXM6sAxV4Umijn2BdAvXKVbgA3DCf2VDs3YT9YOT LYz8OowQRHgsRHjB2iaR0yuFmK+CgnHMkfF4uwNYt4ueo9cu20LqAY4W3Y9sm4j8EH Rwdm06n+iHYdq08roCIF3rHHZD3K+D9QZinZRYCgC5ADRTB0V3+J9sPvmlujWxP5QR HP+nOID4xnnpQ== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id C39BF17E0610; Tue, 18 Nov 2025 21:00:08 +0100 (CET) Message-ID: <3863e0e5-677b-4225-9854-3ee420828275@collabora.com> Date: Tue, 18 Nov 2025 22:00:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/10] drm/bridge: dw-hdmi-qp: Set bridge supported_formats To: Nicolas Frattaroli , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> <20251117-color-format-v4-5-0ded72bd1b00@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <20251117-color-format-v4-5-0ded72bd1b00@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Nicolas, On 11/17/25 9:11 PM, Nicolas Frattaroli wrote: > The drm_bridge "supported_formats" member stores a bitmask of supported > HDMI output formats if the bridge is in fact an HDMI bridge. > > However, until now, the synopsys dw-hdmi-qp driver did not set this > member in the bridge it creates. > > Set it based on the platform data's supported_formats member, and > default to BIT(HDMI_COLORSPACE_RGB) if it's absent, which preserves the > previous behaviour. > > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > index fe4c026280f0..cf888236bd65 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > @@ -1269,6 +1269,11 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev, > dev_warn(dev, "Set ref_clk_rate to vendor default\n"); > } > > + if (plat_data->supported_formats) > + hdmi->bridge.supported_formats = plat_data->supported_formats; This duplicates a change already introduced via commit 1ff27c5929ab ("drm/bridge: dw-hdmi-qp: Handle platform supported formats and color depth"). > + else > + hdmi->bridge.supported_formats = BIT(HDMI_COLORSPACE_RGB); And this one looks redundant as well, since RGB is supposed to be mandatory: supported_formats defaults to RGB in drm_bridge_connector_init() if there's no HDMI bridge in the pipeline overriding it, while drmm_connector_hdmi_init() errors out if supported_formats is unset or doesn't advertise RGB. Hence I think this patch can be dropped. Regards, Cristian