From: Joe Perches <joe@perches.com>
To: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>,
Casey Schaufler <casey@schaufler-ca.com>,
John Johansen <john.johansen@canonical.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
Kentaro Takeda <takedakn@nttdata.co.jp>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
selinux@tycho.nsa.gov
Subject: Re: [-next PATCH] security: use octal not symbolic permissions
Date: Wed, 13 Jun 2018 12:30:17 -0700 [thread overview]
Message-ID: <38670733fba157f7acd9c1555b44a296420f0774.camel@perches.com> (raw)
In-Reply-To: <CAHC9VhRXBx_Q2eM48FFqX9PbPz0k8R74gfFFoRhwV91n2_BPsQ@mail.gmail.com>
On Wed, 2018-06-13 at 12:19 -0400, Paul Moore wrote:
> On Wed, Jun 13, 2018 at 12:04 PM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2018-06-13 at 11:49 -0400, Paul Moore wrote:
> > > On Tue, Jun 12, 2018 at 8:29 PM, Joe Perches <joe@perches.com> wrote:
> > > > On Tue, 2018-06-12 at 17:12 -0400, Paul Moore wrote:
> > > > > Joe, in general I really appreciate the fixes you send, but these
> > > > > patches that cross a lot of subsystem boundaries (this isn't the first
> > > > > one that does this) causes unnecessary conflicts in -next and during
> > > > > the merge window. Could you split your patches up from now on please?
> > > >
> > > > Sorry. No. Merge conflicts are inherent in this system.
> > >
> > > Yes, merge conflicts are inherent in this system when one makes a
> > > single change which impacts multiple subsystems, e.g. changing a core
> > > kernel function which is called by multiple subsystems. However, that
> > > isn't what this patch does, it makes a number of self-contained
> > > changes across multiple subsystems; there are no cross-subsystem
> > > dependencies in this patch. You are increasing the likelihood of
> > > conflicts for no good reason; that is why I'm asking you to split this
> > > patch and others like it.
> >
> > No. History shows with high certainty that splitting
> > patches like this across multiple subsystems of a primary
> > subsystem means that the entire patchset is not completely
> > applied.
>
> I think that is due more to a lack of effort on the part of the patch
> author to keep pushing the individual patches.
Nope. Try again.
Resistance to change and desire for status quo
occurs in many subsystems.
> > It's _much_ simpler and provides a generic mechanism to
> > get the entire patch applied to send a single patch to the
> > top level subsystem maintainer.
>
> I understand it is simpler for you, but it is more difficult for everyone else.
Not true.
It's simply a matter of merge resolution being pushed down
where and when necessary.
See changes like the additions of the SPDX license tags.
> Further, where the LSMs are concerned, there is no "top level
> subsystem maintainer" anymore. SELinux and AppArmor send pull
> requests directly to Linus.
MAINTAINERS-SECURITY SUBSYSTEM
MAINTAINERS-M: James Morris <jmorris@namei.org>
MAINTAINERS-M: "Serge E. Hallyn" <serge@hallyn.com>
MAINTAINERS-L: linux-security-module@vger.kernel.org (suggested Cc:)
MAINTAINERS-T: git git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
MAINTAINERS-W: http://kernsec.org/
MAINTAINERS-S: Supported
MAINTAINERS:F: security/
MAINTAINERS-
If James is not approving or merging security/selinux or
security/tomoyo then perhaps the F: entries could be
augmented with appropriate X: entries or made specific
by using specific entries like:
F: security/*
F: security/integrity/
F: security/keys/
next prev parent reply other threads:[~2018-06-13 19:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 19:01 Joe Perches
2018-06-11 20:07 ` Casey Schaufler
2018-06-12 20:32 ` James Morris
2018-06-12 21:12 ` Paul Moore
2018-06-12 21:29 ` John Johansen
2018-06-12 21:36 ` Mimi Zohar
2018-06-13 0:29 ` Joe Perches
2018-06-13 15:49 ` Paul Moore
2018-06-13 16:04 ` Joe Perches
2018-06-13 16:19 ` Paul Moore
2018-06-13 19:30 ` Joe Perches [this message]
2018-06-13 19:57 ` Paul Moore
2018-06-13 21:14 ` Casey Schaufler
2018-06-13 21:22 ` Paul Moore
2018-06-13 15:19 ` Serge E. Hallyn
2018-06-13 23:49 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38670733fba157f7acd9c1555b44a296420f0774.camel@perches.com \
--to=joe@perches.com \
--cc=casey@schaufler-ca.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=serge@hallyn.com \
--cc=takedakn@nttdata.co.jp \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®