mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Dmitry Ilvokhin <d@ilvokhin.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH v2] mm/page_alloc: fix defrag_mode for non-reclaimable allocations
Date: Wed, 27 May 2026 09:10:03 +0200	[thread overview]
Message-ID: <38681cef-4855-49c0-b317-47357190e2f5@kernel.org> (raw)
In-Reply-To: <ahXdrP2eNYw1jc0P@cmpxchg.org>

On 5/26/26 19:51, Johannes Weiner wrote:
> On Tue, May 26, 2026 at 03:13:09PM +0200, Vlastimil Babka (SUSE) wrote:
> 
> As you may remember it was developed to help with higher order / THP
> success rates under pressure.
> 
> The impetus for actually deploying it was that we saw issues with
> avalanches of large page cache folios vacuuming up the higher-order
> chunks; this (ironically) also led to failures on the network side.
> 
> It's kind of a structural problem. We have real preproduction buffers
> for order-0 pages through the watermarks. But for higher orders we
> only ensure there is at least one page. That easily fails under even
> mild competition.
> 
> Since we wanted to roll defrag_mode for THP in multi-tenant systems
> anyway, we figured we might as well take the plunge now and battle
> test the feature this way.

Great!

> defrag_mode fixes *that* issue, by preproducing watermark buffers in
> contiguous pageblocks - making everything up to that order more
> readily available. I'm still hoping to make it the default eventually,
> which was the plan with the original huge page allocator series. As we
> keep leaning into higher order requests more and more, and especially
> grow the non-optional ones, we kind of need non-optional preproduction
> guarantees for higher orders as well.
> 
> But there are bugs like this one, and we're still figuring out some
> overreclaim issues with it in production as well. So I'm glad it's
> optional for the time being ;-)

Right :) thanks for sharing!

  reply	other threads:[~2026-05-27  7:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:22 Dmitry Ilvokhin
2026-05-21 23:59 ` Andrew Morton
2026-05-22 13:05   ` Dmitry Ilvokhin
2026-05-23  2:54     ` Andrew Morton
2026-05-23 13:50       ` Dmitry Ilvokhin
2026-05-26 13:13     ` Vlastimil Babka (SUSE)
2026-05-26 17:51       ` Johannes Weiner
2026-05-27  7:10         ` Vlastimil Babka (SUSE) [this message]
2026-05-26 13:21 ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38681cef-4855-49c0-b317-47357190e2f5@kernel.org \
    --to=vbabka@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=d@ilvokhin.com \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®