From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbcG0IBS (ORCPT ); Wed, 27 Jul 2016 04:01:18 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54008 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbcG0IBG (ORCPT ); Wed, 27 Jul 2016 04:01:06 -0400 From: Arnd Bergmann To: Rich Felker Cc: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource: j-core: type fix init function return code Date: Wed, 27 Jul 2016 10:00:50 +0200 Message-ID: <3868635.g1oGrAbjGg@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160727052533.GA6689@brightrain.aerifal.cx> References: <20160726123140.878340-1-arnd@arndb.de> <20160727052533.GA6689@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:JYWP+lPn2B1D1DKBeB/2/+WfAkWjReGzK3s1LAVZvr71PyXBqVk J5BOGW/XaTD+oPhf95/+WYUMJ4zgnBjvQNr5MH70nY64dSd5xguqNBwH3Z87uUpwllBw5B9 EMt6MciXYjQIvY9POSulpgAbYTDt7+hQYXOuDkamCvfB2YXNTm0wgi9w/aqiytKnclR/nCI 7zOoj+yZMvZKBGY5nMk1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:0Z6GsZsI+q0=:eGjFlXbQHJfIVUl9fVp8vv i/56GTZM03GRlF1YiGnny3xaOh+6H3Ep8PoL2p7xIim+6nkPGKpayswxEesESWNdgPbdb0IAO KRB2/i0t+0dqzfPL0mwK5dO1Xf7eRu0OY+QBiQkevMmOnyBMpIdiKWrtldrp365AjwwAUCN0L jZow8kyyFbGqlqlDcfhCR5HLS2di1wNTegOvm3mOZkElKdQeS75/3vv0ISptyhU7+IZiJLHud +QhHo6ZJp/kBZG6q9YcwOE99ET/AhlG7XAPMS05KzqRoo4ZWGoP0N1Jhan8i+rqTYItuByyh/ cgoQ8mFS56XhfAH06etIMbojjZy2keSwnTWHD2H6K5InBiGO36U6sK3Vy/fjZKG62tltQ6hSu E78Qge7cJVtgqAbyM0KzET30OJTZugFJUj4D2K8scWbbXPTT6n1Y1XdPIvFsdGadAHEURcixg UItIlB57zzcroB49xOL65d2XGp1P7uUdY7JTFA4+kOzH4I91+DXsXA1EStnVH7WjBUR1FvMTp l4KuIKLEvYx8oPEb21XKUU0WNgVn2gV6HCV159pBalwvwcb01tsrFHLwQC/6JXIq3Mite6f0i 92nHDX1PQ9b7E/bcoBnx7nJPzGSpKlj3O0rrkcu0h89IqlnwpPf1KIadGvM0gCcpX7+385YUG Fq0RM6u6N65TkPsCKst4UaLkSyrIa58tjG2J7tvQzkXMKdnmcZljwfsqjB+LD41VVLmTC7R+F E/iFlCfSWZIXI11e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 27, 2016 1:25:33 AM CEST Rich Felker wrote: > On Tue, Jul 26, 2016 at 02:31:29PM +0200, Arnd Bergmann wrote: > > The CLOCKSOURCE_OF_DECLARE now takes a function that returns an 'int', but a this > > new clocksource driver has just appeared in linux-next and causes a warning because > > it has the old 'void' return value: > > > > In file included from ../include/linux/clocksource.h:18:0, > > from ../include/linux/clockchips.h:13, > > from ../drivers/clocksource/jcore-pit.c:14: > > include/linux/of.h:1006:20: error: comparison of distinct pointer types lacks a cast [-Werror] > > .data = (fn == (fn_type)NULL) ? fn : fn } > > ^ > > > > This adapts the jcore_pit_init() function to the correct return type. > > > > Signed-off-by: Arnd Bergmann > > Fixes: e0aa0655c60b ("clocksource: add J-Core timer/clocksource driver") > > --- > > The patch that introduces the warnign currently only exists in the linux-sh git > > tree and showed up in linux-next this week. > > I've removed the commit from my for-next branch since it's not > appropriate to go upstream through my tree. Your patch should still be > applied in the proper subsystem tree, though, I think. Daniel? I think the way to do it now is to fold my patch into your driver and submit it to the clocksource git on top of the API change. Arnd