From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>, tomeu@tomeuvizoso.net
Cc: heiko@sntech.de, ogabbay@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] accel/rocket: Unregister the platform device if driver registration fails
Date: Tue, 3 Nov 2026 08:11:50 +0100 [thread overview]
Message-ID: <386ea2de-3f06-4931-a5bd-4885b99e5a73@kernel.org> (raw)
In-Reply-To: <20261103062319.1013449-1-vulab@iscas.ac.cn>
On 03/11/2026 07:23, Wentao Liang wrote:
> rocket_register() registers the facade platform device before registering
> the platform driver. If platform_driver_register() fails, module
> initialization returns an error without unregistering the device. The
> module exit function is not called after a failed initialization, so the
> platform device and its resources remain registered.
>
> Unregister the platform device when driver registration fails.
>
> Fixes: ed98261b4168 ("accel/rocket: Add a new driver for Rockchip's NPU")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Not even bothering to run checkpatch.
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Another fake identity of "vulab" doing exactly the same as other cases,
repeating same mistake of running unsupervised crappy bot even though
was asked multiple times to fix that.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-03 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:23 Wentao Liang
2026-11-03 7:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=386ea2de-3f06-4931-a5bd-4885b99e5a73@kernel.org \
--to=krzk@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®