From: Jan Beulich <jbeulich@suse.com>
To: Yan Yankovskyi <yyankovskyi@gmail.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen: Use 'unsigned int' instead of 'unsigned'
Date: Tue, 3 Mar 2020 09:30:17 +0100 [thread overview]
Message-ID: <38739aa0-200e-fd46-ea38-c30a6aa69561@suse.com> (raw)
In-Reply-To: <20200302221826.GA18206@kbp1-lhp-F74019>
On 02.03.2020 23:18, Yan Yankovskyi wrote:
> On Mon, Mar 2, 2020 at 10:11 Jan Beulich wrote:
>> ... evtchn_port_t here and elsewhere.
>
> There are some interfaces with signed int as a type for port, e.g. in
> include/xen/events.h.
> Should I create additional patch to resolve inconsistency with evtchn
> interface?
> Or you suggest combining these changes into the existing patch?
Signed <-> unsigned conversions would perhaps better go into a
separate patch. But note I'm not the maintainer of this code.
> Also as I understand 'evtchn' and 'port' are essentially the same
> entities from perspective of local domain, related to each other roughly
> like connection and file descriptor pair. What do you think about
> renaming all 'evtchn' arguments and variables to 'port'?
> It will eliminate inconsistencies in the code, for example
> in include/xen/interface/event_channel.h and include/xen/events.h.
I'd welcome this, but the maintainers will have the final say.
Jan
next prev parent reply other threads:[~2020-03-03 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 22:30 Yan Yankovskyi
2020-03-02 9:11 ` Jan Beulich
2020-03-02 22:18 ` Yan Yankovskyi
2020-03-03 8:30 ` Jan Beulich [this message]
2020-03-03 23:13 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38739aa0-200e-fd46-ea38-c30a6aa69561@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yyankovskyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®