From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965296AbdCWTPF (ORCPT ); Thu, 23 Mar 2017 15:15:05 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:53978 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935273AbdCWTPE (ORCPT ); Thu, 23 Mar 2017 15:15:04 -0400 Subject: Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table To: Dmitry Torokhov References: <20170222144005.23447-1-javier@osg.samsung.com> <20170222144005.23447-3-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org From: Javier Martinez Canillas Message-ID: <387639b5-01f4-2ba7-3065-5679571c08db@osg.samsung.com> Date: Thu, 23 Mar 2017 16:14:56 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170222144005.23447-3-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Dmitry, On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > The compatible strings don't have a vendor prefix because that's how it's > used currently, and changing this will be a Device Tree ABI break. > > Signed-off-by: Javier Martinez Canillas > --- > What's your decision about this patch series? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America