From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: WangYuli <wangyuli@uniontech.com>,
"james.smart@broadcom.com" <james.smart@broadcom.com>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"james_p_freyensee@linux.intel.com"
<james_p_freyensee@linux.intel.com>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"zhanjun@uniontech.com" <zhanjun@uniontech.com>,
"niecheng1@uniontech.com" <niecheng1@uniontech.com>,
"guanwentao@uniontech.com" <guanwentao@uniontech.com>,
"chenlinxuan@uniontech.com" <chenlinxuan@uniontech.com>
Subject: Re: [PATCH] nvmet-fc: Remove unused functions
Date: Wed, 12 Mar 2025 17:43:04 +0000 [thread overview]
Message-ID: <38766aaa-2080-4774-b215-f21d6fab35d5@nvidia.com> (raw)
In-Reply-To: <E2A54BF9E5C050B5+20250312050650.1793024-1-wangyuli@uniontech.com>
On 3/11/25 22:06, WangYuli wrote:
> The functions nvmet_fc_iodnum() and nvmet_fc_fodnum() are currently
> unutilized.
>
> Following commit c53432030d86 ("nvme-fabrics: Add target support for FC
> transport"), which introduced these two functions, they have not been
> used at all in practice.
>
> Remove them to resolve the compiler warnings.
>
> Fix follow errors with clang-19 when W=1e:
> drivers/nvme/target/fc.c:177:1: error: unused function 'nvmet_fc_iodnum' [-Werror,-Wunused-function]
> 177 | nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr)
> | ^~~~~~~~~~~~~~~
> drivers/nvme/target/fc.c:183:1: error: unused function 'nvmet_fc_fodnum' [-Werror,-Wunused-function]
> 183 | nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr)
> | ^~~~~~~~~~~~~~~
> 2 errors generated.
> make[8]: *** [scripts/Makefile.build:207: drivers/nvme/target/fc.o] Error 1
> make[7]: *** [scripts/Makefile.build:465: drivers/nvme/target] Error 2
> make[6]: *** [scripts/Makefile.build:465: drivers/nvme] Error 2
> make[6]: *** Waiting for unfinished jobs....
>
> Fixes: c53432030d86 ("nvme-fabrics: Add target support for FC transport")
> Signed-off-by: WangYuli<wangyuli@uniontech.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-03-12 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 5:06 WangYuli
2025-03-12 5:23 ` Christoph Hellwig
2025-03-12 17:43 ` Chaitanya Kulkarni [this message]
2025-03-12 17:59 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38766aaa-2080-4774-b215-f21d6fab35d5@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=chenlinxuan@uniontech.com \
--cc=guanwentao@uniontech.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=niecheng1@uniontech.com \
--cc=sagi@grimberg.me \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®