From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F0E1319601 for ; Thu, 9 Apr 2026 18:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775760688; cv=none; b=HJ/LJTysUwmpCi4+7NvJ5dsoE/X8QXaYHCsuz/JgHSa8OkZ0LlvkypR2OQmjK7r5JMG6Tla3pAIuh7tn0VoBKfWROi2cbh+1ATCQH/dm57F0g/GvQLZCZC045S+uu3hRdlfBlH+KoJnEMNXQVtBbU5SUTg5bSe8rCurmY2lr/mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775760688; c=relaxed/simple; bh=lfCs/5ggMLopus3/bctDEvtm+JZSXNp40vPIgVrbExU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YxOM/gswFQ/4BUUYIi3ehJkWkTUPMtevjuRIPnBYbjRYwyx2JJIHXRlr/tpXDC9E7/kBGgKhbXShJJiy9v7K9nzeJ22CEZJ5EMjPsSpt+yaPhcNF3+Xpojv5gg6PEzBv6UDWyJvtSeyP59GGuTMJ+AOy3CKWB5k+hGZ9DnmN2w4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U6R4NrkM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U6R4NrkM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775760686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBZJXslpS8fNKyokAvYFuViIcUx7NcJTjrB+1p1g9yM=; b=U6R4NrkMqRtEHWJ0TBBgeBdVLcQHhqIEKWXWqndwsuYV9fndVDVPkRLMESQRBT8l18O/bQ ZxvMFXrZm5C1R2VHr4t9RCE1k3AMYnkyiFqDxW2fPDPZWNhR7XKZO2yeIFpdG9Fz7+IGSi xWFv4nCIlPZGkJMK6xpNhj+ioFxoj5c= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-xSPrWDliOa2LSaziNaPXIw-1; Thu, 09 Apr 2026 14:51:25 -0400 X-MC-Unique: xSPrWDliOa2LSaziNaPXIw-1 X-Mimecast-MFC-AGG-ID: xSPrWDliOa2LSaziNaPXIw_1775760684 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8dbc9af20edso249227885a.0 for ; Thu, 09 Apr 2026 11:51:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775760684; x=1776365484; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zBZJXslpS8fNKyokAvYFuViIcUx7NcJTjrB+1p1g9yM=; b=HNeM8y/UTPmvclLIg6fQnpZzN7mr4433ASZ0JixsaIVlC5gTSuO0jke6ENuIC1X7Mx ZPGJYOhYSi97DNsX6ZvG8y/TR0Fju6OuaaEN5pgLd5oI2CB5BRTp1sp7SCZ0DMGQFEQS qpYeDYqWf7zgBD9LaouOI9bc2ckbOzPHOqHP5jdcgmXJxAQApLzs2O47oK4D0Yy7E+FC HoLeR9UOn68U8wVcNEDBmUegCQFGc10zvLoyeJtJFqBHDDc2XbjHYTTuw7o4o8Tload1 51UwQWOsFZ5upDqifRDi3gYYyxVNi63GXj9GdsWrwNke3OfmixS44GqtNQtNA6uueku6 HN+w== X-Gm-Message-State: AOJu0YzezRubrLLRdql069qnDohTPW6mjzO91B0STO05W5pv28F2FFcw FQZFTUSvespWjIkFiGF7Un+mI4NUqI4IDuMKZ7NqocwF1NtZHKn84JxXIIK738Y+YwAvu5kCkbN kGqYwDs7ScqZjs5GNFxpT+RtblzJtwbQNjR+/5qlwSGVHNurvXNs8Tv8j+W687TRi0ORlMMkmgg == X-Gm-Gg: AeBDiet9IuW7q9tzPGEEMfcvqCRTfC3OneMtBkpxI5AnWOKo8eVrxTxcLnWFUDBzGyj 5cs1kJez6IUoiUy2mKUQPDiufiLm3moeaVSKmNhuIy5jjJxB7jeVCMKacm6ZMulMmuyqWX3Q8fW 227394/gtSq2KR5uN4DbAIYmEXKE9tq/PeB3aYa2d1C3sP7Im+y8JMa+lWIW3TQjLz3RCvZhHds RNQnwrd2yMGJdnHRFVgbMFi+PjykS1hYys2ZbeezdFQ8+Ec0tpdhnHDiih1S8hbjBXwpsyeccEv f0T7FAHKRoUhNGRernXveR1u8QkCfKQ3mrMYg0gSdGpwJpcmLvoLi1JwHcMIGijZ7aw/M9Uwfgz olfQYpUzbgsEZtMHv2nO3CNg2yk1HGbA9fhB8XuaO2XTHMNKd7ial62qNsl3OE/Gk9E4gGv+Ujo BWAiFu+0ycx9HIC9c= X-Received: by 2002:a05:620a:d86:b0:8cf:cee2:e405 with SMTP id af79cd13be357-8dc4593a9d9mr630689785a.24.1775760684432; Thu, 09 Apr 2026 11:51:24 -0700 (PDT) X-Received: by 2002:a05:620a:d86:b0:8cf:cee2:e405 with SMTP id af79cd13be357-8dc4593a9d9mr630685585a.24.1775760683950; Thu, 09 Apr 2026 11:51:23 -0700 (PDT) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-53-69-159-169-238.dsl.bell.ca. [69.159.169.238]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ddb646dbd3sm28882785a.16.2026.04.09.11.51.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 11:51:23 -0700 (PDT) Message-ID: <387778d1-6bc7-4546-b7ed-9e6a57e64651@redhat.com> Date: Thu, 9 Apr 2026 14:51:23 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/10] drivers: nvdimm: use pgtable_has_pmd_leaves() To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@kernel.org, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <0309be4a7133ba8d043380f0c3614af764f6e3c9.1775679721.git.luizcap@redhat.com> <81879907-E65F-4F46-8A85-4D8780EA8AA2@nvidia.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <81879907-E65F-4F46-8A85-4D8780EA8AA2@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-09 11:21, Zi Yan wrote: > On 8 Apr 2026, at 16:22, Luiz Capitulino wrote: > >> nd_pfn_supported_alignments() and nd_pfn_default_alignment() use >> has_transparent_hugepage() to check if THP is supported with PMD-sized >> pages. Use pgtable_has_pmd_leaves() instead. Also, check for >> IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) to preserve the current >> implementation semantics. >> >> Signed-off-by: Luiz Capitulino >> --- >> drivers/nvdimm/pfn_devs.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c >> index 8fa9c16aba7e..457eb54e7ab6 100644 >> --- a/drivers/nvdimm/pfn_devs.c >> +++ b/drivers/nvdimm/pfn_devs.c >> @@ -94,7 +94,8 @@ static unsigned long *nd_pfn_supported_alignments(unsigned long *alignments) >> >> alignments[0] = PAGE_SIZE; >> >> - if (has_transparent_hugepage()) { >> + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && >> + pgtable_has_pmd_leaves()) { >> alignments[1] = HPAGE_PMD_SIZE; >> if (has_transparent_pud_hugepage()) > > Hmm, there is also has_transparent_pud_hugepage(). Should it be converted > to pgtable_has_pud_leavs() like has_transparent_hugepage()? > > Feel free to defer it to a future patchset. Yes, I plan to tackle that next once this one is merged. (Thanks for the reviews, btw). > > Acked-by: Zi Yan > >> alignments[2] = HPAGE_PUD_SIZE; >> @@ -109,7 +110,8 @@ static unsigned long *nd_pfn_supported_alignments(unsigned long *alignments) >> static unsigned long nd_pfn_default_alignment(void) >> { >> >> - if (has_transparent_hugepage()) >> + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && >> + pgtable_has_pmd_leaves()) >> return HPAGE_PMD_SIZE; >> return PAGE_SIZE; >> } >> -- >> 2.53.0 > > > Best Regards, > Yan, Zi >