From: Luming Yu <luming.yu@gmail.com>
To: Frans Pop <elendil@planet.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC patch] reset TSC at the begining of check_tsc_warp
Date: Tue, 2 Jun 2009 15:05:44 +0800 [thread overview]
Message-ID: <3877989d0906020005v2dc3830ala2ee688b524c5ab0@mail.gmail.com> (raw)
In-Reply-To: <200906020110.06135.elendil@planet.nl>
On Tue, Jun 2, 2009 at 7:10 AM, Frans Pop <elendil@planet.nl> wrote:
> Luming Yu wrote:
>> Without this patch, we always get kernel warning that TSC warp between
>> CPUs, and TSC is marked unstable due to check_tsc_sync_source failed if
>> the CPUs have the problem of not-synced initial TSC.
>>
>> It hurts CPUs with constant-tsc feature, but with unsynced initial TSC
>> value...
>>
>> The downside is we could break perfect synced TSC with this patch.
>> Please review, test and apply.
>
> I've tested this on my desktop (working TSC) and my laptop (non-working TSC).
> On both machines the patch didn't make any difference.
Thanks for testing, but if there was no warnings like
"Measured 439164 cycles TSC warp between CPUs, turning off TSC clock."
the patch won't help....
--Luming
next prev parent reply other threads:[~2009-06-02 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 9:01 Luming Yu
2009-06-01 23:10 ` Frans Pop
2009-06-02 7:05 ` Luming Yu [this message]
2009-06-02 7:54 ` Andi Kleen
2009-06-02 8:28 ` Luming Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3877989d0906020005v2dc3830ala2ee688b524c5ab0@mail.gmail.com \
--to=luming.yu@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®