From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3326C77B60 for ; Wed, 29 Mar 2023 00:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjC2Ai3 (ORCPT ); Tue, 28 Mar 2023 20:38:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjC2Ai0 (ORCPT ); Tue, 28 Mar 2023 20:38:26 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F27A1FEC for ; Tue, 28 Mar 2023 17:38:24 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id h25so18056700lfv.6 for ; Tue, 28 Mar 2023 17:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680050302; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dvzs0kpo0/PAizdops3QccpQcKA0hqjc3QEnrtXa61o=; b=d8cCB8tXKIOHo4KQObZdLZJ+57ilMp8eG6c96ursn1OHz5tfmDZcbncqlKfSQyI23F UQO7ijEef9D/LhjOlsh58NCKVVRQrWzk1OoCkrtQboZ1YI0ityHDImIIlnXvmDSy7jk3 OEnWJ/xvNS5iFgLCZs0gdgssMGF4pjXb9CcFI9n9fOZZPusODnzo3VKZakJrvfyCyha+ kgQgx8CzbRQB4qgr3F+LPGsoZJiEXAW+dNOgs6ezZ6FCtMzeKUK8PxkB703P92wHUqJl XsDEqSxER10z45YpG5aLqkplsQi7PQ+xbQ0D2sICQ35PTwKgoDAMd4s08Ms7KtLkyt2Q RoIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680050302; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dvzs0kpo0/PAizdops3QccpQcKA0hqjc3QEnrtXa61o=; b=ChCHqyB3MKOdOvWzsgN3xzGE4PzV2cETVkv189/WL7b8bfmb4mJpslSUJ4A9tGHLED cKiDi7RsUn7/70reNC9BQYqT9taeVsRY5OO1hs4UM9ZvkoEddFaEuwvsz/V7pMQUP/O9 p/IPsO4LfJU90MD8tLqxpVCWDDACx6PF1OI54N0JVA/63IqKrofluLNLvxzXhvKrwD33 bEQrIoR4f60vAYD4my2YKEIr+00ZH7kVe77u4hxDNQy5k/Z2Z9qiT0HNq44LTuV3+FKO uXVOdOlWfGzfS0KM8ZmYEWcj8uZvk86MF2gQFcMVlRb8v0kI2zCj+wUr8KrmW9KK5EGo V4Iw== X-Gm-Message-State: AAQBX9fP2KCJHBcRf8ggSM4VHrS+c+3wdh8Ea9YGfp7CxNxTRjZxiHkw VMUj9syjjuvwZh8YyIyanpVvbw== X-Google-Smtp-Source: AKy350ZZ6F0C87mmgmaDWhAn3/3AksFtTn60Kkv2AXombH9SF9GZimwQLrCm/8iiArekJXWhpF3W7w== X-Received: by 2002:ac2:52bb:0:b0:4b5:9b8f:cc82 with SMTP id r27-20020ac252bb000000b004b59b8fcc82mr5163830lfm.0.1680050302347; Tue, 28 Mar 2023 17:38:22 -0700 (PDT) Received: from [192.168.1.101] (abxj225.neoplus.adsl.tpnet.pl. [83.9.3.225]) by smtp.gmail.com with ESMTPSA id c18-20020ac25312000000b004eaec70c68esm3407759lfh.294.2023.03.28.17.38.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 17:38:21 -0700 (PDT) Message-ID: <38784d53-3198-3f27-06c3-6a9772cdc998@linaro.org> Date: Wed, 29 Mar 2023 02:38:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v8 4/4] arm64: dts: qcom: sc8280xp-x13s: Add bluetooth Content-Language: en-US To: Luiz Augusto von Dentz , Steev Klimaszewski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Marcel Holtmann , Johan Hedberg , Sven Peter , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, Mark Pearson , Johan Hovold References: <20230326233812.28058-1-steev@kali.org> <20230326233812.28058-5-steev@kali.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.03.2023 00:24, Luiz Augusto von Dentz wrote: > Hi Steev, > > On Sun, Mar 26, 2023 at 4:38 PM Steev Klimaszewski wrote: >> >> The Lenovo Thinkpad X13s has a WCN6855 Bluetooth controller on uart2, >> add this. >> >> Signed-off-by: Steev Klimaszewski > > I would like to merge this set but this one still doesn't have any > Signed-off-by other than yours. > >> --- Reviewed-by: Konrad Dybcio Konrad >> Changes since v7: >> * Drop regulator now in a different patchset from Johan >> * Fix alphabetization >> >> Changes since v6: >> * Remove allowed-modes as they aren't needed >> * Remove regulator-allow-set-load >> * Set regulator-always-on because the wifi chip also uses the regulator >> * cts pin uses bias-bus-hold >> * Alphabetize uart2 pins >> >> Changes since v5: >> * Update patch subject >> * Specify initial mode (via guess) for vreg_s1c >> * Drop uart17 definition >> * Rename bt_en to bt_default because configuring more than one pin >> * Correct (maybe) bias configurations >> * Correct cts gpio >> * Split rts-tx into two nodes >> * Drop incorrect link in the commit message >> >> Changes since v4: >> * Address Konrad's review comments. >> >> Changes since v3: >> * Add vreg_s1c >> * Add regulators and not dead code >> * Fix commit message changelog >> >> Changes since v2: >> * Remove dead code and add TODO comment >> * Make dtbs_check happy with the pin definitions >> >> .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 70 +++++++++++++++++++ >> 1 file changed, 70 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> index da79b5465a1b..129c5f9a2a61 100644 >> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> @@ -24,6 +24,7 @@ / { >> aliases { >> i2c4 = &i2c4; >> i2c21 = &i2c21; >> + serial1 = &uart2; >> }; >> >> wcd938x: audio-codec { >> @@ -1102,6 +1103,32 @@ &txmacro { >> status = "okay"; >> }; >> >> +&uart2 { >> + pinctrl-0 = <&uart2_default>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> + >> + bluetooth { >> + compatible = "qcom,wcn6855-bt"; >> + >> + vddio-supply = <&vreg_s10b>; >> + vddbtcxmx-supply = <&vreg_s12b>; >> + vddrfacmn-supply = <&vreg_s12b>; >> + vddrfa0p8-supply = <&vreg_s12b>; >> + vddrfa1p2-supply = <&vreg_s11b>; >> + vddrfa1p7-supply = <&vreg_s1c>; >> + >> + max-speed = <3200000>; >> + >> + enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>; >> + swctrl-gpios = <&tlmm 132 GPIO_ACTIVE_HIGH>; >> + >> + pinctrl-0 = <&bt_default>; >> + pinctrl-names = "default"; >> + }; >> +}; >> + >> &usb_0 { >> status = "okay"; >> }; >> @@ -1222,6 +1249,21 @@ hastings_reg_en: hastings-reg-en-state { >> &tlmm { >> gpio-reserved-ranges = <70 2>, <74 6>, <83 4>, <125 2>, <128 2>, <154 7>; >> >> + bt_default: bt-default-state { >> + hstp-bt-en-pins { >> + pins = "gpio133"; >> + function = "gpio"; >> + drive-strength = <16>; >> + bias-disable; >> + }; >> + >> + hstp-sw-ctrl-pins { >> + pins = "gpio132"; >> + function = "gpio"; >> + bias-pull-down; >> + }; >> + }; >> + >> edp_reg_en: edp-reg-en-state { >> pins = "gpio25"; >> function = "gpio"; >> @@ -1389,6 +1431,34 @@ reset-n-pins { >> }; >> }; >> >> + uart2_default: uart2-default-state { >> + cts-pins { >> + pins = "gpio121"; >> + function = "qup2"; >> + bias-bus-hold; >> + }; >> + >> + rts-pins { >> + pins = "gpio122"; >> + function = "qup2"; >> + drive-strength = <2>; >> + bias-disable; >> + }; >> + >> + rx-pins { >> + pins = "gpio124"; >> + function = "qup2"; >> + bias-pull-up; >> + }; >> + >> + tx-pins { >> + pins = "gpio123"; >> + function = "qup2"; >> + drive-strength = <2>; >> + bias-disable; >> + }; >> + }; >> + >> usb0_sbu_default: usb0-sbu-state { >> oe-n-pins { >> pins = "gpio101"; >> -- >> 2.39.2 >> > >