From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C0452DEA8C for ; Thu, 19 Mar 2026 19:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773946985; cv=none; b=MWasFhhlDeAapgFdLcFubZhYKqrrUG7sBz+uHq4J+u3TCQKXtVxidZWwUMViODeNcRySbQl12CWn2rTdd7cNXuXc1NToZAmSXFUHJ3nEn+PWLVY30yyzQ7UeijvzSdsEWu7RQq4slNROyAyJM1R6EJ7dQTs/9mxSl6kctw4OB14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773946985; c=relaxed/simple; bh=IAvfMaNT5KdjWO5ThRStfaBzS5WoQbA8p6DqwFaWra8=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=DuTdeDxtyRlFLsGeK+uEFkjxIp8OFstZbMFpxXzXPdxrmYJl/bHzNOgztE56HBo7d3ZiZ6+s0Zgkts3pvvVDybkdHa0h8puXsCjNU0E/es6lKXpJcRzW5u+1T103ju5VKcSrfekBgqIUDx0DNRuBYP0NdpNjMpAjYdZdRL28axQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=PUT45Q9A; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="PUT45Q9A" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-899eabc5292so10233346d6.0 for ; Thu, 19 Mar 2026 12:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1773946983; x=1774551783; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=Z1HBWRD3UdfQ/mqZ4c9b3lsjSPXBlvDoL130uUTkvuA=; b=PUT45Q9ARGa4Txm/JwqMIr2FORHCZdFGJ0vaDC701eDO0BruZMzQ5yCB2DFxbEhJKc zYiXbQiJpfe0TtL98y72ZQRwCcXYD877vNBEz8Dvp+84+1j0jKKaAkHnK1dPicRKYixL VArvdMrqU7hqFHCW2eZsXL/QSzugaOPlFMbQ5YtG+0TzW9lYBdWSdj6w3D2Gl5T3KJq/ J1zGbDL1kmRZNNTxzb2t+MkJQwiCOqgyo0RBG28nFbUBOJ01+aSLDlwGPI9km5eU3k// tsCJKvGJg2xY+F67gxnS4I2r+q48NAUbxpfUi63+WZ/bzSmxN8ZgP3db4C2En2VlHldD rPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946983; x=1774551783; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z1HBWRD3UdfQ/mqZ4c9b3lsjSPXBlvDoL130uUTkvuA=; b=Sdb5QAwSBC9h9Y3EJ71CdWr66oUWumNZzkqDilpoVWGtNfzS+Tf/3DmfP+Rd1ehJnO 8y4CRMdcpgc0RuQ3c/N24iYftTXZCMMfU0zSMv3Vy1Zob5lO3ge7F1eqS3kI4FsoVqVs v2GFL47SeqL20z+thk9WDh0J9lm1l+C+QMvKmI4XCq4eNq7t+knnqw3+uI0bBAHhJWNi IppA8fNxvKtxgOa38Nrbn04w4ts+QWsDNllJZPrSnHszn4q8SaDUvJ/a/oRf/S+kGMV4 sQZJN4FPUhCstmS5lZDqfAqwzaT/aZibS6++3LuNXX2JqHS4EUjEronjoJmVmUc0oiog JKXA== X-Forwarded-Encrypted: i=1; AJvYcCXzAFysQJ49LE3XTsv+DUuwikqa/vj+j1Raa2J4tU375VF0wetaFMNwYuA+8ReHrlMeGsiRTsm7/+vOyYQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2G+YOfurbCkcpWdlyRg5I66lw//Hk6P28kApp2RneKTs4OE6J rEIfuS3rKaF0degkVPauOj5Qdc/xL9JHx4SBKTC7eJCrML646c1tvD7OioM9Y4NbZnGuFB/yUM2 v7cH0aCk= X-Gm-Gg: ATEYQzwvlH4f848OWUcCg8yTXEHmh4bnrV0yVI9jtQhYUTSyGbZFJ4QJ2CtB2IAX2Kx Mnq8WuWA+V4LIMyKuBrkGkZ+3TGhh0552X3ZGEwO0Lqm/XLib6O3UrSIA/3dxiWj9sm+oaXL/oY f5qseHG3J9QEqWT5IOHS+EkU0QNNk3ok8ki+2u65lHYiY4dmo6YprV0MuJY8UPQTxr0Y6H1pN6P 6zkt25IyWLsTwjj3b3cIfwOluAOGXEijGokNAnHHcY3qlYYPdXlUn5V31rKY8+2aDUmsLuVIKlA r1QC836fcuMXvVkG/nVOfvY8aS45UN/6uWLK1GP4f/KWNEjQb3Xa62rL+IRlWc9Ey4xkqzQN4Xz QcqSuzkZ+Xs9jMFOsKmzvhvqrNr16db4sMx2cpBaFBIt+53amL/lQ69ZMo0RhgE4ocf3lyCzlE9 QSX2XgKxRw63Iy1RcE0pu96n+gHmSq4TtjzDcfMiojBmUNcOems30rwOhqb30DiBlE+b2IlQ== X-Received: by 2002:a05:6214:411a:b0:89c:55c1:4234 with SMTP id 6a1803df08f44-89c859cb38dmr3785616d6.2.1773946983319; Thu, 19 Mar 2026 12:03:03 -0700 (PDT) Received: from [192.168.0.189] (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c85379401sm3035576d6.46.2026.03.19.12.03.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 12:03:02 -0700 (PDT) Subject: Re: [PATCH v3 4/4] drm/msm/dpu: fix video mode DSC INTF timing width calculation To: Alexander Koskovich Cc: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Jeffrey Hugo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20260319-dsi-rgb101010-support-v3-0-85b99df2d090@pm.me> <20260319-dsi-rgb101010-support-v3-4-85b99df2d090@pm.me> <1360a31d-669e-48df-a1be-f0af4a253cd7@linaro.org> <3gLK4s97giqqXagfHKhfiIHbfbl2snwfOj9dcTNGPUYi10w9-1EdATqzz1LPCVTpz4bLFYOm8u_Fl8PfC7t5yabows4UCzRKVwjraEWW6hc=@pm.me> <3f8763af-aad2-4d92-90c8-cfd290212503@linaro.org> <7fb9dd9d-13f9-7bba-93d1-08f42dd6ee38@marek.ca> From: Jonathan Marek Message-ID: <387eeb90-df96-9d32-14fb-8fa7fa2fcd45@marek.ca> Date: Thu, 19 Mar 2026 15:02:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/19/26 1:31 PM, Alexander Koskovich wrote: > On Thursday, March 19th, 2026 at 1:23 PM, Jonathan Marek wrote: > ...>> >> The hdisplay calculation in dsi_adjust_pclk_for_compression (which only >> affects the clock rate) seems to be wrong, and I think Alexander's panel >> must be running at a 20% lower clock because of it. dsi_timing_setup has >> the right hdisplay adjustment. > > Checked against downstream and the clocks seem to match more or less: > > downstream: > pclk: 110070156 > byte: 103190771 > > upstream: > pclk: 110073457 > byte: 103193865 > I was curious about this and looked into it a bit (without testing any HW): - using MIPI_DSI_FMT_RGB101010 dsi_byte_clk_get_rate cancels the effect of adjusting with bits_per_component for the byte clk, so the byte clock ends up being right - using DST_FORMAT_RGB101010 DSI pclk is in 30-bit units instead of 24-bit units, so the pclk ends up being right too (but that only works if widebus is enabled) a recent commit (ac47870fd795) changed the hdisplay calculation in dsi_timing_setup to match that in dsi_adjust_pclk_for_compression, but only when widebus is enabled. So things work out if widebus is enabled and MIPI_DSI_FMT_RGB101010 is used (note: looks like the only upstream 10-bit panel uses MIPI_DSI_FMT_RGB888), otherwise its broken. AFAICT if you revert ac47870fd795, use MIPI_DSI_FMT_RGB888, and change dsi_adjust_pclk_for_compression to divide by 24 instead of 30, then it should also work (and won't be dependent on widebus).