From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A5FC4332F for ; Fri, 14 Oct 2022 19:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbiJNTBB (ORCPT ); Fri, 14 Oct 2022 15:01:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbiJNTAz (ORCPT ); Fri, 14 Oct 2022 15:00:55 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4900F6148 for ; Fri, 14 Oct 2022 12:00:53 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a26so12450145ejc.4 for ; Fri, 14 Oct 2022 12:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kXobvSQVt9q6I8i2aGg0lLZQfL1YP6gSaNYsr3Rxk60=; b=MImgUmR/yHX1E0wPk6/pe8Y9ZukXGsPrzZUJoI7er6YIzUUX9PGYs1Kkqnh+rjcz5H PAQDUFhnB7zWElUEIj2xnieF7UCB8cwG17+EWsy5j7tXXUXzrTd+CiqWw2iA59Z24k8X H9fgPbgfYVqLJeVTtvnZ/IoqLkGIE+MmVC0S97WsP8BVr1Qat0sc3VW4IUgNGP1u9ZjQ oQWCmuyxRrcs7hAfBJDMXVtW8KkyykN3GS5CctUlkbKzRDpivPeut160BffgdjC+AIh4 HraRHKrwWPry6MMeIQq3OkjmBsph6ZAbZl5VQ3yhLpvfkQZ33tCTHj6zLRMVLgx+bM+1 3ruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kXobvSQVt9q6I8i2aGg0lLZQfL1YP6gSaNYsr3Rxk60=; b=emCH9cSWV/hezs6jdcC2+o7IKmRPYfINfpBjR1FKX80YCfT/8XkiCj1x0e/4dP8GV0 1qRDAVyp1V+qufU7bgPLpUHN6seBNSYu/l74+Kxwp3hwgc1iVBpfe5qsHLMB7Hr/ols+ rAhPQ2DqBRL03dSjcu0P82OSfvnCAN0V5Q9l9Oz9fiCege8Tr5kJW2Sv4+/g6a6EJT0q 2faYEz4yjCG6xKQtsQRAwL9QS8uavBQM3MY4EWCHuk8uTe7TAjfQAStRTqI3432KcK6I XTE6gOh0GvMRLIXS6MHEHdM/hDxOKlhUrc2RuMgn6UB1+AG2MZVVzettRzTjKbKWYaRw H8wA== X-Gm-Message-State: ACrzQf0BCpIxREwPfBk6e8fvq9y4qRVYeq8tLJhEjrlPEfKBtHpoKJlV 3D8k26SgfgGrRTfFOu6lYUo= X-Google-Smtp-Source: AMsMyM7kttQMMDCGdRoDZGbNC9xVlTlXZ2gPlhBicHGv49oUodGeRkXKffWrQvK809oBpVw5XkBmow== X-Received: by 2002:a17:907:94c3:b0:78e:2866:f89f with SMTP id dn3-20020a17090794c300b0078e2866f89fmr2266274ejc.617.1665774052116; Fri, 14 Oct 2022 12:00:52 -0700 (PDT) Received: from ?IPV6:2003:c7:8f3e:6a24:d9ca:fb25:65a1:90fa? (p200300c78f3e6a24d9cafb2565a190fa.dip0.t-ipconnect.de. [2003:c7:8f3e:6a24:d9ca:fb25:65a1:90fa]) by smtp.gmail.com with ESMTPSA id v25-20020aa7dbd9000000b00456c6b4b777sm2199943edt.69.2022.10.14.12.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Oct 2022 12:00:51 -0700 (PDT) Message-ID: <38990e85-b74f-0910-8d64-ad614c3bd8e4@gmail.com> Date: Fri, 14 Oct 2022 21:00:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] Staging: rtl8192e: make alignment match open parenthesis Content-Language: en-US To: Anjandev Momi , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20221014081839.23902-1-anjan@momi.ca> <20221014081839.23902-4-anjan@momi.ca> From: Philipp Hortmann In-Reply-To: <20221014081839.23902-4-anjan@momi.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/22 10:18, Anjandev Momi wrote: > This patch removes the following checks generated by checkpatch.pl: > > ./drivers/staging/rtl8192e/rtl819x_BAProc.c:261: CHECK: > Alignment should match open parenthesis > ./drivers/staging/rtl8192e/rtl819x_BAProc.c:284: CHECK: > Alignment should match open parenthesis > ./drivers/staging/rtl8192e/rtl819x_BAProc.c:421: CHECK: > Alignment should match open parenthesis > ./drivers/staging/rtl8192e/rtl819x_BAProc.c:441: CHECK: > Alignment should match open parenthesis > > Signed-off-by: Anjandev Momi > --- > drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c > index f36c24c2a..8d92b3426 100644 > --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c > @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) > goto OnADDBAReq_Fail; > } > if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst, > - (u8)(pBaParamSet->field.tid), RX_DIR, true)) { > + (u8)(pBaParamSet->field.tid), RX_DIR, true)) { > rc = ADDBA_STATUS_REFUSED; > netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); > goto OnADDBAReq_Fail; > @@ -281,7 +281,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) > pBA->ba_start_seq_ctrl = *pBaStartSeqCtrl; > > if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) || > - (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) Did a git pull 2 hours ago. Cannot apply this patch because IOTAction was already renamed. Bye Philipp > + (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) > pBA->ba_param_set.field.buffer_size = 1; > else > pBA->ba_param_set.field.buffer_size = 32; > @@ -418,7 +418,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb) > } > > if (!ieee->current_network.qos_data.active || > - !ieee->pHTInfo->bCurrentHTSupport) { > + !ieee->pHTInfo->bCurrentHTSupport) { > netdev_warn(ieee->dev, > "received DELBA while QOS or HT is not supported(%d, %d)\n", > ieee->current_network. qos_data.active, > @@ -438,7 +438,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb) > struct rx_ts_record *pRxTs; > > if (!GetTs(ieee, (struct ts_common_info **)&pRxTs, dst, > - (u8)pDelBaParamSet->field.tid, RX_DIR, false)) { > + (u8)pDelBaParamSet->field.tid, RX_DIR, false)) { > netdev_warn(ieee->dev, > "%s(): can't get TS for RXTS. dst:%pM TID:%d\n", > __func__, dst,