From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F86335091 for ; Tue, 17 Feb 2026 11:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771329010; cv=none; b=HF3QczySDYijtx6ZKdnTCO8Ymf0UgHwu6wD9W/0Jqfac1U9k5LQdORy/YG3SU7KRM0lxlU0ezSb1Rc6pAiG+0VY+XoEbJVJcNacAsNiCw6CVT1UAM2REzbBHkUBnIzcaV8VDzycCDn1F8yhjvytTo1wtWCpqzszmeDzTY85ElNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771329010; c=relaxed/simple; bh=NCjtlNucLfyp5zlzwXlpdQiVGY+9jr79qHBlVQW93/8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A6b5ayNhS+bi1ZtotLIDELgA8hnkfv2QUawTVsjpjwjYiLzmJOiGreNoZzIErSd+l9kA7j7iYTN3YcavR9cr5UXMuPQ06S8H+EvSOZj/Oc50Jzp4/0MTMzdHV7UN8EzpcxYaXkHOUuqqqOc/BeOJrMfbH7SVjJHtMGMtdOSt7qI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EgyJuyKy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MbdcrILY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EgyJuyKy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MbdcrILY" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HB47XH1943542 for ; Tue, 17 Feb 2026 11:50:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wga4hiWjY8cKz3LP1L4qE8mRvDcvLKscrPkdZN0JmLI=; b=EgyJuyKy+UlE7kLu TcgkWiHq47DyOvjI2TerhEFxSuWeArTwIs3/leFfEvADxMWNKmNT5oQqKq8f9sHt 8kwUJJmInYuOAuDn2uT2ciQOI/zk97oPDMkYtapVL/tOlZkeRJzNAk385vY+W/Tt 3uJZM13hpN1ulBcMxO5EE9AAvP9pqHt/OKqnADTE0Vu5flCvkE7qCkc81sCyRzKZ 2FWRBqmKokFVUL1wQ+9geB2jDqLO/aVOA3Ka+IuWqbFm3mLjx1ChX57f0FqIcXx4 +24nDsGxMQZZxU1eH99Hb64l3ClxLjYtTG5Q3NIqhxHTBeVUCGqK5udomOpKB/lM grh/sw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ccq4g04s9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 11:50:08 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-896f5c90f07so42587976d6.0 for ; Tue, 17 Feb 2026 03:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771329007; x=1771933807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wga4hiWjY8cKz3LP1L4qE8mRvDcvLKscrPkdZN0JmLI=; b=MbdcrILYi6DqL5tU67ImhHUmdU4ZYzGu2O5ATubPxmz1Nh5tF8OMeoHlU0ljn4f6ew rMfmBnsogWeVdxplL9LAWuRvkBaJuMIIOjE4tyRIK0jBOSXc7ycl5cUcs3PJ4QxfqYEB 2FsycpcebM0SOxqVOGbAVAUtaK6bEWXQhnBVNE76ooVV/PROOwfuqQHEkwBZIQ5Wd1/1 S9O88P3nt7C3f/ohBjDN035lajLd/mLiUWhKSorTDll/QKcaQu4Y01E+qBs7n0VvN1zb 2PSwb9bw5PIFGPTOA21ux8uIiHyCSElFk9asIZRSRBIhcFtAiRy9BU98ND2+MYn/pYTm J14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771329007; x=1771933807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wga4hiWjY8cKz3LP1L4qE8mRvDcvLKscrPkdZN0JmLI=; b=M3tTFY9bz4NBNmDkFnJbefZcHcNYJx0YtarJURlN9SnWc3SDyrAfOA2I7Jm/MqhTc4 KiazFnvDWsuq6fo3eIrSdsC/Vx0d0KWUS/NQoFpJRVL80BT1MLRlYbtG2E3LjN5OwXko 9BsheWqO/GEJ5fzrp+ZUNkmGM4vD/lKA/kzz+my4B//0kMDCunlcySDBjf/faHJ2zXrq ij4aKZJvfHpvjAhTBRJgqtcOHxduJI10Mksb0Z7lZeeZtestINseRpzeRNpXLPwLBuCB J+3nhX4jJygtGvl4J8eC+AUZ5lTKKJDU29LYWG37RkyOhyGFVBs5JBC4JIteVsYrz7T3 0zlQ== X-Forwarded-Encrypted: i=1; AJvYcCXe2wVT7vil0Cn0F1iA3Bkpnr/vrSGKAMwiFhpySKQHZP7q1K+sQxGXzKaAr3CXQFLZnx8dG/UR5IELG+8=@vger.kernel.org X-Gm-Message-State: AOJu0YyO0LKnM0up/rbbBxkPFD/th6HM1KUscGSzshz9S0GLbvhHVa5D FcrHkGCAyMGXUvQdpfjZV4mQ116QbZ7MPrbL2sea6YJW2BfMNcBRnvfz7hLWpiLT5I/W4hswfLf /v9Yk4YJCih/Wwi+oFNf1XvTZjoNAUwUNmnqn8DjsRWTH1waj84wvX76fS3c4moE/ERo= X-Gm-Gg: AZuq6aJ+5j6yIqDcagwNCrxNa1hBKzVu1lozqgXtzXvMFN4Mq+v+gNx+IoJAbyUF12g Cg5kaWbY7tYIa55Xesrvck4LG8Pi1l9OMEShSnidI29ycIm+KTWZdG9fEW/u/GgGfZxguSYjLXR 7bizpbH1QN8MU5W0FRe6PkEsdYpSWhxs1Pck9wNEwQD9MNnWW94eJBedtvHBY1rxUZc/SMh8SRk 9A0ow2KoVRRJPZ7VkK/z/bMra3Jq0INxNis7PUCp8z1RGzDlOd7xTUa5evRR6Bv3xgw5qW94eAW WyV+S8zGYY8o8QLBxHerybBm89Xi6tuB0gEzRi099B+oVrVCrSWGDpJOSHGjYfOHAtKl7Rnt+2S QzE5j06VZdzL+DB1j6gLEsdmt+QCwbobNrnpsI7RaHSprA1Xgr3n90GSEz0XsQfF0ZccWLmrZed O6QJE= X-Received: by 2002:a05:6214:8008:b0:894:de0a:4cf1 with SMTP id 6a1803df08f44-89734819033mr138987046d6.8.1771329007411; Tue, 17 Feb 2026 03:50:07 -0800 (PST) X-Received: by 2002:a05:6214:8008:b0:894:de0a:4cf1 with SMTP id 6a1803df08f44-89734819033mr138986866d6.8.1771329007004; Tue, 17 Feb 2026 03:50:07 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc76655absm333837566b.51.2026.02.17.03.50.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 03:50:06 -0800 (PST) Message-ID: <389dc762-bd20-44e5-a3fc-256b42f3c82a@oss.qualcomm.com> Date: Tue, 17 Feb 2026 12:50:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/13] i2c: qcom-geni: Enable I2C on SA8255p Qualcomm platforms To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-14-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260206174112.4149893-14-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5OCBTYWx0ZWRfXwxqzM2wAiTyU kAZsgvJqA8xd8UHOx4ZjTiq2hheh4T9KoyT1S9zz0/cjOzO2QNEgXLcab/ShR5lBjiorI74b4ZK BiU8w0pclRFuJvwCVYZsu+iOZdraymyG/naH5hEg+DvSkOZRYEJCHcJuK2Rbh2Qo/Q6WZsgrh8M TTA6Q5tb0ZSnZbALJ+SDsCahWu1cYlakidb1RmhGKChnTyloQU0PpRStERmNabcpFlBes3K56Uo 60vbREi0C2GrkHjyHJBZHFwCexgpGIUHStaEdMD4hU7V5XqrpeeDh37fxPhOATZSWewIOQAQcGj lfKj+JGAaoD7tPOdWYpxooYXDx4M48WHdoNE4V9w8jblBHwlUsO3WMD/gRHkGLZHR8zMpD590d1 x+wu7oVo1E68cEG4af0Pj0IcTqbBUOcZOX20c3jYo6euMLS3NV+EvltlMjrc+qgxMz3CN7SfZCg 5j/CmMQSt8uolLKJGYA== X-Proofpoint-ORIG-GUID: 78rEw7gq_tBiR8FivdEu-zs9igpniPb6 X-Proofpoint-GUID: 78rEw7gq_tBiR8FivdEu-zs9igpniPb6 X-Authority-Analysis: v=2.4 cv=YdiwJgRf c=1 sm=1 tr=0 ts=699455f0 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=uvtuXJDLjHB1kenEHasA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170098 On 2/6/26 6:41 PM, Praveen Talari wrote: > The Qualcomm automotive SA8255p SoC relies on firmware to configure > platform resources, including clocks, interconnects and TLMM. > The driver requests resources operations over SCMI using power > and performance protocols. > > The SCMI power protocol enables or disables resources like clocks, > interconnect paths, and TLMM (GPIOs) using runtime PM framework APIs, > such as resume/suspend, to control power on/off. > > The SCMI performance protocol manages I2C frequency, with each > frequency rate represented by a performance level. The driver uses > geni_se_set_perf_opp() API to request the desired frequency rate.. > > As part of geni_se_set_perf_opp(), the OPP for the requested frequency > is obtained using dev_pm_opp_find_freq_floor() and the performance > level is set using dev_pm_opp_set_opp(). > > Acked-by: Viken Dadhaniya > Signed-off-by: Praveen Talari > --- [...] > @@ -215,6 +220,7 @@ static void qcom_geni_i2c_conf(struct geni_i2c_dev *gi2c) > val |= itr->t_low_cnt << LOW_COUNTER_SHFT; > val |= itr->t_cycle_cnt; > writel_relaxed(val, gi2c->se.base + SE_I2C_SCL_COUNTERS); > + return 0; ultra nit: a \n before return statements is preferred [...] > static const struct geni_i2c_desc i2c_master_hub = { > .no_dma_support = true, > .tx_fifo_depth = 16, > + .resources_init = geni_i2c_resources_init, > + .set_rate = qcom_geni_i2c_conf, > + .power_on = geni_se_resources_activate, > + .power_off = geni_se_resources_deactivate, > +}; > + > +static const struct geni_i2c_desc sa8255p_geni_i2c = { > + .resources_init = geni_se_domain_attach, > + .set_rate = geni_se_set_perf_opp, I noticed that because this lacks .power_on/off, the pinctrl_pm_select_xxx_state() functions are never called. Are the GPIOs managed through the power/perf domains of the QUP devices too? (I would assume not since there's a TLMM node in [0]) Konrad [0] https://lore.kernel.org/linux-arm-msm/20250422231249.871995-1-quic_djaggi@quicinc.com/