From: Maxim Levitsky <mlevitsk@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] block: fallocate: avoid false positive on collision detection
Date: Thu, 07 Jan 2021 14:42:41 +0200 [thread overview]
Message-ID: <389f04288690b44b0ea6c977894dc0592e904c90.camel@redhat.com> (raw)
In-Reply-To: <20210107124022.900172-1-mlevitsk@redhat.com>
On Thu, 2021-01-07 at 14:40 +0200, Maxim Levitsky wrote:
> Align start and end on page boundaries before calling
> invalidate_inode_pages2_range.
>
> This might allow us to miss a collision if the write and the discard were done
> to the same page and do overlap but it is still better than returning -EBUSY
> if those writes didn't overlap.
>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
This is my attempt to fix this issue. I am not 100% sure
that this is the right solution though.
Any feedback is welcome!
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2021-01-07 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45420b24124b5b91bc0a80a4abad2e06acb8c2b3.camel@redhat.com>
2021-01-07 12:40 ` Maxim Levitsky
2021-01-07 12:42 ` Maxim Levitsky [this message]
2021-01-07 15:37 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=389f04288690b44b0ea6c977894dc0592e904c90.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®