From: Marcel Holtmann <marcel@holtmann.org>
To: sheetalsingala <2396sheetal@gmail.com>
Cc: marcel@holtman.org,
Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Fixed a brace styling issue
Date: Thu, 11 Jul 2019 09:03:42 +0200 [thread overview]
Message-ID: <38EEDC9B-0C4F-4207-BD71-C03E5FC7DE51@holtmann.org> (raw)
In-Reply-To: <20190710100126.1519-1-2396sheetal@gmail.com>
Hi,
> Fixed a coding style issue
>
> Signed-off-by: Sheetal Singala <2396sheetal@gmail.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index bb99c8653aab..4a8b812605f3 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -18,7 +18,7 @@
>
> #define VERSION "0.1"
>
> -#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
> +#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
maybe you want to test your patches before sending them.
CC drivers/bluetooth/btintel.o
drivers/bluetooth/btintel.c: In function ‘btintel_check_bdaddr’:
drivers/bluetooth/btintel.c:21:24: warning: missing braces around initializer [-Wmissing-braces]
21 | #define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
| ^
drivers/bluetooth/btintel.c:50:27: note: in expansion of macro ‘BDADDR_INTEL’
50 | if (!bacmp(&bda->bdaddr, BDADDR_INTEL)) {
| ^~~~~~~~~~~~
Regards
Marcel
prev parent reply other threads:[~2019-07-11 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 10:01 sheetalsingala
2019-07-11 7:03 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38EEDC9B-0C4F-4207-BD71-C03E5FC7DE51@holtmann.org \
--to=marcel@holtmann.org \
--cc=2396sheetal@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtman.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®