From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/2] Input: arc_ps2: Improve a size determination in two functions
Date: Wed, 24 Jan 2018 18:40:24 +0100 [thread overview]
Message-ID: <38a03d93-7663-f3c3-9066-88cd935e3790@users.sourceforge.net> (raw)
In-Reply-To: <f3c837b2-7be1-11fe-ba2c-1792590125d2@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 Jan 2018 18:30:45 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/serio/arc_ps2.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/serio/arc_ps2.c b/drivers/input/serio/arc_ps2.c
index 9860b1c1e67a..6a3c845e12ea 100644
--- a/drivers/input/serio/arc_ps2.c
+++ b/drivers/input/serio/arc_ps2.c
@@ -156,9 +156,8 @@ static int arc_ps2_create_port(struct platform_device *pdev,
int index)
{
struct arc_ps2_port *port = &arc_ps2->port[index];
- struct serio *io;
+ struct serio *io = kzalloc(sizeof(*io), GFP_KERNEL);
- io = kzalloc(sizeof(struct serio), GFP_KERNEL);
if (!io)
return -ENOMEM;
@@ -195,8 +194,7 @@ static int arc_ps2_probe(struct platform_device *pdev)
return -EINVAL;
}
- arc_ps2 = devm_kzalloc(&pdev->dev, sizeof(struct arc_ps2_data),
- GFP_KERNEL);
+ arc_ps2 = devm_kzalloc(&pdev->dev, sizeof(*arc_ps2), GFP_KERNEL);
if (!arc_ps2)
return -ENOMEM;
--
2.16.1
prev parent reply other threads:[~2018-01-24 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 17:38 [PATCH 0/2] Input-arc_ps2: Adjustments for two function implementations SF Markus Elfring
2018-01-24 17:39 ` [PATCH 1/2] Input: arc_ps2: Delete an error message for a failed memory allocation in arc_ps2_probe() SF Markus Elfring
2018-01-24 17:40 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38a03d93-7663-f3c3-9066-88cd935e3790@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®