From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
jack@suse.cz, hch@infradead.org, tj@kernel.org,
josef@toxicpanda.com, axboe@kernel.dk
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v2 3/3] blk-ioprio: remove per-disk structure
Date: Fri, 19 Jul 2024 09:26:27 -0700 [thread overview]
Message-ID: <38a63742-99de-47c2-a91d-ede30a4ccd8b@acm.org> (raw)
In-Reply-To: <20240719023431.3800647-4-yukuai1@huaweicloud.com>
On 7/18/24 7:34 PM, Yu Kuai wrote:
> ioprio works on the blk-cgroup level, all disks in the same cgroup
> are the same, and the struct ioprio_blkg doesn't have anything in it.
> Hence register the policy is enough, because cpd_alloc/free_fn will
> be handled for each blk-cgroup, and there is no need to activate the
> policy for disk. Hence remove blk_ioprio_init/exit and
> ioprio_alloc/free_pd.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2024-07-19 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 2:34 [PATCH v2 0/3] " Yu Kuai
2024-07-19 2:34 ` [PATCH v2 1/3] blk-cgroup: check for pd_(alloc|free)_fn in blkcg_activate_policy() Yu Kuai
2024-07-19 5:29 ` Christoph Hellwig
2024-07-19 7:14 ` Yu Kuai
2024-07-19 16:25 ` Bart Van Assche
2024-07-20 7:17 ` Yu Kuai
2024-07-19 2:34 ` [PATCH v2 2/3] blk-ioprio: remove ioprio_blkcg_from_bio() Yu Kuai
2024-07-19 5:30 ` Christoph Hellwig
2024-07-19 16:26 ` Bart Van Assche
2024-07-19 2:34 ` [PATCH v2 3/3] blk-ioprio: remove per-disk structure Yu Kuai
2024-07-19 5:30 ` Christoph Hellwig
2024-07-19 16:26 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38a63742-99de-47c2-a91d-ede30a4ccd8b@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®