From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53488381AF8 for ; Wed, 8 Apr 2026 07:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633188; cv=none; b=R42PDJzRqFT//z7xCUygZJGKxWK/AYSxt/gM1Gk7SwdJRaEu+ao0Zu9c4G+79oiLQ2dTmryjwAD6fNM1b86UHv+WYOLUXYxx6Zrorz371yGYDt8hySFGFSbH2NeitBoesFlDAXGFb2aP5sFryQan1OVIHASZ/zXCz0qbNEzbmx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633188; c=relaxed/simple; bh=Ln3oYyk9NJD1ehlAH14Q3n59O+lfb80eWJIy2aYwuFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LhZmzOG0pS+4o6Mpx7e+XhPKJYuH7TWr/x/N9zdYJ+nPbs5PLRQ24dYL3p0kUzpZuUtLURvZ5/PE1y0DukFgDBPvffJ7SS/cLHPeRdeUHzThkrrTQhTdlR92jQuf8mRGhKTYBKuPXF1ZhhvRo+rZSeR7BnijxGm1PmXIZrz7BYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ao2psTjY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QpMo7buP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ao2psTjY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QpMo7buP" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6387Efb32860432 for ; Wed, 8 Apr 2026 07:26:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2H3ndmymhmzrh7O0zHIVLNuQNg52ggIc09GsHqPIwgE=; b=ao2psTjYeuWNlIks B5Ha/DIf2FQdzBeLJtw1QsyMDquC/j2XyIYVbKXYIN7mh7YzY/zMCUHE3P8DfwW8 2HKO31tRLLktwRrB3QMXuVigxSLZz2xGIiLiHUbLbHVyPSO+LufMCmTF6yVbf/FR Y2Z4cNxCZ0URB1s9Fb8fKC8GJ39wMPx6xyNi3L4YY3CDU3bpzhayeZq0jE4a6V0a fY7TIbaNxj1OSLpxLJZvgUjQSik99Lt7Q0NRagJDESD/pJ3NFRwGwdDo5SOPjKFe ML+jYsg4QS9kVVGllbGekzJfgPtOYgPCKcfh5kgLPIDUOYCvtQFbjbxOukpAeqNj iIweUA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddad8shr4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 07:26:24 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82c7a84a43eso9297502b3a.0 for ; Wed, 08 Apr 2026 00:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775633184; x=1776237984; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2H3ndmymhmzrh7O0zHIVLNuQNg52ggIc09GsHqPIwgE=; b=QpMo7buP2LpJPkUBfmhRhUDvImWxUy4q7AkyaJJbEoJhRsbYihqkxHzTi3ZsUKm2uW DUHqfocxSMXByxaZNfH0Ui5PLv0BcNf1N+/vXTbqu0JxL7Imm3xhJioqmZfXH/lt57w6 DOMa0EGMMHlQ5+VJEd1tWJHZV8PQTAx9dgAkDjnOTPPzrxTAz5Z+WeNveWR14diDJjsT ZfhHYV37QyoWCDMdlYSL2y3IvUgMf2kLoLCn+mjPmG7lw1QYaEIXzs6WF02xjMa8qY8P TYUjesRBdwTg2+7hZk8GHEZ5m5QedvmgByI88NbVzIIqiImuLRoHKfECqElnwDg6WPc6 qMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775633184; x=1776237984; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2H3ndmymhmzrh7O0zHIVLNuQNg52ggIc09GsHqPIwgE=; b=W/rqkCH/wCmdx+mSbWiV6+UWp58d/FcvWQObpmLKFJkVMihWXmmQqQ3aL0A7FanmCF fUTvSxzhvPyRzrWQIeO/NmylmX3lxlXrFycB48T0khHyYpSWwMam3+t62uyvJi2cqJb2 28CQ3DT8TNrZwsr64iZ8nbVLBxYRBzDzVppNRgVTIiFmjjDNfVPPoNWnNGuKs2NPv11p dCJ/mJirtYyvfPbCD+SDt6YZ8nycCZUYmwjMbosPTrRAiY05EUt/Tpxs+FwCJhirixLF nLzg0JExmjwLtcCuKdsjb1OoiFbepTHL4qJQmqCTGU8w3iMydBj+iQQ8DGEo6pMRJK+x FYrw== X-Forwarded-Encrypted: i=1; AJvYcCWeKy1v/SXVdCTOR8bH6a3V51JhbPhsCuut0wniDQvpa9ObN2Cyo8TTAzmqJGKLvWWeX/qzyKVlci7MBBU=@vger.kernel.org X-Gm-Message-State: AOJu0YxJHNlZHMFFovb/lA8A4IpHVv+6s8xzVlnPqyigM5yyVN7PdTip gvaDd3o5LqV6byNS48EK+X+Vn39eSr97Gpu8JoeIFh/zOSBU01fBrY9rdvcvmJ4SPvBvRTTzdPT ZnMkkjDgXk9GupzTug01Zke0k2Sy5YoD0r7q2fggXC+KKPy9pTbDkkt6hKne3G6Q74QA= X-Gm-Gg: AeBDies/lpYC7PDroV8jQ4eXs8oODnijCRGw1cXNuN6xB/gA6v712TjLkldpCuyhenr dgzj0SfXqjmYCSckw+fz5ziI/cPsh9nIqn9aF4x1SrYQs9uKOaSSRDta4e+KTGURvee1egy1kam 0iwlfO/hJMQf9lI+MWDmAyAixpNAQQqRI30Tp9uWFkvUtEZiYF8eEKuTihl8VGZvLCu77CrJApq 4+e1lhAt66OIiwiaQNfG3VV2+TWLJFhswBYT/sQH8I4QaSitURReimr/C/WAsEGEF7MaR3ZSu4b 9SHYxgjQLlmT72/g5yD4ABBzT3Ejd+Vd99VBz6/QDFasKj5KIKZh8in0tVC8bER1z1uzhJVuR/s btHYKhufWc2fBpppkm8LwxCW5jYEPmzckyHjRQHbmb5Qggaxhow== X-Received: by 2002:a05:6a00:800a:b0:82a:6d9d:3f85 with SMTP id d2e1a72fcca58-82d0dbbca07mr20585721b3a.48.1775633183760; Wed, 08 Apr 2026 00:26:23 -0700 (PDT) X-Received: by 2002:a05:6a00:800a:b0:82a:6d9d:3f85 with SMTP id d2e1a72fcca58-82d0dbbca07mr20585685b3a.48.1775633183348; Wed, 08 Apr 2026 00:26:23 -0700 (PDT) Received: from [10.217.217.198] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c68273sm24431255b3a.41.2026.04.08.00.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 00:26:23 -0700 (PDT) Message-ID: <38aa8c0b-fb29-44c9-a346-363220264c7c@oss.qualcomm.com> Date: Wed, 8 Apr 2026 12:56:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] clk: qcom: common: ensure runtime PM suspend completes on probe To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-3-4bb5583a5054@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: HrPtBrLTY3YTvOnCa1Ll2yK8zCL1HX_B X-Proofpoint-GUID: HrPtBrLTY3YTvOnCa1Ll2yK8zCL1HX_B X-Authority-Analysis: v=2.4 cv=EoDiaycA c=1 sm=1 tr=0 ts=69d60320 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Ej0lypjitWEjAblOXOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDA2NiBTYWx0ZWRfXxZMsP/q1zrIX hmDyJOXe90MJsI9bFX7843kTettYYpuQQyiDEyihHQK3BQEUKyNmkryLUBd4iJ9WvxsLgQlVUPB QCyOrjYi44VhmeXM81tGGXvqn+8UyLP7LBJm3W6A2dM+5y7WjECwcH5rWum0g//WT1lufhihlka 6PGoeUvJm8A5DF+J2NixGGqwciTyhdq66E1Du5QKXnGkgiZEniXx0Se1hXV4O+r6tdNcVPVu60z Zm9yTSH/q9dYcrTUjYSXpJNu9a/w5lFId4UxzALaVo5yby0Q+Yi/fX26E47dmnYpTFNxyAO2xTu EFAhXwp6qjIUT8O0NcZrhfuKnmXTbCn2i8zjKgLaex0TJlRnW+qqkA0Eruoc3hLO3gQLGDVyOzU ucDfh5Nv5tKpOyeZ0C4wX8BMbToaXtfU0uC60dztUHr01KY9YusPMTcaeUNFcMjn0Wb9hipO27J TNTCSf8Fd3VcD5FLuQA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_03,2026-04-07_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080066 On 4/7/2026 4:28 PM, Konrad Dybcio wrote: > On 4/7/26 11:30 AM, Taniya Das wrote: >> When the clock controller is probed with 'use_rpm' enabled, the >> runtime PM reference is currently released using pm_runtime_put(), >> which may return before the runtime suspend has completed. This >> can leave the power domain transition in progress while the probe >> path continues or returns. >> >> Use pm_runtime_put_sync() instead to ensure the runtime PM “put” >> completes synchronously during probe, guaranteeing the device is >> fully runtime‑suspended before returning. > > It's not immediately obvious why that's an issue, is there an > observable problem when the transition doesn't complete in time? > > Konrad Calling pm_runtime_disable() immediately after pm_runtime_put() prevents the runtime suspend from completing, leaving the clock controller active and the HW rails in the ON state. -- Thanks, Taniya Das