From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbdBARHv (ORCPT ); Wed, 1 Feb 2017 12:07:51 -0500 Received: from smtpout.microchip.com ([198.175.253.82]:40656 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752764AbdBARHt (ORCPT ); Wed, 1 Feb 2017 12:07:49 -0500 Subject: Re: [PATCH] usb: gadget: udc: atmel: fix debug output To: Alexandre Belloni , Arnd Bergmann References: <20170201164218.2421617-1-arnd@arndb.de> <20170201170052.pvltw6punq6ncmwr@piout.net> CC: Felipe Balbi , Greg Kroah-Hartman , , , From: Nicolas Ferre Organization: microchip Message-ID: <38aae02a-1092-0af3-7fc8-6c7a7e3cd394@microchip.com> Date: Wed, 1 Feb 2017 18:08:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170201170052.pvltw6punq6ncmwr@piout.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 01/02/2017 à 18:00, Alexandre Belloni a écrit : > On 01/02/2017 at 17:41:55 +0100, Arnd Bergmann wrote: >> The debug output now contains the wrong variable, as seen from the compiler >> warning: >> >> drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_ep_enable': >> drivers/usb/gadget/udc/atmel_usba_udc.c:632:550: error: 'ept_cfg' may be used uninitialized in this function [-Werror=maybe-uninitialized] >> DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", >> >> This changes the debug output the same way as the other code. >> >> Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") >> Signed-off-by: Arnd Bergmann > Acked-by: Alexandre Belloni Acked-by: Nicolas Ferre > >> --- >> drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c >> index 11bbce28bc23..2035906b8ced 100644 >> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c >> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c >> @@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) >> { >> struct usba_ep *ep = to_usba_ep(_ep); >> struct usba_udc *udc = ep->udc; >> - unsigned long flags, ept_cfg, maxpacket; >> + unsigned long flags, maxpacket; >> unsigned int nr_trans; >> >> DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc); >> @@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) >> ep->is_in = 0; >> >> DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", >> - ep->ep.name, ept_cfg, maxpacket); >> + ep->ep.name, ep->ept_cfg, maxpacket); >> >> if (usb_endpoint_dir_in(desc)) { >> ep->is_in = 1; >> -- >> 2.9.0 >> > -- Nicolas Ferre