From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B76743BB136; Tue, 15 Sep 2026 13:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789477766; cv=none; b=thjGpojS3Hlmoq/exw4rFy7hMO/2jSXfJkisDi9zCMIdow6wFBSTQiLIrAyqB+k426LG5PsKabj9ypzzQwpzL5thST1RJd6ho7OZOtxxE38umo6acfVXBv3+VJ+tYhiCId7dfiTKOGmjkx1qIpITPjVnfWMf7Hsd93daFls8vEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789477766; c=relaxed/simple; bh=bFAPpX6w1Fe8GbyYI1ud4qT6ompgjC4/11AnVPQw0Po=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T4etxNM2hE7UNQ06eNWMI8AC7f6xzXUHSeMHVVzjBZpmEMFuMIC7enIOhZ7BSzfbo4oLahM2v0WPJlWerUhjfrKQFnxpPBOxkkwOfWLYpm/7M40ncJdagCPLK8uwgKCZGT4faVD0nkO6aroeiEOfA8t6lEXjyF/JGkY8pA6BBIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256:X25519MLKEM768) (Exim 4.100) (envelope-from ) id 1x6SuV-000000000Cv-07aB; Tue, 15 Sep 2026 13:09:19 +0000 Date: Tue, 15 Sep 2026 14:09:16 +0100 From: Daniel Golle To: Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Daniel Golle , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Lunn , Vladimir Oltean , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Subject: [PATCH net-next v16 1/6] net: dsa: add devlink flash_update callback to dsa_switch_ops Message-ID: <38abd1efa0da34be260c5799a18df401b7494a0a.1789477568.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Add a devlink_flash_update callback to dsa_switch_ops so that DSA drivers can support devlink dev flash without open-coding the devlink plumbing. Like the other trampolines in net/dsa/devlink.c, the op returns -EOPNOTSUPP when the driver does not implement the callback. The devlink core takes a non-NULL ops->flash_update as the capability gate, so on a switch without the callback a flash request now fetches the firmware file first: a missing file fails with -ENOENT instead of -EOPNOTSUPP, and a file that is found reaches the trampoline inside a FLASH_UPDATE/FLASH_UPDATE_END notification pair. Both are acceptable for an operation as infrequent as a firmware update. The devlink core calls the op with the devlink instance lock held and without rtnl_lock, whereas DSA serialises its switch and port ops under rtnl_lock, so a driver has to serialise a flash against its own ops itself. Signed-off-by: Daniel Golle Reviewed-by: Andrew Lunn --- v16: - commit message: name the errno and the notifications the shared ops table changes for switches without the callback (found by Sashiko AI review) - commit message: a missing firmware file fails before the notification pair, which wraps only the call into the trampoline v15: no changes v14: no changes, picked up Andrew's v13 Reviewed-by v13: no changes v12: no changes v11: no changes v10: no changes v9: install the flash_update op unconditionally and return -EOPNOTSUPP from the trampoline like the other DSA devlink trampolines, instead of a second devlink_ops permutation (Andrew Lunn) v8: - retitled: this patch adds the callback, its first user is patch 3 - describe the op's calling context in the commit message v7: no changes v6: no changes v5: no changes v4: only install the flash_update op for drivers implementing the callback so the devlink core keeps rejecting unsupported flash requests before fetching the firmware file v3: no changes v2: align continuation lines with the open parenthesis include/net/dsa.h | 3 +++ net/dsa/devlink.c | 13 +++++++++++++ 2 files changed, 16 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index 7507d632e7c6..9babab92a0fc 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -1174,6 +1174,9 @@ struct dsa_switch_ops { int (*devlink_info_get)(struct dsa_switch *ds, struct devlink_info_req *req, struct netlink_ext_ack *extack); + int (*devlink_flash_update)(struct dsa_switch *ds, + struct devlink_flash_update_params *params, + struct netlink_ext_ack *extack); int (*devlink_sb_pool_get)(struct dsa_switch *ds, unsigned int sb_index, u16 pool_index, struct devlink_sb_pool_info *pool_info); diff --git a/net/dsa/devlink.c b/net/dsa/devlink.c index ed342f345692..25311a87cbc5 100644 --- a/net/dsa/devlink.c +++ b/net/dsa/devlink.c @@ -20,6 +20,18 @@ static int dsa_devlink_info_get(struct devlink *dl, return -EOPNOTSUPP; } +static int dsa_devlink_flash_update(struct devlink *dl, + struct devlink_flash_update_params *params, + struct netlink_ext_ack *extack) +{ + struct dsa_switch *ds = dsa_devlink_to_ds(dl); + + if (!ds->ops->devlink_flash_update) + return -EOPNOTSUPP; + + return ds->ops->devlink_flash_update(ds, params, extack); +} + static int dsa_devlink_sb_pool_get(struct devlink *dl, unsigned int sb_index, u16 pool_index, struct devlink_sb_pool_info *pool_info) @@ -169,6 +181,7 @@ dsa_devlink_sb_occ_tc_port_bind_get(struct devlink_port *dlp, static const struct devlink_ops dsa_devlink_ops = { .info_get = dsa_devlink_info_get, + .flash_update = dsa_devlink_flash_update, .sb_pool_get = dsa_devlink_sb_pool_get, .sb_pool_set = dsa_devlink_sb_pool_set, .sb_port_pool_get = dsa_devlink_sb_port_pool_get, -- 2.55.0