From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-248.mta0.migadu.com [91.218.175.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C6A73DFC6B for ; Wed, 19 Aug 2026 08:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.248 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787126435; cv=none; b=gt3Cw0CDS4gaBMdxcGHM1Lbjn7Bdwoy7FCxgvwDAEAd42Bt49+LQGQavy2VDBEzdMTJRMQlS82e3xP2xSpEejj8gpj1HRcJ4/w/lCgABz5povjIB9PO4NE83yeeR2a0hhmjGP1WYtmbOYQy1t2cMt3m/o0N0bk4W1yr5WCnDkTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787126435; c=relaxed/simple; bh=O0t9qk8cRjvR1W8iG5/jIx4GP/yhv1rQ1ckZ56PJR2U=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=kEuc7UZjfgJnGRw/Q9u4gIL78oE4Q8X5hBTP8ccsFVXDN/oEL4kCfaUHnH3g/jb2wWaclKHKurY9xgyM1fqbe5n2sqdIEfn1yR0SgHZGiBuoUximDjGfCapiSpcMLq5EDYiagLBaNma6Erah3SpWHOr4Wi01xBfCQNNmU4lK+jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=neGf+4+X; arc=none smtp.client-ip=91.218.175.248 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="neGf+4+X" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=O0t9qk8cRjvR1W8iG5/jIx4GP/yhv1rQ1ckZ56PJR2U=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787126428; v=1; x=1787731228; b=neGf+4+XELHWeR0ENJWZmfO2F93mT7jPZ+1uNozCaaKhmjUnYVpg5nSCYeEtVeimGH/kxNs4 K1WCZB9MTjUvaFANnKdoTMWXNan2D1Zn+75qWMkUOC7EongmQOJWNdFDjioV0R42zd/INDlwHNC QQbhfW7wjnnQn361HcyvKx3E= X-Envelope-To: linux-kernel@vger.kernel.org Received: from webmail.migadu.com (2001:41d0:303:fc7a::) by smtp.migadu.com with ESMTPS id 662ced0c2f743159; Wed, 19 Aug 2026 08:00:18 +0000 X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 19 Aug 2026 08:00:18 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Siratul Islam" Message-ID: <38ad21d4eaf5c7071aaf45d2ce650daffe16ef6b@linux.dev> TLS-Required: No Subject: Re: [PATCH v7 2/2] iio: adc: add MAX40080 current-sense amplifier driver To: "Stefan Popa" , linux-iio@vger.kernel.org Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux@roeck-us.net, joshua.crofts1@gmail.com, ciprian.hegbeli@analog.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Stefan Popa" In-Reply-To: <20260818142928.8244-3-stefan.popa@analog.com> References: <20260818142928.8244-1-stefan.popa@analog.com> <20260818142928.8244-3-stefan.popa@analog.com> August 18, 2026 at 8:29 PM, "Stefan Popa" wrote: >=20 >=20The MAX40080 is a bidirectional current-sense amplifier with an > integrated 12-bit ADC and an I2C/SMBus interface. It measures the > voltage across an external shunt resistor and the input bus voltage, > storing the results in an internal FIFO. >=20 >=20Add a direct-mode IIO driver exposing the current and voltage channel= s > with raw, scale and hardware-gain attributes, a configurable > oversampling (digital averaging) ratio, and PEC-protected register > access. The current scale is derived from the shunt resistor value > described in the device tree. >=20 >=20The driver operates in single-measurement mode: each raw read trigger= s > an on-demand conversion via SMBus Quick Command and returns a matched > current/voltage pair. This avoids the latency and complexity of the > continuous FIFO mode while ensuring each read reflects the current > state. The two selectable current-sense ranges are exposed through > scale/scale_available. >=20 >=20Continuous FIFO buffering, threshold events and the alert interrupt a= re > intentionally left out of this initial submission and may be added > later. >=20 >=20Co-developed-by: Ciprian Hegbeli > Signed-off-by: Ciprian Hegbeli > Signed-off-by: Stefan Popa > --- > Looks like my concerns have been addressed. Assuming you are going to sen= d v8 with fixes for Andy and Jonathan, feel free to add my tag. Reviewed-by: Siratul Islam