From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762023AbdALBN0 (ORCPT ); Wed, 11 Jan 2017 20:13:26 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:44406 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbdALBNX (ORCPT ); Wed, 11 Jan 2017 20:13:23 -0500 X-AuditID: b6c32a2e-f79f46d000002a13-17-5876d82fa26f Subject: Re: [PATCH 1/4] PCI: exynos: replace to one register accessor from each accessors To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, helgaas@google.com, krzk@kernel.org, linux-kernel@vger.kernel.org, jingoohan1@gmail.com, javier@osg.samsung.com, kgene@kernel.org, linux-samsung-soc@vger.kernel.org, CPGS From: Jaehoon Chung Message-id: <38b40475-97fc-da8a-82f4-4c5932a008a1@samsung.com> Date: Thu, 12 Jan 2017 10:13:18 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <20170111185003.GG14532@bhelgaas-glaptop.roam.corp.google.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNJsWRmVeSWpSXmKPExsWy7bCmpq7+jbIIg0lHBSxeHtK0mPV8D6vF qzNr2SzevF3DZLHiy0x2i/7Hr5ktzp/fwG5xedccNouz846zWcw4v4/Jgctj56y77B4LNpV6 bFrVyeaxpR/I69uyitHj8ya5ALaoVJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtz JYW8xNxUWyUXnwBdt8wcoMOUFMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6 RkZGeibGsVZGpkAlCakZK1rmMBe8Eq840LifqYHxkHAXIyeHhICJxOeWblYIW0ziwr31bF2M XBxCAksZJaasv8QIkhASaGeS2H06AKbhxNS/jBBFcxgljk5vhXLuMUpM372bBaRKWCBG4tWG XUxdjBwcIgJqEl3toSA1zAIPGCVe/90Ato5NQEdi+7fjTCA2r4CdxPFNr9hAbBYBVYmO3zfA akQFwiQ233/JDlEjKPFj8j2w+ZwC3hKrGhaC1TMLGEjMmHKYCcKWl9i85i0zyDIJgUPsEs37 TrOBHCEhICux6QAzxAcuEn9nTGeCsIUlXh3fwg5hS0v8XXqLEaK3m1Hi35eNbBBOD6PEra2r oTqMJe4/uMcMsY1Povf3EyaIBbwSHW1CECUeEkcmnYcqd5S4O60FGkINTBK3Lp1mmsAoPwvJ Q7OQPDELyRMLGJlXMYqlFhTnpqcWmxYY6xUn5haX5qXrJefnbmIEJ0wtvR2M/xZ4H2IU4GBU 4uHtWFEWIcSaWFZcmXuIUYKDWUmEl+8aUIg3JbGyKrUoP76oNCe1+BCjKTCQJzJLiSbnA5N5 Xkm8oYmZoYmRJRCaG5orifMuqLCOEBJITyxJzU5NLUgtgulj4uCUamDcwhVyTznLdV2WnpuJ LJ+L8d2kzOqE6uwl59wPcJ6d5LV9QlrB4QlztqY2/b6d6iw2Ue6qqvEsl5VKpXNmn6raPuWO fteq6cZe7arL15k+vm206NtxF0u7gtpZXo8Z+Y9ksk8tZJh3UqFb/Pzue5ea1p56mbFS54a3 8LTSLIacL0ligmm1y9YrsRRnJBpqMRcVJwIA0w2Imq4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t9jQV29G2URBo2HtS1eHtK0mPV8D6vF qzNr2SzevF3DZLHiy0x2i/7Hr5ktzp/fwG5xedccNouz846zWcw4v4/Jgctj56y77B4LNpV6 bFrVyeaxpR/I69uyitHj8ya5ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UI Xd+QICWFssScUiDPyAANODgHuAcr6dsluGWsaJnDXPBKvOJA436mBsZDwl2MnBwSAiYSJ6b+ ZYSwxSQu3FvP1sXIxSEkMItR4l7/dVYI5wGjRPu3uSwgVcICMRKvNuxi6mLk4BARUJPoag+F qGlgkrj/bxsziMMM0rBr2mZWkAY2AR2J7d+OM4HYvAJ2Esc3vWIDsVkEVCU6ft9gBRkkKhAm 8bzRCaJEUOLH5HtguzgFvCVWNSxkAylhFtCTuH9RCyTMLCAvsXnNW+YJjEBXInTMQqiahaRq ASPzKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzgKHwmvYPx8C73Q4wCHIxKPLwMx8si hFgTy4orcw8xSnAwK4nw8l0DCvGmJFZWpRblxxeV5qQWH2I0BfpiIrOUaHI+MEHklcQbmpib mBsbWJhbWpoYKYnzNs5+Fi4kkJ5YkpqdmlqQWgTTx8TBKdXAqNMUseFm1c5jkZfkd8ZfLAk9 ueJEq4HTqYiQ0OykXNG7PHePXVGTLezxWXN24mHOyQezr679duZjbbbB24WZz9pVr4Uds3zQ 6BGRN+XG5x1OAjoH2CKiWw8znlyqJn3z1OF/R7+pffdcV2ptE2f9K3WebtqjdKlQpa26HhIW LbOLQnuuHc84rMRSnJFoqMVcVJwIAOJS0RLYAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170112011318epcas5p210f9fd225fd4e87f380fe0dbb7765650 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170111185058epcas4p3b75597ea7f18d0ac10a16fc752a708ca X-RootMTR: 20170111185058epcas4p3b75597ea7f18d0ac10a16fc752a708ca References: <20161219081614.5403-1-jh80.chung@samsung.com> <20161219081614.5403-2-jh80.chung@samsung.com> <20170111185003.GG14532@bhelgaas-glaptop.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On 01/12/2017 03:50 AM, Bjorn Helgaas wrote: > Hi Jaehoon, > > On Mon, Dec 19, 2016 at 05:16:11PM +0900, Jaehoon Chung wrote: >> There is no reason to maintain *_blk/phy/elbi_* as register accessors. >> It can be replaced to one register accessor. >> >> Signed-off-by: Jaehoon Chung >> --- >> drivers/pci/host/pci-exynos.c | 214 +++++++++++++++++++----------------------- >> 1 file changed, 97 insertions(+), 117 deletions(-) >> >> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c >> index f1c544b..6dbfa2c 100644 >> --- a/drivers/pci/host/pci-exynos.c >> +++ b/drivers/pci/host/pci-exynos.c >> @@ -102,197 +102,175 @@ struct exynos_pcie { >> #define PCIE_PHY_TRSV3_PD_TSV (0x1 << 7) >> #define PCIE_PHY_TRSV3_LVCC 0x31c >> >> -static void exynos_elb_writel(struct exynos_pcie *exynos_pcie, u32 val, u32 reg) >> +static void exynos_pcie_writel(void __iomem *base, u32 val, u32 reg) >> { >> - writel(val, exynos_pcie->elbi_base + reg); >> + writel(val, base + reg); >> } >> >> -static u32 exynos_elb_readl(struct exynos_pcie *exynos_pcie, u32 reg) >> +static u32 exynos_pcie_readl(void __iomem *base, u32 reg) >> { >> - return readl(exynos_pcie->elbi_base + reg); >> + return readl(base + reg); >> } >> >> -static void exynos_phy_writel(struct exynos_pcie *exynos_pcie, u32 val, u32 reg) >> -{ >> - writel(val, exynos_pcie->phy_base + reg); >> -} >> - >> -static u32 exynos_phy_readl(struct exynos_pcie *exynos_pcie, u32 reg) >> -{ >> - return readl(exynos_pcie->phy_base + reg); >> -} >> - >> -static void exynos_blk_writel(struct exynos_pcie *exynos_pcie, u32 val, u32 reg) >> -{ >> - writel(val, exynos_pcie->block_base + reg); >> -} >> - >> -static u32 exynos_blk_readl(struct exynos_pcie *exynos_pcie, u32 reg) >> -{ >> - return readl(exynos_pcie->block_base + reg); >> -} >> - >> -static void exynos_pcie_sideband_dbi_w_mode(struct exynos_pcie *exynos_pcie, >> - bool on) >> +static void exynos_pcie_sideband_dbi_w_mode(struct exynos_pcie *ep, bool on) > > Replacing all the separate accessors with one that takes the base > pointer is OK, but please use the same name for all the "struct > exynos_pcie *" pointers in the whole file. > > Before your patch, they were all called "exynos_pci"; after it some > are called "exynos_pci" and some are called "ep". I will use the 'ep' as name, exynos_pcie is a little bit long. When 'exynos_pcie' is used, some code is need to change lines because of 80 char. I think it's the meaningless line changing. I will resend the PATCH v2..also patches relevant to using PHY framework. After applying everything, i will upstream TM2(Exynos5433) PCIe patches. Thanks for reviewing. Best Regards, Jaehoon Chung > > Bjorn > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >