From: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
mohammad.rafi.shaik@oss.qualcomm.com,
ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v3 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support
Date: Thu, 30 Jul 2026 14:19:55 +0530 [thread overview]
Message-ID: <38bb5227-9be8-41d4-8211-9733d7f3cdba@oss.qualcomm.com> (raw)
In-Reply-To: <0267f9d0-f2ab-4b54-9989-37902bd5b066@oss.qualcomm.com>
On 7/29/2026 3:05 PM, Konrad Dybcio wrote:
> On 7/23/26 2:15 PM, Ravi Hothi wrote:
>> Add SoC-level LPASS WSA macro, VA macro, SoundWire controller and LPASS
>> LPI pin controller nodes. DMIC and WSA SoundWire pinctrl states are
>> defined inside the LPASS LPI pin controller node. The hardware is similar
>> to the SM8750 platform.
>>
>> The WSA macro, VA macro and SoundWire controller are kept disabled so
>> board DTS files can selectively enable and configure them.
>>
>> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
>> ---
>
> [...]
>
>> + lpass_wsamacro: codec@6b00000 {
>> + compatible = "qcom,eliza-lpass-wsa-macro",
>> + "qcom,sm8550-lpass-wsa-macro";
>> + reg = <0x0 0x06b00000 0x0 0x1000>;
>> +
>> + clocks = <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_MCLK
>> + LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> + <&q6prmcc LPASS_HW_MACRO_VOTE
>> + LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> + <&q6prmcc LPASS_HW_DCODEC_VOTE
>> + LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> + <&lpass_vamacro>;
>> + clock-names = "mclk",
>> + "macro",
>> + "dcodec",
>> + "fsgen";
>> +
>> + #clock-cells = <0>;
>> + clock-output-names = "mclk";
>> + #sound-dai-cells = <1>;
>> +
>> + status = "disabled";
>
> All macros (but not swr hosts) are usually enabled by default on other
> socs, let's do the same here
ACK, Will update in next version.
Thanks,
Ravi Hothi
>
> Konrad
next prev parent reply other threads:[~2026-07-30 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 12:15 [PATCH v3 0/2] arm64: dts: qcom: eliza: Add audio support Ravi Hothi
2026-07-23 12:15 ` [PATCH v3 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support Ravi Hothi
2026-07-29 9:34 ` Konrad Dybcio
2026-07-29 9:35 ` Konrad Dybcio
2026-07-30 8:49 ` Ravi Hothi [this message]
2026-07-23 12:15 ` [PATCH v3 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC Ravi Hothi
2026-07-29 9:35 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38bb5227-9be8-41d4-8211-9733d7f3cdba@oss.qualcomm.com \
--to=ravi.hothi@oss.qualcomm.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®