mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Wake Liu <wakel@google.com>, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/filesystems/binderfs: Skip tests if user namespaces are unavailable
Date: Thu, 7 Aug 2025 13:24:13 -0600	[thread overview]
Message-ID: <38bbacc3-625d-4071-889c-a5b4d59ec456@linuxfoundation.org> (raw)
In-Reply-To: <20250807134510.1818025-1-wakel@google.com>

On 8/7/25 07:45, Wake Liu wrote:
> The binderfs selftests, specifically `binderfs_stress` and
> `binderfs_test_unprivileged`, depend on user namespaces to run.
> 
> On kernels built without user namespace support (CONFIG_USER_NS=n),
> these tests will fail.

Why not add CONFIG_USER_NS to config file instead to indicate the
dependency.

tools/testing/selftests/filesystems/binderfs/config which has these
as dependencies at the moment.

CONFIG_ANDROID_BINDERFS=y
CONFIG_ANDROID_BINDER_IPC=y
> 
> To prevent these failures, add a check for the availability of user
> namespaces by testing for the existence of "/proc/self/ns/user". If
> the check fails, skip the tests and print an informative message.]

Can you try adding the dependency first?

thanks,
-- Shuah

  reply	other threads:[~2025-08-07 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 13:45 Wake Liu
2025-08-07 19:24 ` Shuah Khan [this message]
2025-08-09  9:26   ` [PATCH v2] selftests/binderfs: Add CONFIG_USER_NS dependency Wake Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38bbacc3-625d-4071-889c-a5b4d59ec456@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=wakel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®